Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/692962/?format=api
{ "id": 692962, "url": "http://patchwork.ozlabs.org/api/patches/692962/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20161109222606.29039-15-sw@simonwunderlich.de/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20161109222606.29039-15-sw@simonwunderlich.de>", "list_archive_url": null, "date": "2016-11-09T22:26:03", "name": "[14/17] batman-adv: Remove dev_queue_xmit return code exception", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b8c56b70e43223beba8e1fd7f5bc09d8a9ff5206", "submitter": { "id": 47054, "url": "http://patchwork.ozlabs.org/api/people/47054/?format=api", "name": "Simon Wunderlich", "email": "sw@simonwunderlich.de" }, "delegate": { "id": 34, "url": "http://patchwork.ozlabs.org/api/users/34/?format=api", "username": "davem", "first_name": "David", "last_name": "Miller", "email": "davem@davemloft.net" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20161109222606.29039-15-sw@simonwunderlich.de/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/692962/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/692962/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3tDgl52jQSz9t2N\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu, 10 Nov 2016 09:26:41 +1100 (AEDT)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1754728AbcKIW0i (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tWed, 9 Nov 2016 17:26:38 -0500", "from packetmixer.de ([79.140.42.25]:55501 \"EHLO\n\tmail.mail.packetmixer.de\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1754720AbcKIW0g (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Wed, 9 Nov 2016 17:26:36 -0500", "from kero.packetmixer.de (roof.metalab.wien.funkfeuer.at\n\t[78.41.112.119])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mail.mail.packetmixer.de (Postfix) with ESMTPSA id A1587180010;\n\tWed, 9 Nov 2016 23:26:35 +0100 (CET)" ], "From": "Simon Wunderlich <sw@simonwunderlich.de>", "To": "davem@davemloft.net", "Cc": "netdev@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org,\n\tSven Eckelmann <sven@narfation.org>,\n\tSimon Wunderlich <sw@simonwunderlich.de>", "Subject": "[PATCH 14/17] batman-adv: Remove dev_queue_xmit return code\n\texception", "Date": "Wed, 9 Nov 2016 23:26:03 +0100", "Message-Id": "<20161109222606.29039-15-sw@simonwunderlich.de>", "X-Mailer": "git-send-email 2.10.1", "In-Reply-To": "<20161109222606.29039-1-sw@simonwunderlich.de>", "References": "<20161109222606.29039-1-sw@simonwunderlich.de>", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "From: Sven Eckelmann <sven@narfation.org>\n\nNo caller of batadv_send_skb_to_orig is expecting the results to be -1\n(-EPERM) anymore when the skbuff was not consumed. They will instead expect\nthat the skbuff is always consumed. Having such return code filter is\ntherefore not needed anymore.\n\nSigned-off-by: Sven Eckelmann <sven@narfation.org>\nSigned-off-by: Simon Wunderlich <sw@simonwunderlich.de>\n---\n net/batman-adv/send.c | 17 ++++++-----------\n 1 file changed, 6 insertions(+), 11 deletions(-)", "diff": "diff --git a/net/batman-adv/send.c b/net/batman-adv/send.c\nindex b00aac7..9ea272e 100644\n--- a/net/batman-adv/send.c\n+++ b/net/batman-adv/send.c\n@@ -64,8 +64,11 @@ static void batadv_send_outstanding_bcast_packet(struct work_struct *work);\n * If neigh_node is NULL, then the packet is broadcasted using hard_iface,\n * otherwise it is sent as unicast to the given neighbor.\n *\n- * Return: NET_TX_DROP in case of error or the result of dev_queue_xmit(skb)\n- * otherwise\n+ * Regardless of the return value, the skb is consumed.\n+ *\n+ * Return: A negative errno code is returned on a failure. A success does not\n+ * guarantee the frame will be transmitted as it may be dropped due\n+ * to congestion or traffic shaping.\n */\n int batadv_send_skb_packet(struct sk_buff *skb,\n \t\t\t struct batadv_hard_iface *hard_iface,\n@@ -73,7 +76,6 @@ int batadv_send_skb_packet(struct sk_buff *skb,\n {\n \tstruct batadv_priv *bat_priv;\n \tstruct ethhdr *ethhdr;\n-\tint ret;\n \n \tbat_priv = netdev_priv(hard_iface->soft_iface);\n \n@@ -111,15 +113,8 @@ int batadv_send_skb_packet(struct sk_buff *skb,\n \t/* dev_queue_xmit() returns a negative result on error.\t However on\n \t * congestion and traffic shaping, it drops and returns NET_XMIT_DROP\n \t * (which is > 0). This will not be treated as an error.\n-\t *\n-\t * a negative value cannot be returned because it could be interepreted\n-\t * as not consumed skb by callers of batadv_send_skb_to_orig.\n \t */\n-\tret = dev_queue_xmit(skb);\n-\tif (ret < 0)\n-\t\tret = NET_XMIT_DROP;\n-\n-\treturn ret;\n+\treturn dev_queue_xmit(skb);\n send_skb_err:\n \tkfree_skb(skb);\n \treturn NET_XMIT_DROP;\n", "prefixes": [ "14/17" ] }