Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/692925/?format=api
{ "id": 692925, "url": "http://patchwork.ozlabs.org/api/patches/692925/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1478717328-2168-1-git-send-email-anthony.l.nguyen@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1478717328-2168-1-git-send-email-anthony.l.nguyen@intel.com>", "list_archive_url": null, "date": "2016-11-09T18:48:48", "name": "ixgbe: Add bounds check for x540 LED functions", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "41268ab586d542b44b75917e5a0b822f923943df", "submitter": { "id": 68875, "url": "http://patchwork.ozlabs.org/api/people/68875/?format=api", "name": "Tony Nguyen", "email": "anthony.l.nguyen@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1478717328-2168-1-git-send-email-anthony.l.nguyen@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/692925/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/692925/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3tDbDv6PQFz9t25\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 10 Nov 2016 06:03:43 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id EF27A91F71;\n\tWed, 9 Nov 2016 19:03:41 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 9lKyUTafeUxp; Wed, 9 Nov 2016 19:03:40 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id A5A2891FA2;\n\tWed, 9 Nov 2016 19:03:40 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id EE1381C28DD\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 9 Nov 2016 19:03:39 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id E8C30C1D65\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 9 Nov 2016 19:03:39 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id a3JVUzG3CoJb for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 9 Nov 2016 19:03:38 +0000 (UTC)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id A6246C124E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 9 Nov 2016 19:03:38 +0000 (UTC)", "from orsmga005.jf.intel.com ([10.7.209.41])\n\tby fmsmga105.fm.intel.com with ESMTP; 09 Nov 2016 11:03:38 -0800", "from unknown (HELO anguy11-desk2.localdomain.com) ([10.166.12.51])\n\tby orsmga005.jf.intel.com with ESMTP; 09 Nov 2016 11:03:38 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.31,614,1473145200\"; d=\"scan'208\";a=\"29425304\"", "From": "Tony Nguyen <anthony.l.nguyen@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 9 Nov 2016 10:48:48 -0800", "Message-Id": "<1478717328-2168-1-git-send-email-anthony.l.nguyen@intel.com>", "X-Mailer": "git-send-email 2.4.0", "Subject": "[Intel-wired-lan] [PATCH] ixgbe: Add bounds check for x540 LED\n\tfunctions", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "This is an extension of commit 003287e0f087 (\"ixgbevf: Correct parameter\nsent to LED function\"); add bounds checking to x540 functions to ensure the\nindex is valid.\n\nSigned-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_x540.c | 9 +++++++--\n 1 file changed, 7 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_x540.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_x540.c\nindex e2ff823..afc4d16 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_x540.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_x540.c\n@@ -780,8 +780,10 @@ s32 ixgbe_blink_led_start_X540(struct ixgbe_hw *hw, u32 index)\n \tixgbe_link_speed speed;\n \tbool link_up;\n \n-\t/*\n-\t * Link should be up in order for the blink bit in the LED control\n+\tif (index > 3)\n+\t\treturn IXGBE_ERR_PARAM;\n+\n+\t/* Link should be up in order for the blink bit in the LED control\n \t * register to work. Force link and speed in the MAC if link is down.\n \t * This will be reversed when we stop the blinking.\n \t */\n@@ -814,6 +816,9 @@ s32 ixgbe_blink_led_stop_X540(struct ixgbe_hw *hw, u32 index)\n \tu32 macc_reg;\n \tu32 ledctl_reg;\n \n+\tif (index > 3)\n+\t\treturn IXGBE_ERR_PARAM;\n+\n \t/* Restore the LED to its default value. */\n \tledctl_reg = IXGBE_READ_REG(hw, IXGBE_LEDCTL);\n \tledctl_reg &= ~IXGBE_LED_MODE_MASK(index);\n", "prefixes": [] }