Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/692495/?format=api
{ "id": 692495, "url": "http://patchwork.ozlabs.org/api/patches/692495/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1478639119-14656-15-git-send-email-bimmy.pujari@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1478639119-14656-15-git-send-email-bimmy.pujari@intel.com>", "list_archive_url": null, "date": "2016-11-08T21:05:18", "name": "[next,S52-V2,14/15] i40e: Blink LED on 1G BaseT boards", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "f0f6fbdd595bfe3db50bbee44ef336497a059302", "submitter": { "id": 68919, "url": "http://patchwork.ozlabs.org/api/people/68919/?format=api", "name": "Pujari, Bimmy", "email": "bimmy.pujari@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1478639119-14656-15-git-send-email-bimmy.pujari@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/692495/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/692495/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3tD21k0RcMz9t1d\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 9 Nov 2016 08:07:06 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 7BE06C131C;\n\tTue, 8 Nov 2016 21:07:04 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id SjHbdFA0kr1J; Tue, 8 Nov 2016 21:07:03 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id A0B28C1358;\n\tTue, 8 Nov 2016 21:07:02 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 387671C22F9\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 8 Nov 2016 21:06:59 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 366262E50D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 8 Nov 2016 21:06:59 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id bMmfplrhY1Ib for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 8 Nov 2016 21:06:57 +0000 (UTC)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby silver.osuosl.org (Postfix) with ESMTPS id A591D31C75\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 8 Nov 2016 21:06:55 +0000 (UTC)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga105.fm.intel.com with ESMTP; 08 Nov 2016 13:06:55 -0800", "from bimmy.jf.intel.com (HELO bimmy.linux1.jf.intel.com)\n\t([134.134.2.167])\n\tby fmsmga002.fm.intel.com with ESMTP; 08 Nov 2016 13:06:54 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.31,611,1473145200\"; d=\"scan'208\";\n\ta=\"1082486444\"", "From": "Bimmy Pujari <bimmy.pujari@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 8 Nov 2016 13:05:18 -0800", "Message-Id": "<1478639119-14656-15-git-send-email-bimmy.pujari@intel.com>", "X-Mailer": "git-send-email 2.4.11", "In-Reply-To": "<1478639119-14656-1-git-send-email-bimmy.pujari@intel.com>", "References": "<1478639119-14656-1-git-send-email-bimmy.pujari@intel.com>", "Cc": "Henry Tieman <henry.w.tieman@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S52-V2 14/15] i40e: Blink LED on 1G\n\tBaseT boards", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Henry Tieman <henry.w.tieman@intel.com>\n\nBefore this patch \"ethtool -p\" was not blinking the LEDs on boards\nwith 1G BaseT PHYs.\n\nThis commit identifies 1G BaseT boards as having the LEDs connected\nto the MAC. Also, renamed the flag to be more descriptive of usage.\nThe flag is now I40E_FLAG_PHY_CONTROLS_LEDS.\n\nSigned-off-by: Harshitha Ramamurthy <harshitha.ramamurthy@intel.com>\nSigned-off-by: Henry Tieman <henry.w.tieman@intel.com>\nChange-ID: I4eb741da9780da7849ddf2dc4c0cb27ffa42a801\n---\n drivers/net/ethernet/intel/i40e/i40e.h | 2 +-\n drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 10 +++++-----\n drivers/net/ethernet/intel/i40e/i40e_main.c | 4 ++--\n 3 files changed, 8 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e.h b/drivers/net/ethernet/intel/i40e/i40e.h\nindex 06e3c23..b8f2978 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e.h\n+++ b/drivers/net/ethernet/intel/i40e/i40e.h\n@@ -356,7 +356,7 @@ struct i40e_pf {\n #define I40E_FLAG_NO_DCB_SUPPORT\t\tBIT_ULL(45)\n #define I40E_FLAG_USE_SET_LLDP_MIB\t\tBIT_ULL(46)\n #define I40E_FLAG_STOP_FW_LLDP\t\t\tBIT_ULL(47)\n-#define I40E_FLAG_HAVE_10GBASET_PHY\t\tBIT_ULL(48)\n+#define I40E_FLAG_PHY_CONTROLS_LEDS\t\tBIT_ULL(48)\n #define I40E_FLAG_PF_MAC\t\t\tBIT_ULL(50)\n #define I40E_FLAG_TRUE_PROMISC_SUPPORT\t\tBIT_ULL(51)\n #define I40E_FLAG_HAVE_CRT_RETIMER\t\tBIT_ULL(52)\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\nindex 76753e1..6ba0035 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n@@ -1890,7 +1890,7 @@ static int i40e_set_phys_id(struct net_device *netdev,\n \n \tswitch (state) {\n \tcase ETHTOOL_ID_ACTIVE:\n-\t\tif (!(pf->flags & I40E_FLAG_HAVE_10GBASET_PHY)) {\n+\t\tif (!(pf->flags & I40E_FLAG_PHY_CONTROLS_LEDS)) {\n \t\t\tpf->led_status = i40e_led_get(hw);\n \t\t} else {\n \t\t\ti40e_aq_set_phy_debug(hw, I40E_PHY_DEBUG_ALL, NULL);\n@@ -1900,20 +1900,20 @@ static int i40e_set_phys_id(struct net_device *netdev,\n \t\t}\n \t\treturn blink_freq;\n \tcase ETHTOOL_ID_ON:\n-\t\tif (!(pf->flags & I40E_FLAG_HAVE_10GBASET_PHY))\n+\t\tif (!(pf->flags & I40E_FLAG_PHY_CONTROLS_LEDS))\n \t\t\ti40e_led_set(hw, 0xf, false);\n \t\telse\n \t\t\tret = i40e_led_set_phy(hw, true, pf->led_status, 0);\n \t\tbreak;\n \tcase ETHTOOL_ID_OFF:\n-\t\tif (!(pf->flags & I40E_FLAG_HAVE_10GBASET_PHY))\n+\t\tif (!(pf->flags & I40E_FLAG_PHY_CONTROLS_LEDS))\n \t\t\ti40e_led_set(hw, 0x0, false);\n \t\telse\n \t\t\tret = i40e_led_set_phy(hw, false, pf->led_status, 0);\n \t\tbreak;\n \tcase ETHTOOL_ID_INACTIVE:\n-\t\tif (!(pf->flags & I40E_FLAG_HAVE_10GBASET_PHY)) {\n-\t\t\ti40e_led_set(hw, false, pf->led_status);\n+\t\tif (!(pf->flags & I40E_FLAG_PHY_CONTROLS_LEDS)) {\n+\t\t\ti40e_led_set(hw, pf->led_status, false);\n \t\t} else {\n \t\t\tret = i40e_led_set_phy(hw, false, pf->led_status,\n \t\t\t\t\t (pf->phy_led_val |\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex eddb14c..8443e8c 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -11368,8 +11368,8 @@ static int i40e_probe(struct pci_dev *pdev, const struct pci_device_id *ent)\n \t\t\t\t\t\t pf->main_vsi_seid);\n \n \tif ((pf->hw.device_id == I40E_DEV_ID_10G_BASE_T) ||\n-\t (pf->hw.device_id == I40E_DEV_ID_10G_BASE_T4))\n-\t\tpf->flags |= I40E_FLAG_HAVE_10GBASET_PHY;\n+\t\t(pf->hw.device_id == I40E_DEV_ID_10G_BASE_T4))\n+\t\tpf->flags |= I40E_FLAG_PHY_CONTROLS_LEDS;\n \tif (pf->hw.device_id == I40E_DEV_ID_SFP_I_X722)\n \t\tpf->flags |= I40E_FLAG_HAVE_CRT_RETIMER;\n \t/* print a string summarizing features */\n", "prefixes": [ "next", "S52-V2", "14/15" ] }