Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/692494/?format=api
{ "id": 692494, "url": "http://patchwork.ozlabs.org/api/patches/692494/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1478639119-14656-6-git-send-email-bimmy.pujari@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1478639119-14656-6-git-send-email-bimmy.pujari@intel.com>", "list_archive_url": null, "date": "2016-11-08T21:05:09", "name": "[next,S52-V2,05/15] i40e: Fix for ethtool Supported link modes", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "eb443716ce01a337be0f3e33bcd8ef724acebd3e", "submitter": { "id": 68919, "url": "http://patchwork.ozlabs.org/api/people/68919/?format=api", "name": "Pujari, Bimmy", "email": "bimmy.pujari@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1478639119-14656-6-git-send-email-bimmy.pujari@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/692494/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/692494/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3tD21j1d94z9t1d\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 9 Nov 2016 08:07:05 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 975E5C13EA;\n\tTue, 8 Nov 2016 21:07:03 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id l60fgAjqtOwK; Tue, 8 Nov 2016 21:07:02 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 6EAD6C134D;\n\tTue, 8 Nov 2016 21:07:02 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 0527C1C22F9\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 8 Nov 2016 21:06:59 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id F0FBC2E50D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 8 Nov 2016 21:06:58 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Asr6KnmV5qZ7 for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 8 Nov 2016 21:06:54 +0000 (UTC)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 5C96430BB9\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 8 Nov 2016 21:06:54 +0000 (UTC)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga105.fm.intel.com with ESMTP; 08 Nov 2016 13:06:54 -0800", "from bimmy.jf.intel.com (HELO bimmy.linux1.jf.intel.com)\n\t([134.134.2.167])\n\tby fmsmga002.fm.intel.com with ESMTP; 08 Nov 2016 13:06:53 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.31,611,1473145200\"; d=\"scan'208\";\n\ta=\"1082486388\"", "From": "Bimmy Pujari <bimmy.pujari@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 8 Nov 2016 13:05:09 -0800", "Message-Id": "<1478639119-14656-6-git-send-email-bimmy.pujari@intel.com>", "X-Mailer": "git-send-email 2.4.11", "In-Reply-To": "<1478639119-14656-1-git-send-email-bimmy.pujari@intel.com>", "References": "<1478639119-14656-1-git-send-email-bimmy.pujari@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S52-V2 05/15] i40e: Fix for ethtool\n\tSupported link modes", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Harshitha Ramamurthy <harshitha.ramamurthy@intel.com>\n\nThis patch fixes the problem where the ethtool Supported link\nmodes list backplane interfaces on X722 devices for 10GbE with\nSFP+ and Cortina retimer. This patch fixes the problem by setting\nand using a flag for this particular device since the backplane\ninterface is only between the internal PHY and the retimer and it\nshould not be seen by the user as they cannont use it.\nWithout this patch, the user wrongly thinks that backplane interfaces\nare supported on their device when they actually are not.\n\nSigned-off-by: Harshitha Ramamurthy <harshitha.ramamurthy@intel.com>\nChange-ID: I3882bc2928431d48a2db03a51a713a1f681a79e9\n---\n drivers/net/ethernet/intel/i40e/i40e.h | 1 +\n drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 16 ++++++++++------\n drivers/net/ethernet/intel/i40e/i40e_main.c | 3 ++-\n 3 files changed, 13 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e.h b/drivers/net/ethernet/intel/i40e/i40e.h\nindex 29c2318..4cb8fb3 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e.h\n+++ b/drivers/net/ethernet/intel/i40e/i40e.h\n@@ -359,6 +359,7 @@ struct i40e_pf {\n #define I40E_FLAG_HAVE_10GBASET_PHY\t\tBIT_ULL(48)\n #define I40E_FLAG_PF_MAC\t\t\tBIT_ULL(50)\n #define I40E_FLAG_TRUE_PROMISC_SUPPORT\t\tBIT_ULL(51)\n+#define I40E_FLAG_HAVE_CRT_RETIMER\t\tBIT_ULL(52)\n \n \t/* tracks features that get auto disabled by errors */\n \tu64 auto_disable_flags;\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\nindex 92a2f03..9500e7b 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n@@ -345,11 +345,13 @@ static void i40e_phy_type_to_ethtool(struct i40e_pf *pf, u32 *supported,\n \t\t\t*advertising |= ADVERTISED_20000baseKR2_Full;\n \t}\n \tif (phy_types & I40E_CAP_PHY_TYPE_10GBASE_KR) {\n-\t\t*supported |= SUPPORTED_10000baseKR_Full |\n-\t\t\t SUPPORTED_Autoneg;\n+\t\tif (!(pf->flags & I40E_FLAG_HAVE_CRT_RETIMER))\n+\t\t\t*supported |= SUPPORTED_10000baseKR_Full |\n+\t\t\t\t SUPPORTED_Autoneg;\n \t\t*advertising |= ADVERTISED_Autoneg;\n \t\tif (hw_link_info->requested_speeds & I40E_LINK_SPEED_10GB)\n-\t\t\t*advertising |= ADVERTISED_10000baseKR_Full;\n+\t\t\tif (!(pf->flags & I40E_FLAG_HAVE_CRT_RETIMER))\n+\t\t\t\t*advertising |= ADVERTISED_10000baseKR_Full;\n \t}\n \tif (phy_types & I40E_CAP_PHY_TYPE_10GBASE_KX4) {\n \t\t*supported |= SUPPORTED_10000baseKX4_Full |\n@@ -359,11 +361,13 @@ static void i40e_phy_type_to_ethtool(struct i40e_pf *pf, u32 *supported,\n \t\t\t*advertising |= ADVERTISED_10000baseKX4_Full;\n \t}\n \tif (phy_types & I40E_CAP_PHY_TYPE_1000BASE_KX) {\n-\t\t*supported |= SUPPORTED_1000baseKX_Full |\n-\t\t\t SUPPORTED_Autoneg;\n+\t\tif (!(pf->flags & I40E_FLAG_HAVE_CRT_RETIMER))\n+\t\t\t*supported |= SUPPORTED_1000baseKX_Full |\n+\t\t\t\t SUPPORTED_Autoneg;\n \t\t*advertising |= ADVERTISED_Autoneg;\n \t\tif (hw_link_info->requested_speeds & I40E_LINK_SPEED_1GB)\n-\t\t\t*advertising |= ADVERTISED_1000baseKX_Full;\n+\t\t\tif (!(pf->flags & I40E_FLAG_HAVE_CRT_RETIMER))\n+\t\t\t\t*advertising |= ADVERTISED_1000baseKX_Full;\n \t}\n }\n \ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex bae168c..3886119 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -11290,7 +11290,8 @@ static int i40e_probe(struct pci_dev *pdev, const struct pci_device_id *ent)\n \tif ((pf->hw.device_id == I40E_DEV_ID_10G_BASE_T) ||\n \t (pf->hw.device_id == I40E_DEV_ID_10G_BASE_T4))\n \t\tpf->flags |= I40E_FLAG_HAVE_10GBASET_PHY;\n-\n+\tif (pf->hw.device_id == I40E_DEV_ID_SFP_I_X722)\n+\t\tpf->flags |= I40E_FLAG_HAVE_CRT_RETIMER;\n \t/* print a string summarizing features */\n \ti40e_print_features(pf);\n \n", "prefixes": [ "next", "S52-V2", "05/15" ] }