Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/692441/?format=api
{ "id": 692441, "url": "http://patchwork.ozlabs.org/api/patches/692441/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20161108194733.29155.16082.stgit@localhost6.localdomain6/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20161108194733.29155.16082.stgit@localhost6.localdomain6>", "list_archive_url": null, "date": "2016-11-08T19:47:33", "name": "[v2] ixgbe: handle close/suspend race with netif_device_detach/present", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "e6bbabbe5a002391f23d05cc5170057a2e414abc", "submitter": { "id": 1670, "url": "http://patchwork.ozlabs.org/api/people/1670/?format=api", "name": "Tantilov, Emil S", "email": "emil.s.tantilov@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20161108194733.29155.16082.stgit@localhost6.localdomain6/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/692441/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/692441/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3tD0P63lgnz9t1d\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 9 Nov 2016 06:53:46 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 82C5F8CF86;\n\tTue, 8 Nov 2016 19:53:44 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id BbgfijRTNzBc; Tue, 8 Nov 2016 19:53:43 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id AE8158CE06;\n\tTue, 8 Nov 2016 19:53:43 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id A51D71C2CC6\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 8 Nov 2016 19:53:42 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 9F5B58CE06\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 8 Nov 2016 19:53:42 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id J9w3bmFIjzc8 for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 8 Nov 2016 19:53:41 +0000 (UTC)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id DB8BB8CA6D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 8 Nov 2016 19:53:41 +0000 (UTC)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby orsmga101.jf.intel.com with ESMTP; 08 Nov 2016 11:53:41 -0800", "from estantil-desk3.jf.intel.com (HELO localhost6.localdomain6)\n\t([134.134.3.186])\n\tby fmsmga001.fm.intel.com with ESMTP; 08 Nov 2016 11:53:41 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.31,611,1473145200\"; d=\"scan'208\";\n\ta=\"1065771785\"", "From": "Emil Tantilov <emil.s.tantilov@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 08 Nov 2016 11:47:33 -0800", "Message-ID": "<20161108194733.29155.16082.stgit@localhost6.localdomain6>", "User-Agent": "StGit/0.17.1-17-ge4e0", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH v2] ixgbe: handle close/suspend race with\n\tnetif_device_detach/present", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "When an interface is part of a namespace it is possible that\nixgbe_close() may be called while __ixgbe_shutdown() is running\nwhich ends up in a double free WARN and/or a BUG in free_msi_irqs().\n\nTo handle this situation we extend the rtnl_lock() to protect the\ncall to netif_device_detach() and ixgbe_clear_interrupt_scheme()\nin __ixgbe_shutdown() and check for netif_device_present()\nto avoid clearing the interrupts second time in ixgbe_close() and\nixgbe_remove().\n\nAlso extend the rtnl lock in ixgbe_resume() to netif_device_attach().\n\nv2 - add rtnl locks and a check in ixgbe_remove()\n\nSigned-off-by: Emil Tantilov <emil.s.tantilov@intel.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 22 ++++++++++++----------\n 1 file changed, 12 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex 51cdac9..0b1fa5d 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -6200,7 +6200,8 @@ int ixgbe_close(struct net_device *netdev)\n \n \tixgbe_ptp_stop(adapter);\n \n-\tixgbe_close_suspend(adapter);\n+\tif (netif_device_present(netdev))\n+\t\tixgbe_close_suspend(adapter);\n \n \tixgbe_fdir_filter_exit(adapter);\n \n@@ -6245,14 +6246,12 @@ static int ixgbe_resume(struct pci_dev *pdev)\n \tif (!err && netif_running(netdev))\n \t\terr = ixgbe_open(netdev);\n \n-\trtnl_unlock();\n-\n-\tif (err)\n-\t\treturn err;\n \n-\tnetif_device_attach(netdev);\n+\tif (!err)\n+\t\tnetif_device_attach(netdev);\n+\trtnl_unlock();\n \n-\treturn 0;\n+\treturn err;\n }\n #endif /* CONFIG_PM */\n \n@@ -6267,14 +6266,14 @@ static int __ixgbe_shutdown(struct pci_dev *pdev, bool *enable_wake)\n \tint retval = 0;\n #endif\n \n+\trtnl_lock();\n \tnetif_device_detach(netdev);\n \n-\trtnl_lock();\n \tif (netif_running(netdev))\n \t\tixgbe_close_suspend(adapter);\n-\trtnl_unlock();\n \n \tixgbe_clear_interrupt_scheme(adapter);\n+\trtnl_unlock();\n \n #ifdef CONFIG_PM\n \tretval = pci_save_state(pdev);\n@@ -9923,7 +9922,10 @@ static void ixgbe_remove(struct pci_dev *pdev)\n \tif (netdev->reg_state == NETREG_REGISTERED)\n \t\tunregister_netdev(netdev);\n \n-\tixgbe_clear_interrupt_scheme(adapter);\n+\trtnl_lock();\n+\tif (netif_device_present(netdev))\n+\t\tixgbe_clear_interrupt_scheme(adapter);\n+\trtnl_unlock();\n \n \tixgbe_release_hw_control(adapter);\n \n", "prefixes": [ "v2" ] }