Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/692171/?format=api
{ "id": 692171, "url": "http://patchwork.ozlabs.org/api/patches/692171/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1478588780-24480-1-git-send-email-caoj.fnst@cn.fujitsu.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1478588780-24480-1-git-send-email-caoj.fnst@cn.fujitsu.com>", "list_archive_url": null, "date": "2016-11-08T07:06:20", "name": "igb: use igb_adapter->io_addr instead of e1000_hw->hw_addr", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "4b1bc954d03571012dfb99c6505e9cdb2baeaf14", "submitter": { "id": 67224, "url": "http://patchwork.ozlabs.org/api/people/67224/?format=api", "name": "Cao jin", "email": "caoj.fnst@cn.fujitsu.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1478588780-24480-1-git-send-email-caoj.fnst@cn.fujitsu.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/692171/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/692171/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3tCgJn3WQ7z9vFY\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 8 Nov 2016 18:03:53 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id C44848BEB7;\n\tTue, 8 Nov 2016 07:03:51 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 6iOvEMkCaHIH; Tue, 8 Nov 2016 07:03:49 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id E56FA8BE86;\n\tTue, 8 Nov 2016 07:03:48 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 74C5E1CEAEC\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 8 Nov 2016 07:03:47 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 6D1398AF2E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 8 Nov 2016 07:03:47 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 8D5OjklUf0-w for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 8 Nov 2016 07:03:46 +0000 (UTC)", "from heian.cn.fujitsu.com (unknown [59.151.112.132])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 662D38AF26\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 8 Nov 2016 07:03:46 +0000 (UTC)", "from unknown (HELO cn.fujitsu.com) ([10.167.33.5])\n\tby heian.cn.fujitsu.com with ESMTP; 08 Nov 2016 15:03:41 +0800", "from G08CNEXCHPEKD03.g08.fujitsu.local (unknown [10.167.33.85])\n\tby cn.fujitsu.com (Postfix) with ESMTP id 8277E47A867D;\n\tTue, 8 Nov 2016 15:03:40 +0800 (CST)", "from G08FNSTD140223.g08.fujitsu.local (10.167.226.69) by\n\tG08CNEXCHPEKD03.g08.fujitsu.local (10.167.33.89) with Microsoft SMTP\n\tServer (TLS) id 14.3.279.2; Tue, 8 Nov 2016 15:03:39 +0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "from auto-whitelisted by SQLgrey-1.7.6", "X-IronPort-AV": "E=Sophos;i=\"5.22,518,1449504000\"; d=\"scan'208\";a=\"12770446\"", "From": "Cao jin <caoj.fnst@cn.fujitsu.com>", "To": "<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>", "Date": "Tue, 8 Nov 2016 15:06:20 +0800", "Message-ID": "<1478588780-24480-1-git-send-email-caoj.fnst@cn.fujitsu.com>", "X-Mailer": "git-send-email 2.1.0", "MIME-Version": "1.0", "X-Originating-IP": "[10.167.226.69]", "X-yoursite-MailScanner-ID": "8277E47A867D.ABA51", "X-yoursite-MailScanner": "Found to be clean", "X-yoursite-MailScanner-From": "caoj.fnst@cn.fujitsu.com", "Cc": "izumi.taku@jp.fujitsu.com, intel-wired-lan@lists.osuosl.org", "Subject": "[Intel-wired-lan] [PATCH] igb: use igb_adapter->io_addr instead of\n\te1000_hw->hw_addr", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "When running as guest, under certain condition, it will oops as following.\nwritel() in igb_configure_tx_ring() results in oops, because hw->hw_addr\nis NULL. While other register access won't oops kernel because they use\nwr32/rd32 which have a defense against NULL pointer.\n\n [ 141.225449] pcieport 0000:00:1c.0: AER: Multiple Uncorrected (Fatal)\n error received: id=0101\n [ 141.225523] igb 0000:01:00.1: PCIe Bus Error:\n severity=Uncorrected (Fatal), type=Unaccessible,\n id=0101(Unregistered Agent ID)\n [ 141.299442] igb 0000:01:00.1: broadcast error_detected message\n [ 141.300539] igb 0000:01:00.0 enp1s0f0: PCIe link lost, device now\n detached\n [ 141.351019] igb 0000:01:00.1 enp1s0f1: PCIe link lost, device now\n detached\n [ 143.465904] pcieport 0000:00:1c.0: Root Port link has been reset\n [ 143.465994] igb 0000:01:00.1: broadcast slot_reset message\n [ 143.466039] igb 0000:01:00.0: enabling device (0000 -> 0002)\n [ 144.389078] igb 0000:01:00.1: enabling device (0000 -> 0002)\n [ 145.312078] igb 0000:01:00.1: broadcast resume message\n [ 145.322211] BUG: unable to handle kernel paging request at\n 0000000000003818\n [ 145.361275] IP: [<ffffffffa02fd38d>]\n igb_configure_tx_ring+0x14d/0x280 [igb]\n [ 145.400048] PGD 0\n [ 145.438007] Oops: 0002 [#1] SMP\n\nA similiar issue & solution could be found at:\n http://patchwork.ozlabs.org/patch/689592/\n\nSigned-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>\n---\n drivers/net/ethernet/intel/igb/igb_main.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c\nindex edc9a6a..3f240ac 100644\n--- a/drivers/net/ethernet/intel/igb/igb_main.c\n+++ b/drivers/net/ethernet/intel/igb/igb_main.c\n@@ -3390,7 +3390,7 @@ void igb_configure_tx_ring(struct igb_adapter *adapter,\n \t tdba & 0x00000000ffffffffULL);\n \twr32(E1000_TDBAH(reg_idx), tdba >> 32);\n \n-\tring->tail = hw->hw_addr + E1000_TDT(reg_idx);\n+\tring->tail = adapter->io_addr + E1000_TDT(reg_idx);\n \twr32(E1000_TDH(reg_idx), 0);\n \twritel(0, ring->tail);\n \n@@ -3729,7 +3729,7 @@ void igb_configure_rx_ring(struct igb_adapter *adapter,\n \t ring->count * sizeof(union e1000_adv_rx_desc));\n \n \t/* initialize head and tail */\n-\tring->tail = hw->hw_addr + E1000_RDT(reg_idx);\n+\tring->tail = adapter->io_addr + E1000_RDT(reg_idx);\n \twr32(E1000_RDH(reg_idx), 0);\n \twritel(0, ring->tail);\n \n", "prefixes": [] }