Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/691359/?format=api
{ "id": 691359, "url": "http://patchwork.ozlabs.org/api/patches/691359/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1478280968-8098-3-git-send-email-bimmy.pujari@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1478280968-8098-3-git-send-email-bimmy.pujari@intel.com>", "list_archive_url": null, "date": "2016-11-04T17:35:59", "name": "[next,S52,02/11] i40e: Remove unreachable code", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "4b5d8af5b298e5351b9cc2688ab13ed050c1062e", "submitter": { "id": 68919, "url": "http://patchwork.ozlabs.org/api/people/68919/?format=api", "name": "Pujari, Bimmy", "email": "bimmy.pujari@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1478280968-8098-3-git-send-email-bimmy.pujari@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/691359/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/691359/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3t9TZ53zlQz9vG9\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 5 Nov 2016 04:37:49 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id ECB44961DC;\n\tFri, 4 Nov 2016 17:37:47 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id XZLtxvrHDXkg; Fri, 4 Nov 2016 17:37:47 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id AF7E196330;\n\tFri, 4 Nov 2016 17:37:46 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 1B89F1C2774\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 4 Nov 2016 17:37:45 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 14CF126D38\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 4 Nov 2016 17:37:45 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id jc1wpfdMUMG7 for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 4 Nov 2016 17:37:43 +0000 (UTC)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 96E372A0B0\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 4 Nov 2016 17:37:43 +0000 (UTC)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga104.fm.intel.com with ESMTP; 04 Nov 2016 10:37:42 -0700", "from bimmy.jf.intel.com (HELO bimmy.linux1.jf.intel.com)\n\t([134.134.2.167])\n\tby fmsmga002.fm.intel.com with ESMTP; 04 Nov 2016 10:37:41 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.31,444,1473145200\"; d=\"scan'208\";\n\ta=\"1080727980\"", "From": "Bimmy Pujari <bimmy.pujari@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 4 Nov 2016 10:35:59 -0700", "Message-Id": "<1478280968-8098-3-git-send-email-bimmy.pujari@intel.com>", "X-Mailer": "git-send-email 2.4.11", "In-Reply-To": "<1478280968-8098-1-git-send-email-bimmy.pujari@intel.com>", "References": "<1478280968-8098-1-git-send-email-bimmy.pujari@intel.com>", "Cc": "Henry Tieman <henry.w.tieman@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S52 02/11] i40e: Remove unreachable\n\tcode", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Henry Tieman <henry.w.tieman@intel.com>\n\nThe code at the end of i40e_read_phy_register_clause22() contained\nunreachable code and redundant control statements.\n\nThis change removes the unreachable code. And deletes the redundant\ngoto statement and if statement.\n\nSigned-off-by: Henry Tieman <henry.w.tieman@intel.com>\nChange-ID: I713032b1585396f40f903cbcfdea987abd874400\n---\nTesting Hints:\n Found by static analysis. Test by code inspection.\n\n drivers/net/ethernet/intel/i40e/i40e_common.c | 9 +--------\n 1 file changed, 1 insertion(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_common.c b/drivers/net/ethernet/intel/i40e/i40e_common.c\nindex 4672bf1..b0358c0 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_common.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_common.c\n@@ -4439,19 +4439,12 @@ i40e_status i40e_read_phy_register_clause22(struct i40e_hw *hw, u16 reg,\n \tif (status) {\n \t\ti40e_debug(hw, I40E_DEBUG_PHY,\n \t\t\t \"PHY: Can't write command to external PHY.\\n\");\n-\t\tgoto phy_read_end;\n-\t}\n-\n-\tif (!status) {\n+\t} else {\n \t\tcommand = rd32(hw, I40E_GLGEN_MSRWD(port_num));\n \t\t*value = (command & I40E_GLGEN_MSRWD_MDIRDDATA_MASK) >>\n \t\t\t I40E_GLGEN_MSRWD_MDIRDDATA_SHIFT;\n-\t} else {\n-\t\ti40e_debug(hw, I40E_DEBUG_PHY,\n-\t\t\t \"PHY: Can't read register value from external PHY.\\n\");\n \t}\n \n-phy_read_end:\n \treturn status;\n }\n \n", "prefixes": [ "next", "S52", "02/11" ] }