Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/690622/?format=api
{ "id": 690622, "url": "http://patchwork.ozlabs.org/api/patches/690622/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20161102234447.17181-2-jacob.e.keller@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20161102234447.17181-2-jacob.e.keller@intel.com>", "list_archive_url": null, "date": "2016-11-02T23:44:45", "name": "[2/4] fm10k: remove extraneous variable definition in fm10k_ethtool.c", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "cbf65ff5be96821a434835da3617e9b1c0193abf", "submitter": { "id": 9784, "url": "http://patchwork.ozlabs.org/api/people/9784/?format=api", "name": "Jacob Keller", "email": "jacob.e.keller@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20161102234447.17181-2-jacob.e.keller@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/690622/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/690622/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3t8Ppd1mjBz9tlB\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 3 Nov 2016 10:44:57 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 98BE83224A;\n\tWed, 2 Nov 2016 23:44:55 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id w7ReJzy1WGWi; Wed, 2 Nov 2016 23:44:53 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id C19A72A205;\n\tWed, 2 Nov 2016 23:44:53 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id C37C21C2BF0\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 2 Nov 2016 23:44:51 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id BF53A956E4\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 2 Nov 2016 23:44:51 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id TgpFQZGsAqPA for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 2 Nov 2016 23:44:51 +0000 (UTC)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 2E76D956D3\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 2 Nov 2016 23:44:51 +0000 (UTC)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby orsmga102.jf.intel.com with ESMTP; 02 Nov 2016 16:44:50 -0700", "from jekeller-desk.amr.corp.intel.com (HELO\n\tjekeller-desk.jekeller.internal) ([134.134.3.116])\n\tby fmsmga002.fm.intel.com with ESMTP; 02 Nov 2016 16:44:50 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.31,436,1473145200\"; d=\"scan'208\";\n\ta=\"1079796765\"", "From": "Jacob Keller <jacob.e.keller@intel.com>", "To": "Intel Wired LAN <intel-wired-lan@lists.osuosl.org>", "Date": "Wed, 2 Nov 2016 16:44:45 -0700", "Message-Id": "<20161102234447.17181-2-jacob.e.keller@intel.com>", "X-Mailer": "git-send-email 2.10.1.777.gd068e6b", "In-Reply-To": "<20161102234447.17181-1-jacob.e.keller@intel.com>", "References": "<20161102234447.17181-1-jacob.e.keller@intel.com>", "Subject": "[Intel-wired-lan] [PATCH 2/4] fm10k: remove extraneous variable\n\tdefinition in fm10k_ethtool.c", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "We don't need to typecast a u8 * into a char *, so just remove the extra\nvariable.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c | 21 +++++++++------------\n 1 file changed, 9 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c b/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c\nindex 5241e0873397..0c84fef750f4 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c\n@@ -148,7 +148,7 @@ enum {\n static const char fm10k_prv_flags[FM10K_PRV_FLAG_LEN][ETH_GSTRING_LEN] = {\n };\n \n-static void fm10k_add_stat_strings(char **p, const char *prefix,\n+static void fm10k_add_stat_strings(u8 **p, const char *prefix,\n \t\t\t\t const struct fm10k_stats stats[],\n \t\t\t\t const unsigned int size)\n {\n@@ -164,32 +164,31 @@ static void fm10k_add_stat_strings(char **p, const char *prefix,\n static void fm10k_get_stat_strings(struct net_device *dev, u8 *data)\n {\n \tstruct fm10k_intfc *interface = netdev_priv(dev);\n-\tchar *p = (char *)data;\n \tunsigned int i;\n \n-\tfm10k_add_stat_strings(&p, \"\", fm10k_gstrings_net_stats,\n+\tfm10k_add_stat_strings(&data, \"\", fm10k_gstrings_net_stats,\n \t\t\t FM10K_NETDEV_STATS_LEN);\n \n-\tfm10k_add_stat_strings(&p, \"\", fm10k_gstrings_global_stats,\n+\tfm10k_add_stat_strings(&data, \"\", fm10k_gstrings_global_stats,\n \t\t\t FM10K_GLOBAL_STATS_LEN);\n \n-\tfm10k_add_stat_strings(&p, \"\", fm10k_gstrings_mbx_stats,\n+\tfm10k_add_stat_strings(&data, \"\", fm10k_gstrings_mbx_stats,\n \t\t\t FM10K_MBX_STATS_LEN);\n \n \tif (interface->hw.mac.type != fm10k_mac_vf)\n-\t\tfm10k_add_stat_strings(&p, \"\", fm10k_gstrings_pf_stats,\n+\t\tfm10k_add_stat_strings(&data, \"\", fm10k_gstrings_pf_stats,\n \t\t\t\t FM10K_PF_STATS_LEN);\n \n \tfor (i = 0; i < interface->hw.mac.max_queues; i++) {\n \t\tchar prefix[ETH_GSTRING_LEN];\n \n \t\tsnprintf(prefix, ETH_GSTRING_LEN, \"tx_queue_%u_\", i);\n-\t\tfm10k_add_stat_strings(&p, prefix,\n+\t\tfm10k_add_stat_strings(&data, prefix,\n \t\t\t\t fm10k_gstrings_queue_stats,\n \t\t\t\t FM10K_QUEUE_STATS_LEN);\n \n \t\tsnprintf(prefix, ETH_GSTRING_LEN, \"rx_queue_%u_\", i);\n-\t\tfm10k_add_stat_strings(&p, prefix,\n+\t\tfm10k_add_stat_strings(&data, prefix,\n \t\t\t\t fm10k_gstrings_queue_stats,\n \t\t\t\t FM10K_QUEUE_STATS_LEN);\n \t}\n@@ -198,18 +197,16 @@ static void fm10k_get_stat_strings(struct net_device *dev, u8 *data)\n static void fm10k_get_strings(struct net_device *dev,\n \t\t\t u32 stringset, u8 *data)\n {\n-\tchar *p = (char *)data;\n-\n \tswitch (stringset) {\n \tcase ETH_SS_TEST:\n-\t\tmemcpy(data, *fm10k_gstrings_test,\n+\t\tmemcpy(data, fm10k_gstrings_test,\n \t\t FM10K_TEST_LEN * ETH_GSTRING_LEN);\n \t\tbreak;\n \tcase ETH_SS_STATS:\n \t\tfm10k_get_stat_strings(dev, data);\n \t\tbreak;\n \tcase ETH_SS_PRIV_FLAGS:\n-\t\tmemcpy(p, fm10k_prv_flags,\n+\t\tmemcpy(data, fm10k_prv_flags,\n \t\t FM10K_PRV_FLAG_LEN * ETH_GSTRING_LEN);\n \t\tbreak;\n \t}\n", "prefixes": [ "2/4" ] }