Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/689595/?format=api
{ "id": 689595, "url": "http://patchwork.ozlabs.org/api/patches/689595/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1477941118-17973-1-git-send-email-anthony.l.nguyen@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1477941118-17973-1-git-send-email-anthony.l.nguyen@intel.com>", "list_archive_url": null, "date": "2016-10-31T19:11:58", "name": "ixgbe: Fix check for ixgbe_phy_x550em_ext_t reset", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "eb6198a67401589b2108ac86917645abc64e3f7b", "submitter": { "id": 68875, "url": "http://patchwork.ozlabs.org/api/people/68875/?format=api", "name": "Tony Nguyen", "email": "anthony.l.nguyen@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1477941118-17973-1-git-send-email-anthony.l.nguyen@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/689595/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/689595/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3t75Vt2VTwz9t15\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 1 Nov 2016 07:26:46 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id B686A8AD53;\n\tMon, 31 Oct 2016 20:26:44 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id lwiOEoTMNDFr; Mon, 31 Oct 2016 20:26:43 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id B8BDF8A75E;\n\tMon, 31 Oct 2016 20:26:43 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id C33F81CE773\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 31 Oct 2016 20:26:42 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id BE1DA87E56\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 31 Oct 2016 20:26:42 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id lXMmbP3iAXDI for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 31 Oct 2016 20:26:41 +0000 (UTC)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id E2129882D7\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 31 Oct 2016 20:26:40 +0000 (UTC)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga103.fm.intel.com with ESMTP; 31 Oct 2016 13:26:40 -0700", "from unknown (HELO anguy11-desk2.localdomain.com) ([10.166.12.155])\n\tby fmsmga001.fm.intel.com with ESMTP; 31 Oct 2016 13:26:40 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.31,428,1473145200\"; d=\"scan'208\";\n\ta=\"1061981975\"", "From": "Tony Nguyen <anthony.l.nguyen@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Mon, 31 Oct 2016 12:11:58 -0700", "Message-Id": "<1477941118-17973-1-git-send-email-anthony.l.nguyen@intel.com>", "X-Mailer": "git-send-email 2.4.0", "Subject": "[Intel-wired-lan] [PATCH] ixgbe: Fix check for\n\tixgbe_phy_x550em_ext_t reset", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "The generic PHY reset check we had previously is not sufficient for the\nixgbe_phy_x550em_ext_t PHY type. Check 1.CC02.0 instead - same as\nixgbe_init_ext_t_x550().\n\nSigned-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c | 25 +++++++++++++++++++++----\n 1 file changed, 21 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c\nindex e27798d9..b1711ff 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c\n@@ -451,10 +451,27 @@ s32 ixgbe_reset_phy_generic(struct ixgbe_hw *hw)\n \t */\n \tfor (i = 0; i < 30; i++) {\n \t\tmsleep(100);\n-\t\thw->phy.ops.read_reg(hw, MDIO_CTRL1, MDIO_MMD_PHYXS, &ctrl);\n-\t\tif (!(ctrl & MDIO_CTRL1_RESET)) {\n-\t\t\tudelay(2);\n-\t\t\tbreak;\n+\t\tif (hw->phy.type == ixgbe_phy_x550em_ext_t) {\n+\t\t\tstatus = hw->phy.ops.read_reg(hw,\n+\t\t\t\t\t\t IXGBE_MDIO_TX_VENDOR_ALARMS_3,\n+\t\t\t\t\t\t MDIO_MMD_PMAPMD, &ctrl);\n+\t\t\tif (status)\n+\t\t\t\treturn status;\n+\n+\t\t\tif (ctrl & IXGBE_MDIO_TX_VENDOR_ALARMS_3_RST_MASK) {\n+\t\t\t\tudelay(2);\n+\t\t\t\tbreak;\n+\t\t\t}\n+\t\t} else {\n+\t\t\tstatus = hw->phy.ops.read_reg(hw, MDIO_CTRL1,\n+\t\t\t\t\t\t MDIO_MMD_PHYXS, &ctrl);\n+\t\t\tif (status)\n+\t\t\t\treturn status;\n+\n+\t\t\tif (!(ctrl & MDIO_CTRL1_RESET)) {\n+\t\t\t\tudelay(2);\n+\t\t\t\tbreak;\n+\t\t\t}\n \t\t}\n \t}\n \n", "prefixes": [] }