Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/689591/?format=api
{ "id": 689591, "url": "http://patchwork.ozlabs.org/api/patches/689591/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20161031200034.4729.18959.stgit@localhost6.localdomain6/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20161031200034.4729.18959.stgit@localhost6.localdomain6>", "list_archive_url": null, "date": "2016-10-31T20:00:34", "name": "ixgbevf: handle race between close and suspend on shutdown", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "f782b9b2ee3b62c1b838e6b30b7940d43483470a", "submitter": { "id": 1670, "url": "http://patchwork.ozlabs.org/api/people/1670/?format=api", "name": "Tantilov, Emil S", "email": "emil.s.tantilov@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20161031200034.4729.18959.stgit@localhost6.localdomain6/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/689591/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/689591/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3t754N42XVz9sxS\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 1 Nov 2016 07:07:15 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id C3A1E8A3C6;\n\tMon, 31 Oct 2016 20:07:13 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id ydZX5C4vXcqG; Mon, 31 Oct 2016 20:07:13 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 5F0F58A3E1;\n\tMon, 31 Oct 2016 20:07:13 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id CAB4A1CE773\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 31 Oct 2016 20:07:11 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id ABF448A3E1\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 31 Oct 2016 20:07:11 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Bf0UtCqqWXVr for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 31 Oct 2016 20:07:10 +0000 (UTC)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id D53978A3C6\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 31 Oct 2016 20:07:10 +0000 (UTC)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby orsmga104.jf.intel.com with ESMTP; 31 Oct 2016 13:07:01 -0700", "from estantil-desk3.jf.intel.com (HELO localhost6.localdomain6)\n\t([134.134.3.186])\n\tby fmsmga006.fm.intel.com with ESMTP; 31 Oct 2016 13:07:01 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.31,428,1473145200\"; d=\"scan'208\";a=\"25806218\"", "From": "Emil Tantilov <emil.s.tantilov@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Mon, 31 Oct 2016 13:00:34 -0700", "Message-ID": "<20161031200034.4729.18959.stgit@localhost6.localdomain6>", "User-Agent": "StGit/0.17.1-17-ge4e0", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH] ixgbevf: handle race between close and\n\tsuspend on shutdown", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "When an interface is part of a namespace it is possible that\nixgbevf_close() may be called while ixgbevf_suspend() is running\nwhich ends up in a double free WARN and/or a BUG in free_msi_irqs()\n\nThis patch introduces a new adapter->state bit that will allow us\nto handle this rate atomically. The idea is that ixgbevf_close() should\nnot run if ixgbevf_suspend is in session.\n\nSigned-off-by: Emil Tantilov <emil.s.tantilov@intel.com>\n---\n drivers/net/ethernet/intel/ixgbevf/ixgbevf.h | 1 +\n drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 9 +++++++++\n 2 files changed, 10 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h b/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h\nindex 5639fbe..dc4b3b4 100644\n--- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h\n+++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h\n@@ -446,6 +446,7 @@ enum ixbgevf_state_t {\n \t__IXGBEVF_SERVICE_INITED,\n \t__IXGBEVF_RESET_REQUESTED,\n \t__IXGBEVF_QUEUE_RESET_REQUESTED,\n+\t__IXGBEVF_CLEAR_IRQS,\n };\n \n enum ixgbevf_boards {\ndiff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c\nindex d316f50..8ebe797 100644\n--- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c\n+++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c\n@@ -3242,12 +3242,17 @@ int ixgbevf_close(struct net_device *netdev)\n {\n \tstruct ixgbevf_adapter *adapter = netdev_priv(netdev);\n \n+\tif (test_and_set_bit(__IXGBEVF_CLEAR_IRQS, &adapter->state))\n+\t\treturn 0;\n+\n \tixgbevf_down(adapter);\n \tixgbevf_free_irq(adapter);\n \n \tixgbevf_free_all_tx_resources(adapter);\n \tixgbevf_free_all_rx_resources(adapter);\n \n+\tclear_bit(__IXGBEVF_CLEAR_IRQS, &adapter->state);\n+\n \treturn 0;\n }\n \n@@ -3792,6 +3797,9 @@ static int ixgbevf_suspend(struct pci_dev *pdev, pm_message_t state)\n \tint retval = 0;\n #endif\n \n+\twhile (test_and_set_bit(__IXGBEVF_CLEAR_IRQS, &adapter->state))\n+\t\tusleep_range(1000, 2000);\n+\n \tnetif_device_detach(netdev);\n \n \tif (netif_running(netdev)) {\n@@ -3813,6 +3821,7 @@ static int ixgbevf_suspend(struct pci_dev *pdev, pm_message_t state)\n \tif (!test_and_set_bit(__IXGBEVF_DISABLED, &adapter->state))\n \t\tpci_disable_device(pdev);\n \n+\tclear_bit(__IXGBEVF_CLEAR_IRQS, &adapter->state);\n \treturn 0;\n }\n \n", "prefixes": [] }