Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/688567/?format=api
{ "id": 688567, "url": "http://patchwork.ozlabs.org/api/patches/688567/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/147767679915.21196.12625601185481181813.stgit@mdrustad-wks.jf.intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<147767679915.21196.12625601185481181813.stgit@mdrustad-wks.jf.intel.com>", "list_archive_url": null, "date": "2016-10-28T17:46:39", "name": "[V2] ixgbevf: Handle previously-freed msix_entries", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "779ca84626685f4083daabfbe701dc3d8525af26", "submitter": { "id": 13252, "url": "http://patchwork.ozlabs.org/api/people/13252/?format=api", "name": "Rustad, Mark D", "email": "mark.d.rustad@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/147767679915.21196.12625601185481181813.stgit@mdrustad-wks.jf.intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/688567/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/688567/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3t5B5g3vvSz9t0J\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 29 Oct 2016 04:46:46 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id B6A1BC3063;\n\tFri, 28 Oct 2016 17:46:44 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id JQMB3H-wBpb6; Fri, 28 Oct 2016 17:46:42 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 65800C305F;\n\tFri, 28 Oct 2016 17:46:42 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id E9D291C295A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 28 Oct 2016 17:46:40 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id E67B795CD0\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 28 Oct 2016 17:46:40 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id XZnMdthG+fjY for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 28 Oct 2016 17:46:40 +0000 (UTC)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id F308F95CA7\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 28 Oct 2016 17:46:39 +0000 (UTC)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby fmsmga101.fm.intel.com with ESMTP; 28 Oct 2016 10:46:40 -0700", "from mdrustad-wks.jf.intel.com ([134.134.3.111])\n\tby orsmga003.jf.intel.com with ESMTP; 28 Oct 2016 10:46:39 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.31,411,1473145200\"; d=\"scan'208\";a=\"895178669\"", "From": "Mark D Rustad <mark.d.rustad@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 28 Oct 2016 10:46:39 -0700", "Message-ID": "<147767679915.21196.12625601185481181813.stgit@mdrustad-wks.jf.intel.com>", "User-Agent": "StGit/unknown-version", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH V2] ixgbevf: Handle previously-freed\n\tmsix_entries", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "The msix_entries memory can be freed by a previous suspend or\nremove, so don't crash on close when it isn't there. Also only\nclear the interrupts when the interface is up, because there\naren't any when it is not up.\n\nSigned-off-by: Mark Rustad <mark.d.rustad@intel.com>\n---\nChange in V2:\n- Only clear interrupt scheme when interface is up\n---\n drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 9 +++++++--\n 1 file changed, 7 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c\nindex d2775f032f74..d316f503a727 100644\n--- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c\n+++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c\n@@ -1498,6 +1498,9 @@ static void ixgbevf_free_irq(struct ixgbevf_adapter *adapter)\n {\n \tint i, q_vectors;\n \n+\tif (!adapter->msix_entries)\n+\t\treturn;\n+\n \tq_vectors = adapter->num_msix_vectors;\n \ti = q_vectors - 1;\n \n@@ -2552,6 +2555,9 @@ static void ixgbevf_free_q_vectors(struct ixgbevf_adapter *adapter)\n **/\n static void ixgbevf_reset_interrupt_capability(struct ixgbevf_adapter *adapter)\n {\n+\tif (!adapter->msix_entries)\n+\t\treturn;\n+\n \tpci_disable_msix(adapter->pdev);\n \tkfree(adapter->msix_entries);\n \tadapter->msix_entries = NULL;\n@@ -3794,11 +3800,10 @@ static int ixgbevf_suspend(struct pci_dev *pdev, pm_message_t state)\n \t\tixgbevf_free_irq(adapter);\n \t\tixgbevf_free_all_tx_resources(adapter);\n \t\tixgbevf_free_all_rx_resources(adapter);\n+\t\tixgbevf_clear_interrupt_scheme(adapter);\n \t\trtnl_unlock();\n \t}\n \n-\tixgbevf_clear_interrupt_scheme(adapter);\n-\n #ifdef CONFIG_PM\n \tretval = pci_save_state(pdev);\n \tif (retval)\n", "prefixes": [ "V2" ] }