Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/686804/?format=api
{ "id": 686804, "url": "http://patchwork.ozlabs.org/api/patches/686804/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1477436933-13679-6-git-send-email-bimmy.pujari@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1477436933-13679-6-git-send-email-bimmy.pujari@intel.com>", "list_archive_url": null, "date": "2016-10-25T23:08:50", "name": "[next,S51-V2,5/8] i40e: avoid duplicate private flags definitions", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "e73e1c042473c5a3bbc1c99c80cfebaddece11f4", "submitter": { "id": 68919, "url": "http://patchwork.ozlabs.org/api/people/68919/?format=api", "name": "Pujari, Bimmy", "email": "bimmy.pujari@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1477436933-13679-6-git-send-email-bimmy.pujari@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/686804/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/686804/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3t3TQj6cSKz9t0t\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 26 Oct 2016 10:10:37 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 7C1A492054;\n\tTue, 25 Oct 2016 23:10:36 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id KAgR9FlDR8H6; Tue, 25 Oct 2016 23:10:35 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id F26E7920D9;\n\tTue, 25 Oct 2016 23:10:34 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 2C8121CF861\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 25 Oct 2016 23:10:33 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 1B80A89018\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 25 Oct 2016 23:10:33 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id pb8pIJRVJwOW for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 25 Oct 2016 23:10:23 +0000 (UTC)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 83BA8836A4\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 25 Oct 2016 23:10:23 +0000 (UTC)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby fmsmga105.fm.intel.com with ESMTP; 25 Oct 2016 16:10:22 -0700", "from bimmy.jf.intel.com (HELO bimmy.linux1.jf.intel.com)\n\t([134.134.2.167])\n\tby fmsmga006.fm.intel.com with ESMTP; 25 Oct 2016 16:10:22 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.31,399,1473145200\"; d=\"scan'208\";a=\"23607181\"", "From": "Bimmy Pujari <bimmy.pujari@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 25 Oct 2016 16:08:50 -0700", "Message-Id": "<1477436933-13679-6-git-send-email-bimmy.pujari@intel.com>", "X-Mailer": "git-send-email 2.4.11", "In-Reply-To": "<1477436933-13679-1-git-send-email-bimmy.pujari@intel.com>", "References": "<1477436933-13679-1-git-send-email-bimmy.pujari@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S51-V2 5/8] i40e: avoid duplicate\n\tprivate flags definitions", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Jacob Keller <jacob.e.keller@intel.com>\n\nSeparate the global private flags and the regular private flags per\ninterface into two arrays. Future additions of private flags will not\nneed to be duplicated which may lead to buggy code. Also rename\n\"i40e_priv_flags_strings_gl\" to \"i40e_gl_priv_flags_strings\" for\nclarity, as it reads more naturally.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\nChange-ID: I68caef3c9954eb7da342d7f9d20f2873186f2758\n---\n drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 42 +++++++++++---------------\n 1 file changed, 17 insertions(+), 25 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\nindex b9e1162..f99c135 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n@@ -228,26 +228,22 @@ static const char i40e_gstrings_test[][ETH_GSTRING_LEN] = {\n \n #define I40E_TEST_LEN (sizeof(i40e_gstrings_test) / ETH_GSTRING_LEN)\n \n-static const char i40e_priv_flags_strings_gl[][ETH_GSTRING_LEN] = {\n+static const char i40e_priv_flags_strings[][ETH_GSTRING_LEN] = {\n \t\"MFP\",\n \t\"LinkPolling\",\n \t\"flow-director-atr\",\n \t\"veb-stats\",\n \t\"hw-atr-eviction\",\n-\t\"vf-true-promisc-support\",\n };\n \n-#define I40E_PRIV_FLAGS_GL_STR_LEN ARRAY_SIZE(i40e_priv_flags_strings_gl)\n+#define I40E_PRIV_FLAGS_STR_LEN ARRAY_SIZE(i40e_priv_flags_strings)\n \n-static const char i40e_priv_flags_strings[][ETH_GSTRING_LEN] = {\n-\t\"NPAR\",\n-\t\"LinkPolling\",\n-\t\"flow-director-atr\",\n-\t\"veb-stats\",\n-\t\"hw-atr-eviction\",\n+/* Private flags with a global effect, restricted to PF 0 */\n+static const char i40e_gl_priv_flags_strings[][ETH_GSTRING_LEN] = {\n+\t\"vf-true-promisc-support\",\n };\n \n-#define I40E_PRIV_FLAGS_STR_LEN ARRAY_SIZE(i40e_priv_flags_strings)\n+#define I40E_GL_PRIV_FLAGS_STR_LEN ARRAY_SIZE(i40e_gl_priv_flags_strings)\n \n /**\n * i40e_partition_setting_complaint - generic complaint for MFP restriction\n@@ -1194,10 +1190,9 @@ static void i40e_get_drvinfo(struct net_device *netdev,\n \t\tsizeof(drvinfo->fw_version));\n \tstrlcpy(drvinfo->bus_info, pci_name(pf->pdev),\n \t\tsizeof(drvinfo->bus_info));\n+\tdrvinfo->n_priv_flags = I40E_PRIV_FLAGS_STR_LEN;\n \tif (pf->hw.pf_id == 0)\n-\t\tdrvinfo->n_priv_flags = I40E_PRIV_FLAGS_GL_STR_LEN;\n-\telse\n-\t\tdrvinfo->n_priv_flags = I40E_PRIV_FLAGS_STR_LEN;\n+\t\tdrvinfo->n_priv_flags += I40E_GL_PRIV_FLAGS_STR_LEN;\n }\n \n static void i40e_get_ringparam(struct net_device *netdev,\n@@ -1425,10 +1420,8 @@ static int i40e_get_sset_count(struct net_device *netdev, int sset)\n \t\t\treturn I40E_VSI_STATS_LEN(netdev);\n \t\t}\n \tcase ETH_SS_PRIV_FLAGS:\n-\t\tif (pf->hw.pf_id == 0)\n-\t\t\treturn I40E_PRIV_FLAGS_GL_STR_LEN;\n-\t\telse\n-\t\t\treturn I40E_PRIV_FLAGS_STR_LEN;\n+\t\treturn I40E_PRIV_FLAGS_STR_LEN +\n+\t\t\t(pf->hw.pf_id == 0 ? I40E_GL_PRIV_FLAGS_STR_LEN : 0);\n \tdefault:\n \t\treturn -EOPNOTSUPP;\n \t}\n@@ -1626,15 +1619,14 @@ static void i40e_get_strings(struct net_device *netdev, u32 stringset,\n \t\t/* BUG_ON(p - data != I40E_STATS_LEN * ETH_GSTRING_LEN); */\n \t\tbreak;\n \tcase ETH_SS_PRIV_FLAGS:\n+\t\tfor (i = 0; i < I40E_PRIV_FLAGS_STR_LEN; i++) {\n+\t\t\tmemcpy(data, i40e_priv_flags_strings[i],\n+\t\t\t ETH_GSTRING_LEN);\n+\t\t\tdata += ETH_GSTRING_LEN;\n+\t\t}\n \t\tif (pf->hw.pf_id == 0) {\n-\t\t\tfor (i = 0; i < I40E_PRIV_FLAGS_GL_STR_LEN; i++) {\n-\t\t\t\tmemcpy(data, i40e_priv_flags_strings_gl[i],\n-\t\t\t\t ETH_GSTRING_LEN);\n-\t\t\t\tdata += ETH_GSTRING_LEN;\n-\t\t\t}\n-\t\t} else {\n-\t\t\tfor (i = 0; i < I40E_PRIV_FLAGS_STR_LEN; i++) {\n-\t\t\t\tmemcpy(data, i40e_priv_flags_strings[i],\n+\t\t\tfor (i = 0; i < I40E_GL_PRIV_FLAGS_STR_LEN; i++) {\n+\t\t\t\tmemcpy(data, i40e_gl_priv_flags_strings[i],\n \t\t\t\t ETH_GSTRING_LEN);\n \t\t\t\tdata += ETH_GSTRING_LEN;\n \t\t\t}\n", "prefixes": [ "next", "S51-V2", "5/8" ] }