Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/686797/?format=api
{ "id": 686797, "url": "http://patchwork.ozlabs.org/api/patches/686797/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1477436933-13679-4-git-send-email-bimmy.pujari@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1477436933-13679-4-git-send-email-bimmy.pujari@intel.com>", "list_archive_url": null, "date": "2016-10-25T23:08:48", "name": "[next,S51-V2,3/8] i40e: remove error_param_int label from i40e_vc_config_promiscuous_mode_msg", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "3f983aa24f2d3a97db7b8335e930e5226050c1c5", "submitter": { "id": 68919, "url": "http://patchwork.ozlabs.org/api/people/68919/?format=api", "name": "Pujari, Bimmy", "email": "bimmy.pujari@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1477436933-13679-4-git-send-email-bimmy.pujari@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/686797/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/686797/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3t3TQX2zjdz9t0t\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 26 Oct 2016 10:10:28 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id A4AAE95358;\n\tTue, 25 Oct 2016 23:10:26 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 4iah26SVBIku; Tue, 25 Oct 2016 23:10:25 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id BD44D95364;\n\tTue, 25 Oct 2016 23:10:25 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id BC4981CF861\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 25 Oct 2016 23:10:24 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id AC46D31C54\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 25 Oct 2016 23:10:24 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id G5yXvkgU7VA6 for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 25 Oct 2016 23:10:23 +0000 (UTC)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 3CE9A31C49\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 25 Oct 2016 23:10:23 +0000 (UTC)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby fmsmga105.fm.intel.com with ESMTP; 25 Oct 2016 16:10:22 -0700", "from bimmy.jf.intel.com (HELO bimmy.linux1.jf.intel.com)\n\t([134.134.2.167])\n\tby fmsmga006.fm.intel.com with ESMTP; 25 Oct 2016 16:10:22 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.31,399,1473145200\"; d=\"scan'208\";a=\"23607173\"", "From": "Bimmy Pujari <bimmy.pujari@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 25 Oct 2016 16:08:48 -0700", "Message-Id": "<1477436933-13679-4-git-send-email-bimmy.pujari@intel.com>", "X-Mailer": "git-send-email 2.4.11", "In-Reply-To": "<1477436933-13679-1-git-send-email-bimmy.pujari@intel.com>", "References": "<1477436933-13679-1-git-send-email-bimmy.pujari@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S51-V2 3/8] i40e: remove\n\terror_param_int label from i40e_vc_config_promiscuous_mode_msg", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Jacob Keller <jacob.e.keller@intel.com>\n\nThis label is unnecessary, as are jumping to a block that checks aq_ret\nand then immediately skipping it and returning. So just jump straight to\nthe error_param and remove this unnecessary label.\n\nAlso use goto error_param even in the last check for style consistency.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\nChange-ID: If487c7d10c4048e37c594e5eca167693aaed45f6\n---\n drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 7 ++++---\n 1 file changed, 4 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\nindex 53b46553..46908c0 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n@@ -1536,7 +1536,7 @@ static int i40e_vc_config_promiscuous_mode_msg(struct i40e_vf *vf,\n \t\t\t\tvf->vf_id,\n \t\t\t\ti40e_stat_str(&pf->hw, aq_ret),\n \t\t\t\ti40e_aq_str(&pf->hw, aq_err));\n-\t\t\tgoto error_param_int;\n+\t\t\tgoto error_param;\n \t\t}\n \t}\n \n@@ -1581,15 +1581,16 @@ static int i40e_vc_config_promiscuous_mode_msg(struct i40e_vf *vf,\n \t\t\t\t\t\t\t allmulti, NULL,\n \t\t\t\t\t\t\t true);\n \t\taq_err = pf->hw.aq.asq_last_status;\n-\t\tif (aq_ret)\n+\t\tif (aq_ret) {\n \t\t\tdev_err(&pf->pdev->dev,\n \t\t\t\t\"VF %d failed to set unicast promiscuous mode %8.8x err %s aq_err %s\\n\",\n \t\t\t\tvf->vf_id, info->flags,\n \t\t\t\ti40e_stat_str(&pf->hw, aq_ret),\n \t\t\t\ti40e_aq_str(&pf->hw, aq_err));\n+\t\t\tgoto error_param;\n+\t\t}\n \t}\n \n-error_param_int:\n \tif (!aq_ret) {\n \t\tdev_info(&pf->pdev->dev,\n \t\t\t \"VF %d successfully set unicast promiscuous mode\\n\",\n", "prefixes": [ "next", "S51-V2", "3/8" ] }