Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/686/?format=api
{ "id": 686, "url": "http://patchwork.ozlabs.org/api/patches/686/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/200809192328.42387.herton@mandriva.com.br/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<200809192328.42387.herton@mandriva.com.br>", "list_archive_url": null, "date": "2008-09-20T02:28:42", "name": "[git patches] new network drivers for net-next", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "03bb0a7a06db5f4c6d7eb5a66935a97ca11b0f7d", "submitter": { "id": 336, "url": "http://patchwork.ozlabs.org/api/people/336/?format=api", "name": "Herton Ronaldo Krzesinski", "email": "herton@mandriva.com.br" }, "delegate": { "id": 36, "url": "http://patchwork.ozlabs.org/api/users/36/?format=api", "username": "jgarzik", "first_name": "Jeff", "last_name": "Garzik", "email": "jgarzik@pobox.com" }, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/200809192328.42387.herton@mandriva.com.br/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/686/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/686/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.176.167])\n\tby ozlabs.org (Postfix) with ESMTP id 00460DDEE0\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSat, 20 Sep 2008 12:29:00 +1000 (EST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752939AbYITC2w (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tFri, 19 Sep 2008 22:28:52 -0400", "(majordomo@vger.kernel.org) by vger.kernel.org id S1752785AbYITC2w\n\t(ORCPT <rfc822; netdev-outgoing>); Fri, 19 Sep 2008 22:28:52 -0400", "from perninha.conectiva.com.br ([200.140.247.100]:53347 \"EHLO\n\tperninha.conectiva.com.br\" rhost-flags-OK-OK-OK-OK) by\n\tvger.kernel.org with ESMTP id S1752719AbYITC2u (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Fri, 19 Sep 2008 22:28:50 -0400", "from localhost (perninha.conectiva.com.br [127.0.0.1])\n\tby perninha.conectiva.com.br (Postfix) with ESMTP id 172FB3EB8;\n\tFri, 19 Sep 2008 22:29:05 -0400 (EDT)", "from perninha.conectiva.com.br ([127.0.0.1])\n\tby localhost (perninha.conectiva.com.br [127.0.0.1]) (amavisd-new,\n\tport 10025)\n\twith LMTP id bv9H4tjJtPqy; Fri, 19 Sep 2008 22:29:04 -0400 (EDT)", "from fox.conectiva (fox.conectiva [10.0.2.195])\n\tby perninha.conectiva.com.br (Postfix) with ESMTP id A7E7F3EB4;\n\tFri, 19 Sep 2008 22:29:03 -0400 (EDT)", "from [172.21.225.18] (unknown [172.21.225.18])\n\tby fox.conectiva (Postfix) with ESMTP id 09C9B2F3BE;\n\tFri, 19 Sep 2008 23:28:43 -0300 (BRT)" ], "X-Virus-Scanned": "amavisd-new at conectiva.com.br", "From": "Herton Ronaldo Krzesinski <herton@mandriva.com.br>", "Organization": "Mandriva", "To": "David Miller <davem@davemloft.net>", "Subject": "Re: [git patches] new network drivers for net-next", "Date": "Fri, 19 Sep 2008 23:28:42 -0300", "User-Agent": "KMail/1.9.10", "Cc": "jeff@garzik.org, netdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org", "References": "<20080918160005.GA24281@havoc.gtf.org>\n\t<20080919.155342.12059190.davem@davemloft.net>", "In-Reply-To": "<20080919.155342.12059190.davem@davemloft.net>", "MIME-Version": "1.0", "Content-Type": "Multipart/Mixed;\n boundary=\"Boundary-00=_a/F1I8eHzyvVbXg\"", "Message-Id": "<200809192328.42387.herton@mandriva.com.br>", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "On Friday 19 September 2008 19:53:42 David Miller wrote:\n> From: Jeff Garzik <jeff@garzik.org>\n> Date: Thu, 18 Sep 2008 12:00:05 -0400\n> \n> > \n> > Please pull from 'new-drivers' branch of\n> > master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git new-drivers\n> > \n> > to receive the following updates:\n> \n> Pulled, thanks Jeff.\n> \n> I'll push this to net-next-2.6 after a quick build sanity test.\n\nHi,\n\nwith new enic driver I get the following build error on i386 (config attached):\n CC [M] drivers/net/enic/vnic_cq.o\ndrivers/net/enic/vnic_cq.c: In function 'vnic_cq_init':\ndrivers/net/enic/vnic_cq.c:65: error: implicit declaration of function 'writeq'\nmake[2]: *** [drivers/net/enic/vnic_cq.o] Error 1\nmake[1]: *** [drivers/net/enic] Error 2\nmake: *** [_module_drivers/net] Error 2\n\nSomething like patch below (borrowed from net/s2io.h, ok to use it?) fixes it:", "diff": "--- linux-2.6.27/drivers/net/enic/vnic_dev.h.orig\t2008-09-19 13:57:43.000000000 -0300\n+++ linux-2.6.27/drivers/net/enic/vnic_dev.h\t2008-09-19 14:00:57.000000000 -0300\n@@ -23,6 +23,26 @@\n #include \"vnic_resource.h\"\n #include \"vnic_devcmd.h\"\n \n+#include <linux/io.h>\n+#ifndef readq\n+static inline u64 readq(void __iomem *addr)\n+{\n+\tu64 ret = 0;\n+\tret = readl(addr + 4);\n+\tret <<= 32;\n+\tret |= readl(addr);\n+\n+\treturn ret;\n+}\n+#endif\n+#ifndef writeq\n+static inline void writeq(u64 val, void __iomem *addr)\n+{\n+\twritel((u32) (val), addr);\n+\twritel((u32) (val >> 32), (addr + 4));\n+}\n+#endif\n+\n #ifndef VNIC_PADDR_TARGET\n #define VNIC_PADDR_TARGET\t0x0000000000000000ULL\n #endif\n", "prefixes": [ "git", "patches" ] }