Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/683261/?format=api
{ "id": 683261, "url": "http://patchwork.ozlabs.org/api/patches/683261/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20161017165108.29718-5-davsingl@cisco.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20161017165108.29718-5-davsingl@cisco.com>", "list_archive_url": null, "date": "2016-10-17T16:51:08", "name": "e1000e: x86: e1000 driver trying to free already-free irq.", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "6bc4ebb2e772ac857e2953ac3e311d92669fb092", "submitter": { "id": 70183, "url": "http://patchwork.ozlabs.org/api/people/70183/?format=api", "name": "David Singleton", "email": "davsingl@cisco.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20161017165108.29718-5-davsingl@cisco.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/683261/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/683261/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3syRGD2C3bz9s8x\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 18 Oct 2016 05:15:48 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id E263E8B25E;\n\tMon, 17 Oct 2016 18:15:46 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id i4CYIGznKZij; Mon, 17 Oct 2016 18:15:45 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 54B128B1F9;\n\tMon, 17 Oct 2016 18:15:45 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id E79F61C1F5B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 17 Oct 2016 17:02:02 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id E28589208D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 17 Oct 2016 17:02:02 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Ah6abhVpnqV7 for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 17 Oct 2016 17:02:02 +0000 (UTC)", "from bgl-iport-3.cisco.com (bgl-iport-3.cisco.com [72.163.197.27])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 7328E8AF2B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 17 Oct 2016 17:02:01 +0000 (UTC)", "from vla196-nat.cisco.com (HELO bgl-core-2.cisco.com)\n\t([72.163.197.24])\n\tby bgl-iport-3.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t17 Oct 2016 16:51:24 +0000", "from sjc-ads-6779.cisco.com (sjc-ads-6779.cisco.com [10.30.217.94])\n\tby bgl-core-2.cisco.com (8.14.5/8.14.5) with ESMTP id u9HGp89Q031755; \n\tMon, 17 Oct 2016 16:51:22 GMT" ], "Authentication-Results": "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=cisco.com header.i=@cisco.com header.b=hB00613m;\n\tdkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "delayed 00:10:32 by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n\td=cisco.com; i=@cisco.com; l=1476; q=dns/txt; s=iport;\n\tt=1476723721; x=1477933321;\n\th=from:to:cc:subject:date:message-id;\n\tbh=985+2JnUkv1K1ar6SJJlCuYAP+z4OtwKEdX0uy1h3Qc=;\n\tb=hB00613maTrT79ZQ37d0C+avJUyqjaC8QlEPFX5LpG0Dw+kCOTgjiMO3\n\t2e0kYtoEaq0UB9KEkCxYfhGIuS1ZdgYNI6G+GocZ6HkET2ZNbtz/JsnCU\n\t2g/BbWSD3Hk0I4WfFWJg99TVlNW9WO1CGLy5rnVBakrm5ySEbL62uh3M5 U=;", "X-IronPort-AV": "E=Sophos;i=\"5.31,357,1473120000\"; d=\"scan'208\";a=\"29621408\"", "From": "David Singleton <davsingl@cisco.com>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>", "Date": "Mon, 17 Oct 2016 09:51:08 -0700", "Message-Id": "<20161017165108.29718-5-davsingl@cisco.com>", "X-Mailer": "git-send-email 2.9.3", "X-Mailman-Approved-At": "Mon, 17 Oct 2016 18:15:43 +0000", "Cc": "netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,\n\tlinux-kernel@vger.kernel.org, khalidm <khalidm@cisco.com>", "Subject": "[Intel-wired-lan] [PATCH] e1000e: x86: e1000 driver trying to free\n\talready-free irq.", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: khalidm <khalidm@cisco.com>\n\nDuring systemd reboot sequence network driver interface is shutdown\nby e1000_close. The PCI driver interface is shut by e1000_shutdown.\nThe e1000_shutdown checks for netif_running status, if still up it\nbrings down driver. But it disables msi outside of this if statement,\nregardless of netif status. All this is OK when e1000_close happens\nafter shutdown. However, by default, everything in systemd is done\nin parallel. This creates a conditions where e1000_shutdown is called\nafter e1000_close, therefore hitting BUG_ON assert in free_msi_irqs.\n\nCc-Id: xe-kernel@external.cisco.com\nSigned-off-by: khalidm <khalidm@cisco.com>\nSigned-off-by: David Singleton <davsingl@cisco.com>\n---\n drivers/net/ethernet/intel/e1000e/netdev.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c\nindex 7017281..79f02a6 100644\n--- a/drivers/net/ethernet/intel/e1000e/netdev.c\n+++ b/drivers/net/ethernet/intel/e1000e/netdev.c\n@@ -6283,8 +6283,8 @@ static int e1000e_pm_freeze(struct device *dev)\n \t\t/* Quiesce the device without resetting the hardware */\n \t\te1000e_down(adapter, false);\n \t\te1000_free_irq(adapter);\n+\t\te1000e_reset_interrupt_capability(adapter);\n \t}\n-\te1000e_reset_interrupt_capability(adapter);\n \n \t/* Allow time for pending master requests to run */\n \te1000e_disable_pcie_master(&adapter->hw);\n", "prefixes": [] }