Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/681394/?format=api
{ "id": 681394, "url": "http://patchwork.ozlabs.org/api/patches/681394/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20161012193425.20797.48614.stgit@localhost6.localdomain6/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20161012193425.20797.48614.stgit@localhost6.localdomain6>", "list_archive_url": null, "date": "2016-10-12T19:34:25", "name": "ixgbe: set device if before calling get_invariants", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "4cc3421e9739552cda8625cf2d19fe822ce8cc86", "submitter": { "id": 1670, "url": "http://patchwork.ozlabs.org/api/people/1670/?format=api", "name": "Tantilov, Emil S", "email": "emil.s.tantilov@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20161012193425.20797.48614.stgit@localhost6.localdomain6/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/681394/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/681394/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3svP7v1df9z9rxw\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 13 Oct 2016 06:29:46 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 1815E33276;\n\tWed, 12 Oct 2016 19:29:45 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id d0OBV+v0w2ME; Wed, 12 Oct 2016 19:29:42 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 8951333253;\n\tWed, 12 Oct 2016 19:29:42 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 37F4B1C2286\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 12 Oct 2016 19:29:41 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 2646D33253\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 12 Oct 2016 19:29:41 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id j9SeGjkAyFer for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 12 Oct 2016 19:29:40 +0000 (UTC)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 24E212013B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 12 Oct 2016 19:29:40 +0000 (UTC)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga104.fm.intel.com with ESMTP; 12 Oct 2016 12:29:40 -0700", "from estantil-desk3.jf.intel.com (HELO localhost6.localdomain6)\n\t([134.134.3.186])\n\tby orsmga002.jf.intel.com with ESMTP; 12 Oct 2016 12:29:39 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.31,336,1473145200\"; d=\"scan'208\";\n\ta=\"1063955170\"", "From": "Emil Tantilov <emil.s.tantilov@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 12 Oct 2016 12:34:25 -0700", "Message-ID": "<20161012193425.20797.48614.stgit@localhost6.localdomain6>", "User-Agent": "StGit/0.17.1-17-ge4e0", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH] ixgbe: set device if before calling\n\tget_invariants", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "Fix an issue where set_phy_power was NULL for X550 copper devices\nbecause get_invariants was called before hw->device_id was set.\n\nSigned-off-by: Emil Tantilov <emil.s.tantilov@intel.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 10 ++++++----\n 1 file changed, 6 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex 5227b61..5fb6378 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -5621,7 +5621,8 @@ static void ixgbe_init_dcb(struct ixgbe_adapter *adapter)\n * Fields are initialized based on PCI device information and\n * OS network device settings (MTU size).\n **/\n-static int ixgbe_sw_init(struct ixgbe_adapter *adapter)\n+static int ixgbe_sw_init(struct ixgbe_adapter *adapter,\n+\t\t\t const struct ixgbe_info *ii)\n {\n \tstruct ixgbe_hw *hw = &adapter->hw;\n \tstruct pci_dev *pdev = adapter->pdev;\n@@ -5637,6 +5638,9 @@ static int ixgbe_sw_init(struct ixgbe_adapter *adapter)\n \thw->subsystem_vendor_id = pdev->subsystem_vendor;\n \thw->subsystem_device_id = pdev->subsystem_device;\n \n+\t/* get_invariants needs the device IDs */\n+\tii->get_invariants(hw);\n+\n \t/* Set common capability flags and settings */\n \trss = min_t(int, ixgbe_max_rss_indices(adapter), num_online_cpus());\n \tadapter->ring_feature[RING_F_RSS].limit = rss;\n@@ -9505,10 +9509,8 @@ static int ixgbe_probe(struct pci_dev *pdev, const struct pci_device_id *ent)\n \thw->phy.mdio.mdio_read = ixgbe_mdio_read;\n \thw->phy.mdio.mdio_write = ixgbe_mdio_write;\n \n-\tii->get_invariants(hw);\n-\n \t/* setup the private structure */\n-\terr = ixgbe_sw_init(adapter);\n+\terr = ixgbe_sw_init(adapter, ii);\n \tif (err)\n \t\tgoto err_sw_init;\n \n", "prefixes": [] }