Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/677135/?format=api
{ "id": 677135, "url": "http://patchwork.ozlabs.org/api/patches/677135/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1475224581-121904-1-git-send-email-david.m.ertman@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1475224581-121904-1-git-send-email-david.m.ertman@intel.com>", "list_archive_url": null, "date": "2016-09-30T08:36:21", "name": "i40e: Fix bit logic error in failure case", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "134e14fcd49e1e645b90ebbb1d8caf474949e5da", "submitter": { "id": 64529, "url": "http://patchwork.ozlabs.org/api/people/64529/?format=api", "name": "Dave Ertman", "email": "david.m.ertman@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1475224581-121904-1-git-send-email-david.m.ertman@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/677135/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/677135/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3slxzt0hKJz9sf6\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 1 Oct 2016 02:42:01 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 22D61A6E2A;\n\tFri, 30 Sep 2016 16:42:00 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id v-kli0t5QT_u; Fri, 30 Sep 2016 16:41:58 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 13341A6E36;\n\tFri, 30 Sep 2016 16:41:58 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id A09421C232E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 30 Sep 2016 16:41:54 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 964D8333C0\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 30 Sep 2016 16:41:54 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id lvBVuqfoRbTq for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 30 Sep 2016 16:41:53 +0000 (UTC)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 67139332ED\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 30 Sep 2016 16:41:53 +0000 (UTC)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga103.fm.intel.com with ESMTP; 30 Sep 2016 09:41:48 -0700", "from dmertma-esx6.jf.intel.com (HELO dmertma-l2033.jf.intel.com)\n\t([10.166.37.46])\n\tby fmsmga001.fm.intel.com with ESMTP; 30 Sep 2016 09:41:49 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.31,273,1473145200\"; d=\"scan'208\";\n\ta=\"1047992774\"", "From": "Dave Ertman <david.m.ertman@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 30 Sep 2016 01:36:21 -0700", "Message-Id": "<1475224581-121904-1-git-send-email-david.m.ertman@intel.com>", "X-Mailer": "git-send-email 2.7.4", "Subject": "[Intel-wired-lan] [PATCH] i40e: Fix bit logic error in failure case", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "Patch a036244c0686 \"i40e: Fix kernel panic on enable/disable LLDP\"\nintroduced an error in bit logic.\n\nOriginally this bit manipulation was meant to clear two bits to indicate\nthat DCB was not enabled or capable. An \"&\" was incorrectly used instead\nof an \"|\" bit operator to combine the two bitmasks into one. This also\ncreated a static checker error since the resultant code was a no-op.\n\nThis patch fixes the error by using the correct bit-wise operator.\n\nSigned-off-by: Dave Ertman <david.m.ertman@intel.com>\nFound-by: Dan Carpenter <dan.carpenter@oracle.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 8176596..bf68dd7 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -10955,7 +10955,7 @@ static int i40e_probe(struct pci_dev *pdev, const struct pci_device_id *ent)\n \terr = i40e_init_pf_dcb(pf);\n \tif (err) {\n \t\tdev_info(&pdev->dev, \"DCB init failed %d, disabled\\n\", err);\n-\t\tpf->flags &= ~(I40E_FLAG_DCB_CAPABLE & I40E_FLAG_DCB_ENABLED);\n+\t\tpf->flags &= ~(I40E_FLAG_DCB_CAPABLE | I40E_FLAG_DCB_ENABLED);\n \t\t/* Continue without DCB enabled */\n \t}\n #endif /* CONFIG_I40E_DCB */\n", "prefixes": [] }