Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/675782/?format=api
{ "id": 675782, "url": "http://patchwork.ozlabs.org/api/patches/675782/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1475000934-27335-5-git-send-email-bimmy.pujari@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1475000934-27335-5-git-send-email-bimmy.pujari@intel.com>", "list_archive_url": null, "date": "2016-09-27T18:28:51", "name": "[next,S48,4/7] i40e: Correctly restore LED status after ethtool identify", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "430b5bdc3ad7dc5da2ae19ddb1e8c8a9453c6a5a", "submitter": { "id": 68919, "url": "http://patchwork.ozlabs.org/api/people/68919/?format=api", "name": "Pujari, Bimmy", "email": "bimmy.pujari@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1475000934-27335-5-git-send-email-bimmy.pujari@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/675782/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/675782/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3sk8XN31Ywz9sBr\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 28 Sep 2016 04:30:28 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id ED5498BEA6;\n\tTue, 27 Sep 2016 18:30:26 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id o1iREmjT-CGB; Tue, 27 Sep 2016 18:30:23 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id D5DD08BFD4;\n\tTue, 27 Sep 2016 18:30:20 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id B735E1C1005\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 27 Sep 2016 18:30:17 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id B1DBB2F75B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 27 Sep 2016 18:30:17 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id R9fBnriu9tRz for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 27 Sep 2016 18:30:15 +0000 (UTC)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 159F02F4D5\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 27 Sep 2016 18:30:15 +0000 (UTC)", "from orsmga004.jf.intel.com ([10.7.209.38])\n\tby fmsmga104.fm.intel.com with ESMTP; 27 Sep 2016 11:30:15 -0700", "from bimmy.jf.intel.com (HELO bimmy.linux1.jf.intel.com)\n\t([134.134.2.167])\n\tby orsmga004.jf.intel.com with ESMTP; 27 Sep 2016 11:30:13 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.30,406,1470726000\"; d=\"scan'208\";a=\"14319719\"", "From": "Bimmy Pujari <bimmy.pujari@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 27 Sep 2016 11:28:51 -0700", "Message-Id": "<1475000934-27335-5-git-send-email-bimmy.pujari@intel.com>", "X-Mailer": "git-send-email 2.4.11", "In-Reply-To": "<1475000934-27335-1-git-send-email-bimmy.pujari@intel.com>", "References": "<1475000934-27335-1-git-send-email-bimmy.pujari@intel.com>", "Cc": "Henry Tieman <henry.w.tieman@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S48 4/7] i40e: Correctly restore LED\n\tstatus after ethtool identify", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Henry Tieman <henry.w.tieman@intel.com>\n\nRestore the activity LED status after using \"ethtool -p device\".\n\nA previous commit incorrectly swapped the parameters for\ni40e_led_set(). This results in a failure to restore the LED status\nproperly after using \"ethtool -p\" and the activity LED will remain\noff until a reset occurs.\n\nFix the parameter ordering to restore the LED status after the\nethtool identify operation.\n\nSigned-off-by: Henry Tieman <henry.w.tieman@intel.com>\nChange-ID: I3fc9ac419e67a53e401d8a70fb20fd6cff3af82c\n---\n drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\nindex 8b6eaf4..1705eec 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n@@ -1938,7 +1938,7 @@ static int i40e_set_phys_id(struct net_device *netdev,\n \t\tbreak;\n \tcase ETHTOOL_ID_INACTIVE:\n \t\tif (!(pf->flags & I40E_FLAG_HAVE_BASET_PHY)) {\n-\t\t\ti40e_led_set(hw, false, pf->led_status);\n+\t\t\ti40e_led_set(hw, pf->led_status, false);\n \t\t} else {\n \t\t\tret = i40e_led_set_phy(hw, false, pf->led_status,\n \t\t\t\t\t (pf->phy_led_val |\n", "prefixes": [ "next", "S48", "4/7" ] }