Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/675778/?format=api
{ "id": 675778, "url": "http://patchwork.ozlabs.org/api/patches/675778/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1475000934-27335-3-git-send-email-bimmy.pujari@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1475000934-27335-3-git-send-email-bimmy.pujari@intel.com>", "list_archive_url": null, "date": "2016-09-27T18:28:49", "name": "[next,S48,2/7] i40e: Fix for ethtool LED blinking on X722 for 1GbE.", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "6e7cc0cad11daf6f6e23d9f40dd26d66aa56f14f", "submitter": { "id": 68919, "url": "http://patchwork.ozlabs.org/api/people/68919/?format=api", "name": "Pujari, Bimmy", "email": "bimmy.pujari@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1475000934-27335-3-git-send-email-bimmy.pujari@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/675778/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/675778/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3sk8XJ0qmcz9s9Y\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 28 Sep 2016 04:30:24 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id A794E8BDAD;\n\tTue, 27 Sep 2016 18:30:22 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id OAMyvCFYge0Q; Tue, 27 Sep 2016 18:30:20 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 6F4FA8BEFD;\n\tTue, 27 Sep 2016 18:30:20 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 801E61C1005\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 27 Sep 2016 18:30:17 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 7AEFA2F75B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 27 Sep 2016 18:30:17 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id YvQ9cWRBCR4Y for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 27 Sep 2016 18:30:14 +0000 (UTC)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby silver.osuosl.org (Postfix) with ESMTPS id C54432F959\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 27 Sep 2016 18:30:14 +0000 (UTC)", "from orsmga004.jf.intel.com ([10.7.209.38])\n\tby fmsmga104.fm.intel.com with ESMTP; 27 Sep 2016 11:30:15 -0700", "from bimmy.jf.intel.com (HELO bimmy.linux1.jf.intel.com)\n\t([134.134.2.167])\n\tby orsmga004.jf.intel.com with ESMTP; 27 Sep 2016 11:30:13 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.30,406,1470726000\"; d=\"scan'208\";a=\"14319714\"", "From": "Bimmy Pujari <bimmy.pujari@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 27 Sep 2016 11:28:49 -0700", "Message-Id": "<1475000934-27335-3-git-send-email-bimmy.pujari@intel.com>", "X-Mailer": "git-send-email 2.4.11", "In-Reply-To": "<1475000934-27335-1-git-send-email-bimmy.pujari@intel.com>", "References": "<1475000934-27335-1-git-send-email-bimmy.pujari@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S48 2/7] i40e: Fix for ethtool LED\n\tblinking on X722 for 1GbE.", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Harshitha Ramamurthy <harshitha.ramamurthy@intel.com>\n\nThis patch fixes the problem where when the 'ethtool -p'\nfunctionality is stopped, the activity LED on X722 for\n1GbE stops and no longer blinks. This patch fixes\nthe problem by including the device ID for 1GbE X722\nunder the existing codepath for the 10GBaseT X722 device.\nWithout this patch, the ethtool LED blinking does not\nfunction properly on X722 devices for 1GbE.\n\nSigned-off-by: Harshitha Ramamurthy <harshitha.ramamurthy@intel.com>\nChange-ID: I84192ebd0682fb7f4cf009818c21191eaffac7ea\n---\nTesting Hints: On X722 for 1GbE, the LED should\ncontinue to blink after 'ethtool -p <ethX>' is stopped.\n\n drivers/net/ethernet/intel/i40e/i40e.h | 2 +-\n drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 8 ++++----\n drivers/net/ethernet/intel/i40e/i40e_main.c | 5 +++--\n 3 files changed, 8 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e.h b/drivers/net/ethernet/intel/i40e/i40e.h\nindex b9a5349..ddaa37e 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e.h\n+++ b/drivers/net/ethernet/intel/i40e/i40e.h\n@@ -355,7 +355,7 @@ struct i40e_pf {\n #define I40E_FLAG_NO_DCB_SUPPORT\t\tBIT_ULL(45)\n #define I40E_FLAG_USE_SET_LLDP_MIB\t\tBIT_ULL(46)\n #define I40E_FLAG_STOP_FW_LLDP\t\t\tBIT_ULL(47)\n-#define I40E_FLAG_HAVE_10GBASET_PHY\t\tBIT_ULL(48)\n+#define I40E_FLAG_HAVE_BASET_PHY\t\tBIT_ULL(48)\n #define I40E_FLAG_PF_MAC\t\t\tBIT_ULL(50)\n #define I40E_FLAG_TRUE_PROMISC_SUPPORT\t\tBIT_ULL(51)\n \ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\nindex 2d02654..8b6eaf4 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n@@ -1915,7 +1915,7 @@ static int i40e_set_phys_id(struct net_device *netdev,\n \n \tswitch (state) {\n \tcase ETHTOOL_ID_ACTIVE:\n-\t\tif (!(pf->flags & I40E_FLAG_HAVE_10GBASET_PHY)) {\n+\t\tif (!(pf->flags & I40E_FLAG_HAVE_BASET_PHY)) {\n \t\t\tpf->led_status = i40e_led_get(hw);\n \t\t} else {\n \t\t\ti40e_aq_set_phy_debug(hw, I40E_PHY_DEBUG_ALL, NULL);\n@@ -1925,19 +1925,19 @@ static int i40e_set_phys_id(struct net_device *netdev,\n \t\t}\n \t\treturn blink_freq;\n \tcase ETHTOOL_ID_ON:\n-\t\tif (!(pf->flags & I40E_FLAG_HAVE_10GBASET_PHY))\n+\t\tif (!(pf->flags & I40E_FLAG_HAVE_BASET_PHY))\n \t\t\ti40e_led_set(hw, 0xf, false);\n \t\telse\n \t\t\tret = i40e_led_set_phy(hw, true, pf->led_status, 0);\n \t\tbreak;\n \tcase ETHTOOL_ID_OFF:\n-\t\tif (!(pf->flags & I40E_FLAG_HAVE_10GBASET_PHY))\n+\t\tif (!(pf->flags & I40E_FLAG_HAVE_BASET_PHY))\n \t\t\ti40e_led_set(hw, 0x0, false);\n \t\telse\n \t\t\tret = i40e_led_set_phy(hw, false, pf->led_status, 0);\n \t\tbreak;\n \tcase ETHTOOL_ID_INACTIVE:\n-\t\tif (!(pf->flags & I40E_FLAG_HAVE_10GBASET_PHY)) {\n+\t\tif (!(pf->flags & I40E_FLAG_HAVE_BASET_PHY)) {\n \t\t\ti40e_led_set(hw, false, pf->led_status);\n \t\t} else {\n \t\t\tret = i40e_led_set_phy(hw, false, pf->led_status,\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex b2c9f9d..e6ab33c 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -11237,8 +11237,9 @@ static int i40e_probe(struct pci_dev *pdev, const struct pci_device_id *ent)\n \t\t\t\t\t\t pf->main_vsi_seid);\n \n \tif ((pf->hw.device_id == I40E_DEV_ID_10G_BASE_T) ||\n-\t (pf->hw.device_id == I40E_DEV_ID_10G_BASE_T4))\n-\t\tpf->flags |= I40E_FLAG_HAVE_10GBASET_PHY;\n+\t (pf->hw.device_id == I40E_DEV_ID_10G_BASE_T4) ||\n+\t (pf->hw.device_id == I40E_DEV_ID_1G_BASE_T_X722))\n+\t\tpf->flags |= I40E_FLAG_HAVE_BASET_PHY;\n \n \t/* print a string summarizing features */\n \ti40e_print_features(pf);\n", "prefixes": [ "next", "S48", "2/7" ] }