Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/675777/?format=api
{ "id": 675777, "url": "http://patchwork.ozlabs.org/api/patches/675777/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1475000934-27335-2-git-send-email-bimmy.pujari@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1475000934-27335-2-git-send-email-bimmy.pujari@intel.com>", "list_archive_url": null, "date": "2016-09-27T18:28:48", "name": "[next,S48,1/7] i40e: fix confusing dmesg info for ethtool -L option", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "419d68ba982e64c9617a3abb278b4b90f6b754fd", "submitter": { "id": 68919, "url": "http://patchwork.ozlabs.org/api/people/68919/?format=api", "name": "Pujari, Bimmy", "email": "bimmy.pujari@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1475000934-27335-2-git-send-email-bimmy.pujari@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/675777/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/675777/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3sk8XG1xjCz9s9Y\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 28 Sep 2016 04:30:22 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id CBB868BDA8;\n\tTue, 27 Sep 2016 18:30:20 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 18CgIOwl1cr6; Tue, 27 Sep 2016 18:30:18 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id BB9348BE2C;\n\tTue, 27 Sep 2016 18:30:17 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 5B9621CE8FD\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 27 Sep 2016 18:30:16 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 59192319F3\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 27 Sep 2016 18:30:16 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id hpLbCO0InQkT for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 27 Sep 2016 18:30:14 +0000 (UTC)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 9B4BA2F75B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 27 Sep 2016 18:30:14 +0000 (UTC)", "from orsmga004.jf.intel.com ([10.7.209.38])\n\tby fmsmga104.fm.intel.com with ESMTP; 27 Sep 2016 11:30:15 -0700", "from bimmy.jf.intel.com (HELO bimmy.linux1.jf.intel.com)\n\t([134.134.2.167])\n\tby orsmga004.jf.intel.com with ESMTP; 27 Sep 2016 11:30:13 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.30,406,1470726000\"; d=\"scan'208\";a=\"14319713\"", "From": "Bimmy Pujari <bimmy.pujari@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 27 Sep 2016 11:28:48 -0700", "Message-Id": "<1475000934-27335-2-git-send-email-bimmy.pujari@intel.com>", "X-Mailer": "git-send-email 2.4.11", "In-Reply-To": "<1475000934-27335-1-git-send-email-bimmy.pujari@intel.com>", "References": "<1475000934-27335-1-git-send-email-bimmy.pujari@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S48 1/7] i40e: fix confusing dmesg\n\tinfo for ethtool -L option", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Lihong Yang <lihong.yang@intel.com>\n\nEthtool -L option with the combined parameter is for changing the number of\nmulti-purpose channels of the specified network device. The pre-set maximum\nfor the combined channels is cpu dependent. Currently, for an i40e device,\nwhen the user sets a value between 64 and the maximum that the cpu can\nsupport for the combined parameter, the i40e driver displays the confusing\ninfo in dmesg to only show 64 as the RSS count regardless of what the\naccepted user input is as long as it is larger than 64.\n\nThis patch fixes the message in the i40e driver when the user uses\nethtool -L to change the number of the combined channels to consistently\ndisplay the user requested value if it is valid and accepted by ethtool.\n\nSigned-off-by: Lihong Yang <lihong.yang@intel.com>\nChange-ID: Ia80a68bc844b779a49e0f76e7d3dcc915032d9af\n---\nTesting Hints:\n1. ethtool -l devname to show defaults\n2. ethtool -L devname combined 72 to change the number of channels\n3. ethtool -l devname to check settings\n4. ethtool -S devname to verify 72 queues(tx/rx) got set up\n5. run dmesg to check the i40e driver provided info to be consistent:\n i40e 0000:xx:00.x: User requested queue count/\n HW max RSS count: 72/64\n\n drivers/net/ethernet/intel/i40e/i40e_main.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex b4a4c0b..b2c9f9d 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -8361,8 +8361,8 @@ int i40e_reconfig_rss_queues(struct i40e_pf *pf, int queue_count)\n \n \t\ti40e_pf_config_rss(pf);\n \t}\n-\tdev_info(&pf->pdev->dev, \"RSS count/HW max RSS count: %d/%d\\n\",\n-\t\t pf->alloc_rss_size, pf->rss_size_max);\n+\tdev_info(&pf->pdev->dev, \"User requested queue count/HW max RSS count: %d/%d\\n\",\n+\t\t vsi->req_queue_pairs, pf->rss_size_max);\n \treturn pf->alloc_rss_size;\n }\n \n", "prefixes": [ "next", "S48", "1/7" ] }