Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/675776/?format=api
{ "id": 675776, "url": "http://patchwork.ozlabs.org/api/patches/675776/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1475000934-27335-7-git-send-email-bimmy.pujari@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1475000934-27335-7-git-send-email-bimmy.pujari@intel.com>", "list_archive_url": null, "date": "2016-09-27T18:28:53", "name": "[next,S48,6/7] i40e: Removal of workaround for simple MAC address filter deletion", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "6838a63785199d7705f23c4d8dd14a20ee96ec1a", "submitter": { "id": 68919, "url": "http://patchwork.ozlabs.org/api/people/68919/?format=api", "name": "Pujari, Bimmy", "email": "bimmy.pujari@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1475000934-27335-7-git-send-email-bimmy.pujari@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/675776/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/675776/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3sk8XD0LBwz9s9Y\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 28 Sep 2016 04:30:19 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 7A33C8B986;\n\tTue, 27 Sep 2016 18:30:18 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id f2aaFGiDInXp; Tue, 27 Sep 2016 18:30:17 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 5FB518BE14;\n\tTue, 27 Sep 2016 18:30:17 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 428191C1005\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 27 Sep 2016 18:30:16 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 3B90D8BDA8\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 27 Sep 2016 18:30:16 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id KUcq-Fv3TSnR for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 27 Sep 2016 18:30:15 +0000 (UTC)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 898D08A83B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 27 Sep 2016 18:30:15 +0000 (UTC)", "from orsmga004.jf.intel.com ([10.7.209.38])\n\tby fmsmga104.fm.intel.com with ESMTP; 27 Sep 2016 11:30:15 -0700", "from bimmy.jf.intel.com (HELO bimmy.linux1.jf.intel.com)\n\t([134.134.2.167])\n\tby orsmga004.jf.intel.com with ESMTP; 27 Sep 2016 11:30:13 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.30,406,1470726000\"; d=\"scan'208\";a=\"14319725\"", "From": "Bimmy Pujari <bimmy.pujari@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 27 Sep 2016 11:28:53 -0700", "Message-Id": "<1475000934-27335-7-git-send-email-bimmy.pujari@intel.com>", "X-Mailer": "git-send-email 2.4.11", "In-Reply-To": "<1475000934-27335-1-git-send-email-bimmy.pujari@intel.com>", "References": "<1475000934-27335-1-git-send-email-bimmy.pujari@intel.com>", "Cc": "Filip Sadowski <filip.sadowski@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S48 6/7] i40e: Removal of workaround\n\tfor simple MAC address filter deletion", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Filip Sadowski <filip.sadowski@intel.com>\n\nThis is code refactoring. This patch removes the workaround which deleted\na default MAC filter added by the firmware when the interface was brought\nup. This filter caused frames to pass disregarding the VLAN tagging.\nIt used to be automatically applied after reset in pre-SRA FW versions.\nThis workaround is not needed in production NICs and hence can be removed.\n\nSigned-off-by: Filip Sadowski <filip.sadowski@intel.com>\nChange-ID: I129fe1aae1f17b5a224c9b29a996d916aa1be1ec\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 41 -----------------------------\n 1 file changed, 41 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex e6ab33c..69a9ae5 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -1287,39 +1287,6 @@ int i40e_del_mac_all_vlan(struct i40e_vsi *vsi, u8 *macaddr,\n }\n \n /**\n- * i40e_rm_default_mac_filter - Remove the default MAC filter set by NVM\n- * @vsi: the PF Main VSI - inappropriate for any other VSI\n- * @macaddr: the MAC address\n- *\n- * Remove whatever filter the firmware set up so the driver can manage\n- * its own filtering intelligently.\n- **/\n-static void i40e_rm_default_mac_filter(struct i40e_vsi *vsi, u8 *macaddr)\n-{\n-\tstruct i40e_aqc_remove_macvlan_element_data element;\n-\tstruct i40e_pf *pf = vsi->back;\n-\n-\t/* Only appropriate for the PF main VSI */\n-\tif (vsi->type != I40E_VSI_MAIN)\n-\t\treturn;\n-\n-\tmemset(&element, 0, sizeof(element));\n-\tether_addr_copy(element.mac_addr, macaddr);\n-\telement.vlan_tag = 0;\n-\t/* Ignore error returns, some firmware does it this way... */\n-\telement.flags = I40E_AQC_MACVLAN_DEL_PERFECT_MATCH;\n-\ti40e_aq_remove_macvlan(&pf->hw, vsi->seid, &element, 1, NULL);\n-\n-\tmemset(&element, 0, sizeof(element));\n-\tether_addr_copy(element.mac_addr, macaddr);\n-\telement.vlan_tag = 0;\n-\t/* ...and some firmware does it this way. */\n-\telement.flags = I40E_AQC_MACVLAN_DEL_PERFECT_MATCH |\n-\t\t\tI40E_AQC_MACVLAN_DEL_IGNORE_VLAN;\n-\ti40e_aq_remove_macvlan(&pf->hw, vsi->seid, &element, 1, NULL);\n-}\n-\n-/**\n * i40e_add_filter - Add a mac/vlan filter to the VSI\n * @vsi: the VSI to be searched\n * @macaddr: the MAC address\n@@ -9179,12 +9146,6 @@ static int i40e_config_netdev(struct i40e_vsi *vsi)\n \tif (vsi->type == I40E_VSI_MAIN) {\n \t\tSET_NETDEV_DEV(netdev, &pf->pdev->dev);\n \t\tether_addr_copy(mac_addr, hw->mac.perm_addr);\n-\t\t/* The following steps are necessary to prevent reception\n-\t\t * of tagged packets - some older NVM configurations load a\n-\t\t * default a MAC-VLAN filter that accepts any tagged packet\n-\t\t * which must be replaced by a normal filter.\n-\t\t */\n-\t\ti40e_rm_default_mac_filter(vsi, mac_addr);\n \t\tspin_lock_bh(&vsi->mac_filter_list_lock);\n \t\ti40e_add_filter(vsi, mac_addr, I40E_VLAN_ANY, false, true);\n \t\tspin_unlock_bh(&vsi->mac_filter_list_lock);\n@@ -9697,8 +9658,6 @@ static struct i40e_vsi *i40e_vsi_reinit_setup(struct i40e_vsi *vsi)\n \tpf->vsi[pf->lan_vsi]->tc_config.enabled_tc = 0;\n \tpf->vsi[pf->lan_vsi]->seid = pf->main_vsi_seid;\n \ti40e_vsi_config_tc(pf->vsi[pf->lan_vsi], enabled_tc);\n-\tif (vsi->type == I40E_VSI_MAIN)\n-\t\ti40e_rm_default_mac_filter(vsi, pf->hw.mac.perm_addr);\n \n \t/* assign it some queues */\n \tret = i40e_alloc_rings(vsi);\n", "prefixes": [ "next", "S48", "6/7" ] }