Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/675/?format=api
{ "id": 675, "url": "http://patchwork.ozlabs.org/api/patches/675/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20080919.161632.233411756.davem@davemloft.net/", "project": { "id": 7, "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api", "name": "Linux network development", "link_name": "netdev", "list_id": "netdev.vger.kernel.org", "list_email": "netdev@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20080919.161632.233411756.davem@davemloft.net>", "list_archive_url": null, "date": "2008-09-19T23:16:32", "name": "[1/2] : qlge: Fix warnings in debugging code.", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "fde8d6c4c3efc5bccc1b6e7e0e31098e615cd1bb", "submitter": { "id": 15, "url": "http://patchwork.ozlabs.org/api/people/15/?format=api", "name": "David Miller", "email": "davem@davemloft.net" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20080919.161632.233411756.davem@davemloft.net/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/675/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/675/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<netdev-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.176.167])\n\tby ozlabs.org (Postfix) with ESMTP id 535D3DDF96\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSat, 20 Sep 2008 09:16:49 +1000 (EST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752419AbYISXQq (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tFri, 19 Sep 2008 19:16:46 -0400", "(majordomo@vger.kernel.org) by vger.kernel.org id S1752258AbYISXQq\n\t(ORCPT <rfc822; netdev-outgoing>); Fri, 19 Sep 2008 19:16:46 -0400", "from 74-93-104-97-Washington.hfc.comcastbusiness.net\n\t([74.93.104.97]:41678\n\t\"EHLO sunset.davemloft.net\" rhost-flags-OK-FAIL-OK-OK)\n\tby vger.kernel.org with ESMTP id S1751479AbYISXQo (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Fri, 19 Sep 2008 19:16:44 -0400", "from localhost (localhost [127.0.0.1])\n\tby sunset.davemloft.net (Postfix) with ESMTP id C20E2C8C183;\n\tFri, 19 Sep 2008 16:16:32 -0700 (PDT)" ], "Date": "Fri, 19 Sep 2008 16:16:32 -0700 (PDT)", "Message-Id": "<20080919.161632.233411756.davem@davemloft.net>", "To": "netdev@vger.kernel.org", "CC": "ron.mercer@qlogic.com", "Subject": "[PATCH 1/2]: qlge: Fix warnings in debugging code.", "From": "David Miller <davem@davemloft.net>", "X-Mailer": "Mew version 6.1 on Emacs 22.1 / Mule 5.0 (SAKAKI)", "Mime-Version": "1.0", "Content-Type": "Text/Plain; charset=utf-8", "Content-Transfer-Encoding": "base64", "Sender": "netdev-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<netdev.vger.kernel.org>", "X-Mailing-List": "netdev@vger.kernel.org" }, "content": "qlge: Fix warnings in debugging code.\r\n\r\ndrivers/net/qlge/qlge_dbg.c: In function ‘ql_dump_qdev’:\r\ndrivers/net/qlge/qlge_dbg.c:369: warning: cast to pointer from integer of different size\r\ndrivers/net/qlge/qlge_dbg.c:373: warning: cast to pointer from integer of different size\r\ndrivers/net/qlge/qlge_dbg.c: In function ‘ql_dump_tx_ring’:\r\ndrivers/net/qlge/qlge_dbg.c:457: warning: format ‘%llx’ expects type ‘long long unsigned int’, but argument 2 has type ‘long unsigned int’\r\ndrivers/net/qlge/qlge_dbg.c:461: warning: format ‘%llx’ expects type ‘long long unsigned int’, but argument 2 has type ‘long unsigned int’\r\ndrivers/net/qlge/qlge_dbg.c: In function ‘ql_dump_rx_ring’:\r\ndrivers/net/qlge/qlge_dbg.c:557: warning: format ‘%llx’ expects type ‘long long unsigned int’, but argument 2 has type ‘long unsigned int’\r\ndrivers/net/qlge/qlge_dbg.c:565: warning: format ‘%llx’ expects type ‘long long unsigned int’, but argument 2 has type ‘long unsigned int’\r\ndrivers/net/qlge/qlge_dbg.c:575: warning: format ‘%llx’ expects type ‘long long unsigned int’, but argument 2 has type ‘long unsigned int’\r\ndrivers/net/qlge/qlge_dbg.c:579: warning: format ‘%llx’ expects type ‘long long unsigned int’, but argument 2 has type ‘long unsigned int’\r\ndrivers/net/qlge/qlge_dbg.c:598: warning: format ‘%llx’ expects type ‘long long unsigned int’, but argument 2 has type ‘long unsigned int’\r\ndrivers/net/qlge/qlge_dbg.c:602: warning: format ‘%llx’ expects type ‘long long unsigned int’, but argument 2 has type ‘long unsigned int’\r\n\r\nSigned-off-by: David S. Miller <davem@davemloft.net>\r\n---\r\n drivers/net/qlge/qlge_dbg.c | 24 ++++++++++++------------\r\n 1 files changed, 12 insertions(+), 12 deletions(-)\r\n\r\n-- \r\n1.5.6.5\r\n\r\nN������y��X��ǧv��){.n����z��)��\u001fjg���\u001e�����ݢj/���ޖ��ޙ��&�)ߡ�a������\u000f�+v���w��", "diff": "diff --git a/drivers/net/qlge/qlge_dbg.c b/drivers/net/qlge/qlge_dbg.c\r\nindex f0392b1..47df304 100644\r\n--- a/drivers/net/qlge/qlge_dbg.c\r\n+++ b/drivers/net/qlge/qlge_dbg.c\r\n@@ -365,12 +365,12 @@ void ql_dump_qdev(struct ql_adapter *qdev)\r\n \t qdev->msg_enable);\r\n \tprintk(KERN_ERR PFX \"qdev->rx_ring_shadow_reg_area\t= %p.\\n\",\r\n \t qdev->rx_ring_shadow_reg_area);\r\n-\tprintk(KERN_ERR PFX \"qdev->rx_ring_shadow_reg_dma \t= %p.\\n\",\r\n-\t (void *)qdev->rx_ring_shadow_reg_dma);\r\n+\tprintk(KERN_ERR PFX \"qdev->rx_ring_shadow_reg_dma \t= %llx.\\n\",\r\n+\t (unsigned long long) qdev->rx_ring_shadow_reg_dma);\r\n \tprintk(KERN_ERR PFX \"qdev->tx_ring_shadow_reg_area\t= %p.\\n\",\r\n \t qdev->tx_ring_shadow_reg_area);\r\n-\tprintk(KERN_ERR PFX \"qdev->tx_ring_shadow_reg_dma\t= %p.\\n\",\r\n-\t (void *)qdev->tx_ring_shadow_reg_dma);\r\n+\tprintk(KERN_ERR PFX \"qdev->tx_ring_shadow_reg_dma\t= %llx.\\n\",\r\n+\t (unsigned long long) qdev->tx_ring_shadow_reg_dma);\r\n \tprintk(KERN_ERR PFX \"qdev->intr_count \t\t= %d.\\n\",\r\n \t qdev->intr_count);\r\n \tif (qdev->msi_x_entry)\r\n@@ -454,11 +454,11 @@ void ql_dump_tx_ring(struct tx_ring *tx_ring)\r\n \t tx_ring->wq_id);\r\n \tprintk(KERN_ERR PFX \"tx_ring->base = %p.\\n\", tx_ring->wq_base);\r\n \tprintk(KERN_ERR PFX \"tx_ring->base_dma = 0x%llx.\\n\",\r\n-\t (u64) tx_ring->wq_base_dma);\r\n+\t (unsigned long long) tx_ring->wq_base_dma);\r\n \tprintk(KERN_ERR PFX \"tx_ring->cnsmr_idx_sh_reg = %p.\\n\",\r\n \t tx_ring->cnsmr_idx_sh_reg);\r\n \tprintk(KERN_ERR PFX \"tx_ring->cnsmr_idx_sh_reg_dma = 0x%llx.\\n\",\r\n-\t (u64) tx_ring->cnsmr_idx_sh_reg_dma);\r\n+\t (unsigned long long) tx_ring->cnsmr_idx_sh_reg_dma);\r\n \tprintk(KERN_ERR PFX \"tx_ring->size = %d.\\n\", tx_ring->wq_size);\r\n \tprintk(KERN_ERR PFX \"tx_ring->len = %d.\\n\", tx_ring->wq_len);\r\n \tprintk(KERN_ERR PFX \"tx_ring->prod_idx_db_reg = %p.\\n\",\r\n@@ -554,7 +554,7 @@ void ql_dump_rx_ring(struct rx_ring *rx_ring)\r\n \tprintk(KERN_ERR PFX \"rx_ring->cqicb = %p.\\n\", &rx_ring->cqicb);\r\n \tprintk(KERN_ERR PFX \"rx_ring->cq_base = %p.\\n\", rx_ring->cq_base);\r\n \tprintk(KERN_ERR PFX \"rx_ring->cq_base_dma = %llx.\\n\",\r\n-\t (u64) rx_ring->cq_base_dma);\r\n+\t (unsigned long long) rx_ring->cq_base_dma);\r\n \tprintk(KERN_ERR PFX \"rx_ring->cq_size = %d.\\n\", rx_ring->cq_size);\r\n \tprintk(KERN_ERR PFX \"rx_ring->cq_len = %d.\\n\", rx_ring->cq_len);\r\n \tprintk(KERN_ERR PFX\r\n@@ -562,7 +562,7 @@ void ql_dump_rx_ring(struct rx_ring *rx_ring)\r\n \t rx_ring->prod_idx_sh_reg,\r\n \t rx_ring->prod_idx_sh_reg ? *(rx_ring->prod_idx_sh_reg) : 0);\r\n \tprintk(KERN_ERR PFX \"rx_ring->prod_idx_sh_reg_dma = %llx.\\n\",\r\n-\t (u64) rx_ring->prod_idx_sh_reg_dma);\r\n+\t (unsigned long long) rx_ring->prod_idx_sh_reg_dma);\r\n \tprintk(KERN_ERR PFX \"rx_ring->cnsmr_idx_db_reg = %p.\\n\",\r\n \t rx_ring->cnsmr_idx_db_reg);\r\n \tprintk(KERN_ERR PFX \"rx_ring->cnsmr_idx = %d.\\n\", rx_ring->cnsmr_idx);\r\n@@ -572,11 +572,11 @@ void ql_dump_rx_ring(struct rx_ring *rx_ring)\r\n \r\n \tprintk(KERN_ERR PFX \"rx_ring->lbq_base = %p.\\n\", rx_ring->lbq_base);\r\n \tprintk(KERN_ERR PFX \"rx_ring->lbq_base_dma = %llx.\\n\",\r\n-\t (u64) rx_ring->lbq_base_dma);\r\n+\t (unsigned long long) rx_ring->lbq_base_dma);\r\n \tprintk(KERN_ERR PFX \"rx_ring->lbq_base_indirect = %p.\\n\",\r\n \t rx_ring->lbq_base_indirect);\r\n \tprintk(KERN_ERR PFX \"rx_ring->lbq_base_indirect_dma = %llx.\\n\",\r\n-\t (u64) rx_ring->lbq_base_indirect_dma);\r\n+\t (unsigned long long) rx_ring->lbq_base_indirect_dma);\r\n \tprintk(KERN_ERR PFX \"rx_ring->lbq = %p.\\n\", rx_ring->lbq);\r\n \tprintk(KERN_ERR PFX \"rx_ring->lbq_len = %d.\\n\", rx_ring->lbq_len);\r\n \tprintk(KERN_ERR PFX \"rx_ring->lbq_size = %d.\\n\", rx_ring->lbq_size);\r\n@@ -595,11 +595,11 @@ void ql_dump_rx_ring(struct rx_ring *rx_ring)\r\n \r\n \tprintk(KERN_ERR PFX \"rx_ring->sbq_base = %p.\\n\", rx_ring->sbq_base);\r\n \tprintk(KERN_ERR PFX \"rx_ring->sbq_base_dma = %llx.\\n\",\r\n-\t (u64) rx_ring->sbq_base_dma);\r\n+\t (unsigned long long) rx_ring->sbq_base_dma);\r\n \tprintk(KERN_ERR PFX \"rx_ring->sbq_base_indirect = %p.\\n\",\r\n \t rx_ring->sbq_base_indirect);\r\n \tprintk(KERN_ERR PFX \"rx_ring->sbq_base_indirect_dma = %llx.\\n\",\r\n-\t (u64) rx_ring->sbq_base_indirect_dma);\r\n+\t (unsigned long long) rx_ring->sbq_base_indirect_dma);\r\n \tprintk(KERN_ERR PFX \"rx_ring->sbq = %p.\\n\", rx_ring->sbq);\r\n \tprintk(KERN_ERR PFX \"rx_ring->sbq_len = %d.\\n\", rx_ring->sbq_len);\r\n \tprintk(KERN_ERR PFX \"rx_ring->sbq_size = %d.\\n\", rx_ring->sbq_size);\r\n", "prefixes": [ "1/2" ] }