Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/673729/?format=api
{ "id": 673729, "url": "http://patchwork.ozlabs.org/api/patches/673729/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160922220652.30798.62070.stgit@localhost6.localdomain6/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20160922220652.30798.62070.stgit@localhost6.localdomain6>", "list_archive_url": null, "date": "2016-09-22T22:06:52", "name": "[net-next] ixgbe: fix panic when using macvlan with l2-fwd-offload enabled", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "4bf5f3ec89fc6e70020c619165147b2c50e348d7", "submitter": { "id": 1670, "url": "http://patchwork.ozlabs.org/api/people/1670/?format=api", "name": "Tantilov, Emil S", "email": "emil.s.tantilov@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160922220652.30798.62070.stgit@localhost6.localdomain6/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/673729/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/673729/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3sg9Tv1xKvz9t17\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 23 Sep 2016 08:02:58 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 3F2A58CA99;\n\tThu, 22 Sep 2016 22:02:57 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id bfJP9TtGExcd; Thu, 22 Sep 2016 22:02:56 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 19A538CA35;\n\tThu, 22 Sep 2016 22:02:56 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 653DA1C21CD\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 22 Sep 2016 22:02:55 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 621798CA35\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 22 Sep 2016 22:02:55 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id vsD+e1HuWQFX for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 22 Sep 2016 22:02:54 +0000 (UTC)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 7CD6D8CA33\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 22 Sep 2016 22:02:54 +0000 (UTC)", "from orsmga004.jf.intel.com ([10.7.209.38])\n\tby orsmga102.jf.intel.com with ESMTP; 22 Sep 2016 15:02:54 -0700", "from estantil-desk3.jf.intel.com (HELO localhost6.localdomain6)\n\t([134.134.3.186])\n\tby orsmga004.jf.intel.com with ESMTP; 22 Sep 2016 15:02:53 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.30,379,1470726000\"; d=\"scan'208\";a=\"12733336\"", "From": "Emil Tantilov <emil.s.tantilov@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 22 Sep 2016 15:06:52 -0700", "Message-ID": "<20160922220652.30798.62070.stgit@localhost6.localdomain6>", "User-Agent": "StGit/0.17.1-17-ge4e0", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [net-next PATCH] ixgbe: fix panic when using\n\tmacvlan with l2-fwd-offload enabled", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "Fix NULL pointer dereference in the case where a macvlan interface is\nbrought up while the PF is still down:\n\n#ip link set eth2 down\n#ip link add link eth2 type macvlan\n#ip link set macvlan0 up\n\nBUG: unable to handle kernel NULL pointer dereference at 0000000000000010\nIP: [<ffffffffa0170fb2>] ixgbe_alloc_rx_buffers+0x42/0x1a0 [ixgbe]\n\nCall Trace:\n[<ffffffffa017336b>] ixgbe_configure_rx_ring+0x2eb/0x3d0 [ixgbe]\n[<ffffffffa0173811>] ixgbe_fwd_ring_up+0xd1/0x380 [ixgbe]\n[<ffffffffa0179709>] ixgbe_fwd_add+0x149/0x230 [ixgbe]\n[<ffffffffa0113480>] macvlan_open+0x260/0x2b0 [macvlan]\n\nReported-by: Matthew Garrett <mjg59@coreos.com>\nSigned-off-by: Emil Tantilov <emil.s.tantilov@intel.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 12 ++++++++----\n 1 file changed, 8 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex a244d9a..bd93d82 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -9135,10 +9135,14 @@ static void *ixgbe_fwd_add(struct net_device *pdev, struct net_device *vdev)\n \t\tgoto fwd_add_err;\n \tfwd_adapter->pool = pool;\n \tfwd_adapter->real_adapter = adapter;\n-\terr = ixgbe_fwd_ring_up(vdev, fwd_adapter);\n-\tif (err)\n-\t\tgoto fwd_add_err;\n-\tnetif_tx_start_all_queues(vdev);\n+\n+\tif (netif_running(pdev)) {\n+\t\terr = ixgbe_fwd_ring_up(vdev, fwd_adapter);\n+\t\tif (err)\n+\t\t\tgoto fwd_add_err;\n+\t\tnetif_tx_start_all_queues(vdev);\n+\t}\n+\n \treturn fwd_adapter;\n fwd_add_err:\n \t/* unwind counter and free adapter struct */\n", "prefixes": [ "net-next" ] }