Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/673370/?format=api
{ "id": 673370, "url": "http://patchwork.ozlabs.org/api/patches/673370/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1474549438-27468-1-git-send-email-gpiccoli@linux.vnet.ibm.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1474549438-27468-1-git-send-email-gpiccoli@linux.vnet.ibm.com>", "list_archive_url": null, "date": "2016-09-22T13:03:58", "name": "[net] i40e: disable MSI-X interrupts if we cannot reserve enough vectors", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "03eecd029bf2aacadd723e050b648c4fb0a14964", "submitter": { "id": 67066, "url": "http://patchwork.ozlabs.org/api/people/67066/?format=api", "name": "Guilherme G. Piccoli", "email": "gpiccoli@linux.vnet.ibm.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1474549438-27468-1-git-send-email-gpiccoli@linux.vnet.ibm.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/673370/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/673370/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3sfxXT1ylmz9stY\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 22 Sep 2016 23:04:24 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 91253C0D7F;\n\tThu, 22 Sep 2016 13:04:22 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id W0DiKdj9PL71; Thu, 22 Sep 2016 13:04:19 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id F0494C0D79;\n\tThu, 22 Sep 2016 13:04:18 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 509081C0C30\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 22 Sep 2016 13:04:17 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 4116731C9F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 22 Sep 2016 13:04:17 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id PtIPH9qOP-0A for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 22 Sep 2016 13:04:15 +0000 (UTC)", "from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com\n\t[148.163.158.5])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 8F38A31C9B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 22 Sep 2016 13:04:15 +0000 (UTC)", "from pps.filterd (m0098419.ppops.net [127.0.0.1])\n\tby mx0b-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id\n\tu8MD3wJZ014093 for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 22 Sep 2016 09:04:14 -0400", "from e24smtp04.br.ibm.com (e24smtp04.br.ibm.com [32.104.18.25])\n\tby mx0b-001b2d01.pphosted.com with ESMTP id 25m9p1k7b8-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 22 Sep 2016 09:04:13 -0400", "from localhost\n\tby e24smtp04.br.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <intel-wired-lan@lists.osuosl.org> from\n\t<gpiccoli@linux.vnet.ibm.com>; Thu, 22 Sep 2016 10:04:11 -0300", "from d24dlp01.br.ibm.com (9.18.248.204)\n\tby e24smtp04.br.ibm.com (10.172.0.140) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tThu, 22 Sep 2016 10:04:10 -0300", "from d24relay01.br.ibm.com (d24relay01.br.ibm.com [9.8.31.16])\n\tby d24dlp01.br.ibm.com (Postfix) with ESMTP id A07823520072\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 22 Sep 2016 09:03:45 -0400 (EDT)", "from d24av01.br.ibm.com (d24av01.br.ibm.com [9.8.31.91])\n\tby d24relay01.br.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n\tu8MD49Xu4927702 for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 22 Sep 2016 10:04:09 -0300", "from d24av01.br.ibm.com (localhost [127.0.0.1])\n\tby d24av01.br.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id\n\tu8MD49RL004898 for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 22 Sep 2016 10:04:09 -0300", "from localhost ([9.85.155.181])\n\tby d24av01.br.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id\n\tu8MD4709004856; Thu, 22 Sep 2016 10:04:08 -0300" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "\"Guilherme G. Piccoli\" <gpiccoli@linux.vnet.ibm.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 22 Sep 2016 10:03:58 -0300", "X-Mailer": "git-send-email 2.1.0", "X-TM-AS-MML": "disable", "X-Content-Scanned": "Fidelis XPS MAILER", "x-cbid": "16092213-0028-0000-0000-0000014D3C36", "X-IBM-AV-DETECTION": "SAVI=unused REMOTE=unused XFE=unused", "x-cbparentid": "16092213-0029-0000-0000-00001435EBEF", "Message-Id": "<1474549438-27468-1-git-send-email-gpiccoli@linux.vnet.ibm.com>", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2016-09-22_07:, , signatures=0", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=1\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1609020000\n\tdefinitions=main-1609220237", "Cc": "netdev@vger.kernel.org, gpiccoli@linux.vnet.ibm.com", "Subject": "[Intel-wired-lan] [PATCH net] i40e: disable MSI-X interrupts if we\n\tcannot reserve enough vectors", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "If we fail on allocating enough MSI-X interrupts, we should disable\nthem since they were previously enabled in this point of code.\n\nNot disabling them can lead to WARN_ON() being triggered and subsequent\nfailure in enabling MSI as a fallback; the below message was shown without\nthis patch while we played with interrupt allocation in i40e driver:\n\n[ 21.461346] sysfs: cannot create duplicate filename '/devices/pci0007:00/0007:00:00.0/0007:01:00.3/msi_irqs'\n[ 21.461459] ------------[ cut here ]------------\n[ 21.461514] WARNING: CPU: 64 PID: 1155 at fs/sysfs/dir.c:31 sysfs_warn_dup+0x88/0xc0\n\nAlso, we noticed that without this patch, if we modprobe the module without\nenough MSI-X interrupts (triggering the above warning), unload the module\nand re-load it again, we got a crash on the system.\n\nSigned-off-by: Guilherme G. Piccoli <gpiccoli@linux.vnet.ibm.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 1 +\n 1 file changed, 1 insertion(+)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex d0b3a1b..f8ebe78 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -7721,6 +7721,7 @@ static int i40e_init_msix(struct i40e_pf *pf)\n \t\tpf->flags &= ~I40E_FLAG_MSIX_ENABLED;\n \t\tkfree(pf->msix_entries);\n \t\tpf->msix_entries = NULL;\n+\t\tpci_disable_msix(pf->pdev);\n \t\treturn -ENODEV;\n \n \t} else if (v_actual == I40E_MIN_MSIX) {\n", "prefixes": [ "net" ] }