Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/671678/?format=api
{ "id": 671678, "url": "http://patchwork.ozlabs.org/api/patches/671678/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1474285071-28218-4-git-send-email-sassmann@kpanic.de/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1474285071-28218-4-git-send-email-sassmann@kpanic.de>", "list_archive_url": null, "date": "2016-09-19T11:37:51", "name": "[net-next,3/3] i40e: fix sideband flow director vector allocation", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "538e17f9814ee6c36b31ced00920c7b995c5d779", "submitter": { "id": 7508, "url": "http://patchwork.ozlabs.org/api/people/7508/?format=api", "name": "Stefan Assmann", "email": "sassmann@kpanic.de" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1474285071-28218-4-git-send-email-sassmann@kpanic.de/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/671678/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/671678/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3sd3mk2VCxz9sC4\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 19 Sep 2016 21:38:30 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id DBE2687CDD;\n\tMon, 19 Sep 2016 11:38:28 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id xm5iNegicUcx; Mon, 19 Sep 2016 11:38:25 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 2BA44877BE;\n\tMon, 19 Sep 2016 11:38:25 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 586751C0CF8\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 19 Sep 2016 11:38:23 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 5560E87CCC\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 19 Sep 2016 11:38:23 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id T-E9XVi+exEi for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 19 Sep 2016 11:38:21 +0000 (UTC)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 31BB087024\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 19 Sep 2016 11:38:20 +0000 (UTC)", "from int-mx10.intmail.prod.int.phx2.redhat.com\n\t(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id F418DE2D06;\n\tMon, 19 Sep 2016 11:38:19 +0000 (UTC)", "from w541.redhat.com (ovpn-116-45.ams2.redhat.com [10.36.116.45])\n\tby int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with\n\tESMTP id u8JBcB2W031490; Mon, 19 Sep 2016 07:38:18 -0400" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": [ "from auto-whitelisted by SQLgrey-1.7.6", "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]); Mon, 19 Sep 2016 11:38:20 +0000 (UTC)" ], "From": "Stefan Assmann <sassmann@kpanic.de>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Mon, 19 Sep 2016 13:37:51 +0200", "Message-Id": "<1474285071-28218-4-git-send-email-sassmann@kpanic.de>", "In-Reply-To": "<1474285071-28218-1-git-send-email-sassmann@kpanic.de>", "References": "<1474285071-28218-1-git-send-email-sassmann@kpanic.de>", "X-Scanned-By": "MIMEDefang 2.68 on 10.5.11.23", "Cc": "netdev@vger.kernel.org, davem@davemloft.net, sassmann@kpanic.de", "Subject": "[Intel-wired-lan] [PATCH net-next 3/3] i40e: fix sideband flow\n\tdirector vector allocation", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "Currently if the MSI-X vector limit is reached the sideband flow\ndirector gets disabled. A bit too early to make that decision, as\nvectors may get re-distributed. So move the check further back.\n\nSigned-off-by: Stefan Assmann <sassmann@kpanic.de>\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 11 +++++++++--\n 1 file changed, 9 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 4727c02..19341fc 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -7645,7 +7645,6 @@ static int i40e_init_msix(struct i40e_pf *pf)\n \t\t\tvectors_left--;\n \t\t} else {\n \t\t\tpf->num_fdsb_msix = 0;\n-\t\t\tpf->flags &= ~I40E_FLAG_FD_SB_ENABLED;\n \t\t}\n \t}\n \n@@ -7742,7 +7741,6 @@ static int i40e_init_msix(struct i40e_pf *pf)\n \t\tpf->num_fcoe_qps = 0;\n \t\tpf->num_fcoe_msix = 0;\n #endif\n-\t\tpf->flags &= ~I40E_FLAG_FD_SB_ENABLED;\n \n \t\t/* partition out the remaining vectors */\n \t\tswitch (vec) {\n@@ -7774,6 +7772,10 @@ static int i40e_init_msix(struct i40e_pf *pf)\n \t\t\t\tpf->num_vmdq_vsis = min_t(int, (vec / 2),\n \t\t\t\t\t\t I40E_DEFAULT_NUM_VMDQ_VSI);\n \t\t\t}\n+\t\t\tif (pf->flags & I40E_FLAG_FD_SB_ENABLED) {\n+\t\t\t\tpf->num_fdsb_msix = 1;\n+\t\t\t\tvec--;\n+\t\t\t}\n \t\t\tpf->num_lan_msix = min_t(int,\n \t\t\t (vec - (pf->num_iwarp_msix + pf->num_vmdq_vsis)),\n \t\t\t\t\t\t\t pf->num_lan_msix);\n@@ -7789,6 +7791,11 @@ static int i40e_init_msix(struct i40e_pf *pf)\n \t\t}\n \t}\n \n+\tif ((pf->flags & I40E_FLAG_FD_SB_ENABLED) &&\n+\t (pf->num_fdsb_msix == 0)) {\n+\t\tdev_info(&pf->pdev->dev, \"Sideband Flowdir disabled, not enough MSI-X vectors\\n\");\n+\t\tpf->flags &= ~I40E_FLAG_FD_SB_ENABLED;\n+\t}\n \tif ((pf->flags & I40E_FLAG_VMDQ_ENABLED) &&\n \t (pf->num_vmdq_msix == 0)) {\n \t\tdev_info(&pf->pdev->dev, \"VMDq disabled, not enough MSI-X vectors\\n\");\n", "prefixes": [ "net-next", "3/3" ] }