Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/670428/?format=api
{ "id": 670428, "url": "http://patchwork.ozlabs.org/api/patches/670428/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1473946689-28427-2-git-send-email-sassmann@kpanic.de/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1473946689-28427-2-git-send-email-sassmann@kpanic.de>", "list_archive_url": null, "date": "2016-09-15T13:38:08", "name": "[net-next,1/2] i40e: remove superfluous I40E_DEBUG_USER statement", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": false, "hash": "6e65d7b6901c6fdbca7fd6f756e05a6374c71c59", "submitter": { "id": 7508, "url": "http://patchwork.ozlabs.org/api/people/7508/?format=api", "name": "Stefan Assmann", "email": "sassmann@kpanic.de" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1473946689-28427-2-git-send-email-sassmann@kpanic.de/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/670428/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/670428/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3sZfr13J2Fz9sXy\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 15 Sep 2016 23:48:01 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 0DDD08ACF7;\n\tThu, 15 Sep 2016 13:48:00 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id dNrn+qcCyCn0; Thu, 15 Sep 2016 13:47:59 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 6BA9F8ACE8;\n\tThu, 15 Sep 2016 13:47:59 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 536851C1F6A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 15 Sep 2016 13:47:58 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 521458C287\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 15 Sep 2016 13:47:58 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id FPeGYE3W09fb for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 15 Sep 2016 13:47:56 +0000 (UTC)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 779688C2D8\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 15 Sep 2016 13:47:56 +0000 (UTC)", "from int-mx11.intmail.prod.int.phx2.redhat.com\n\t(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id EEF2F445E5;\n\tThu, 15 Sep 2016 13:38:31 +0000 (UTC)", "from w541.redhat.com (ovpn-116-50.ams2.redhat.com [10.36.116.50])\n\tby int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with\n\tESMTP id u8FDcRGX009298; Thu, 15 Sep 2016 09:38:30 -0400" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": [ "from auto-whitelisted by SQLgrey-1.7.6", "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]); Thu, 15 Sep 2016 13:38:32 +0000 (UTC)" ], "From": "Stefan Assmann <sassmann@kpanic.de>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 15 Sep 2016 15:38:08 +0200", "Message-Id": "<1473946689-28427-2-git-send-email-sassmann@kpanic.de>", "In-Reply-To": "<1473946689-28427-1-git-send-email-sassmann@kpanic.de>", "References": "<1473946689-28427-1-git-send-email-sassmann@kpanic.de>", "X-Scanned-By": "MIMEDefang 2.68 on 10.5.11.24", "Cc": "netdev@vger.kernel.org, davem@davemloft.net, sassmann@kpanic.de", "Subject": "[Intel-wired-lan] [PATCH net-next 1/2] i40e: remove superfluous\n\tI40E_DEBUG_USER statement", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "This debug statement is confusing and never set in the code. Any debug\noutput should be guarded by the proper I40E_DEBUG_* statement which can\nbe enabled via the debug module parameter.\nRemove or convert the I40E_DEBUG_USER cases to I40E_DEBUG_INIT.\n\nSigned-off-by: Stefan Assmann <sassmann@kpanic.de>\n---\n drivers/net/ethernet/intel/i40e/i40e_common.c | 3 ---\n drivers/net/ethernet/intel/i40e/i40e_debugfs.c | 6 -----\n drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 2 --\n drivers/net/ethernet/intel/i40e/i40e_main.c | 35 +++++++++++++-------------\n drivers/net/ethernet/intel/i40e/i40e_type.h | 2 --\n 5 files changed, 17 insertions(+), 31 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_common.c b/drivers/net/ethernet/intel/i40e/i40e_common.c\nindex 2154a34..8ccb09c 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_common.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_common.c\n@@ -3207,9 +3207,6 @@ static void i40e_parse_discover_capabilities(struct i40e_hw *hw, void *buff,\n \t\t\tbreak;\n \t\tcase I40E_AQ_CAP_ID_MSIX:\n \t\t\tp->num_msix_vectors = number;\n-\t\t\ti40e_debug(hw, I40E_DEBUG_INIT,\n-\t\t\t\t \"HW Capability: MSIX vector count = %d\\n\",\n-\t\t\t\t p->num_msix_vectors);\n \t\t\tbreak;\n \t\tcase I40E_AQ_CAP_ID_VF_MSIX:\n \t\t\tp->num_msix_vectors_vf = number;\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c\nindex 05cf9a7..e9c6f1c 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c\n@@ -1210,12 +1210,6 @@ static ssize_t i40e_dbg_command_write(struct file *filp,\n \t\tu32 level;\n \t\tcnt = sscanf(&cmd_buf[10], \"%i\", &level);\n \t\tif (cnt) {\n-\t\t\tif (I40E_DEBUG_USER & level) {\n-\t\t\t\tpf->hw.debug_mask = level;\n-\t\t\t\tdev_info(&pf->pdev->dev,\n-\t\t\t\t\t \"set hw.debug_mask = 0x%08x\\n\",\n-\t\t\t\t\t pf->hw.debug_mask);\n-\t\t\t}\n \t\t\tpf->msg_enable = level;\n \t\t\tdev_info(&pf->pdev->dev, \"set msg_enable = 0x%08x\\n\",\n \t\t\t\t pf->msg_enable);\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\nindex 1835186..c56877c 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n@@ -987,8 +987,6 @@ static void i40e_set_msglevel(struct net_device *netdev, u32 data)\n \tstruct i40e_netdev_priv *np = netdev_priv(netdev);\n \tstruct i40e_pf *pf = np->vsi->back;\n \n-\tif (I40E_DEBUG_USER & data)\n-\t\tpf->hw.debug_mask = data;\n \tpf->msg_enable = data;\n }\n \ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 61b0fc4..56369761 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -6665,16 +6665,19 @@ static int i40e_get_capabilities(struct i40e_pf *pf)\n \t\t}\n \t} while (err);\n \n-\tif (pf->hw.debug_mask & I40E_DEBUG_USER)\n-\t\tdev_info(&pf->pdev->dev,\n-\t\t\t \"pf=%d, num_vfs=%d, msix_pf=%d, msix_vf=%d, fd_g=%d, fd_b=%d, pf_max_q=%d num_vsi=%d\\n\",\n-\t\t\t pf->hw.pf_id, pf->hw.func_caps.num_vfs,\n-\t\t\t pf->hw.func_caps.num_msix_vectors,\n-\t\t\t pf->hw.func_caps.num_msix_vectors_vf,\n-\t\t\t pf->hw.func_caps.fd_filters_guaranteed,\n-\t\t\t pf->hw.func_caps.fd_filters_best_effort,\n-\t\t\t pf->hw.func_caps.num_tx_qp,\n-\t\t\t pf->hw.func_caps.num_vsis);\n+\ti40e_debug(&pf->hw, I40E_DEBUG_INIT,\n+\t\t \"HW Capabilities: PF-id[%d] num_vfs=%d, msix_pf=%d, msix_vf=%d\\n\",\n+\t\t pf->hw.pf_id,\n+\t\t pf->hw.func_caps.num_vfs,\n+\t\t pf->hw.func_caps.num_msix_vectors,\n+\t\t pf->hw.func_caps.num_msix_vectors_vf);\n+\ti40e_debug(&pf->hw, I40E_DEBUG_INIT,\n+\t\t \"HW Capabilities: PF-id[%d] fd_g=%d, fd_b=%d, pf_max_qp=%d num_vsis=%d\\n\",\n+\t\t pf->hw.pf_id,\n+\t\t pf->hw.func_caps.fd_filters_guaranteed,\n+\t\t pf->hw.func_caps.fd_filters_best_effort,\n+\t\t pf->hw.func_caps.num_tx_qp,\n+\t\t pf->hw.func_caps.num_vsis);\n \n #define DEF_NUM_VSI (1 + (pf->hw.func_caps.fcoe ? 1 : 0) \\\n \t\t + pf->hw.func_caps.num_vfs)\n@@ -8495,14 +8498,10 @@ static int i40e_sw_init(struct i40e_pf *pf)\n \tint err = 0;\n \tint size;\n \n-\tpf->msg_enable = netif_msg_init(I40E_DEFAULT_MSG_ENABLE,\n-\t\t\t\t(NETIF_MSG_DRV|NETIF_MSG_PROBE|NETIF_MSG_LINK));\n-\tif (debug != -1 && debug != I40E_DEFAULT_MSG_ENABLE) {\n-\t\tif (I40E_DEBUG_USER & debug)\n-\t\t\tpf->hw.debug_mask = debug;\n-\t\tpf->msg_enable = netif_msg_init((debug & ~I40E_DEBUG_USER),\n-\t\t\t\t\t\tI40E_DEFAULT_MSG_ENABLE);\n-\t}\n+\tpf->msg_enable = netif_msg_init(debug,\n+\t\t\t\t\tNETIF_MSG_DRV |\n+\t\t\t\t\tNETIF_MSG_PROBE |\n+\t\t\t\t\tNETIF_MSG_LINK);\n \n \t/* Set default capability flags */\n \tpf->flags = I40E_FLAG_RX_CSUM_ENABLED |\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_type.h b/drivers/net/ethernet/intel/i40e/i40e_type.h\nindex bd5f13b..7e88e35 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_type.h\n+++ b/drivers/net/ethernet/intel/i40e/i40e_type.h\n@@ -85,8 +85,6 @@ enum i40e_debug_mask {\n \tI40E_DEBUG_AQ_COMMAND\t\t= 0x06000000,\n \tI40E_DEBUG_AQ\t\t\t= 0x0F000000,\n \n-\tI40E_DEBUG_USER\t\t\t= 0xF0000000,\n-\n \tI40E_DEBUG_ALL\t\t\t= 0xFFFFFFFF\n };\n \n", "prefixes": [ "net-next", "1/2" ] }