Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/670427/?format=api
{ "id": 670427, "url": "http://patchwork.ozlabs.org/api/patches/670427/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1473946689-28427-3-git-send-email-sassmann@kpanic.de/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1473946689-28427-3-git-send-email-sassmann@kpanic.de>", "list_archive_url": null, "date": "2016-09-15T13:38:09", "name": "[net-next,2/2] i40e: fix setting debug parameter early", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": false, "hash": "f0dcf61ce0b0e1000de92b24e5558f6011126acb", "submitter": { "id": 7508, "url": "http://patchwork.ozlabs.org/api/people/7508/?format=api", "name": "Stefan Assmann", "email": "sassmann@kpanic.de" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1473946689-28427-3-git-send-email-sassmann@kpanic.de/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/670427/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/670427/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3sZfpF0npTz9sXy\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 15 Sep 2016 23:46:28 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 5058D8BADB;\n\tThu, 15 Sep 2016 13:46:27 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id BXGCyPXP9yZo; Thu, 15 Sep 2016 13:46:26 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 8D7218ABDB;\n\tThu, 15 Sep 2016 13:46:26 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 32CDB1C1F6A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 15 Sep 2016 13:46:25 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 2E6308ACD2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 15 Sep 2016 13:46:25 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id YvzGK6MylE7c for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 15 Sep 2016 13:46:23 +0000 (UTC)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 777E88ACB0\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 15 Sep 2016 13:46:23 +0000 (UTC)", "from int-mx11.intmail.prod.int.phx2.redhat.com\n\t(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 722DDA0BEE;\n\tThu, 15 Sep 2016 13:38:33 +0000 (UTC)", "from w541.redhat.com (ovpn-116-50.ams2.redhat.com [10.36.116.50])\n\tby int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with\n\tESMTP id u8FDcRGY009298; Thu, 15 Sep 2016 09:38:32 -0400" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": [ "delayed 00:07:50 by SQLgrey-1.7.6", "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]); Thu, 15 Sep 2016 13:38:33 +0000 (UTC)" ], "From": "Stefan Assmann <sassmann@kpanic.de>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 15 Sep 2016 15:38:09 +0200", "Message-Id": "<1473946689-28427-3-git-send-email-sassmann@kpanic.de>", "In-Reply-To": "<1473946689-28427-1-git-send-email-sassmann@kpanic.de>", "References": "<1473946689-28427-1-git-send-email-sassmann@kpanic.de>", "X-Scanned-By": "MIMEDefang 2.68 on 10.5.11.24", "Cc": "netdev@vger.kernel.org, davem@davemloft.net, sassmann@kpanic.de", "Subject": "[Intel-wired-lan] [PATCH net-next 2/2] i40e: fix setting debug\n\tparameter early", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "pf->msg_enable is a bitmask, therefore assigning the value of the\n\"debug\" parameter is wrong. It is initialized again later in\ni40e_sw_init() so it didn't cause any problem, except that we missed\nearly debug messages. Moved the initialization and assigned\npf->hw.debug_mask the bitmask as that's what the driver actually uses\nin i40e_debug(). Otherwise the debug parameter is just a noop.\n\nFixes: 5b5faa4 (\"i40e: enable debug earlier\")\n\nSigned-off-by: Stefan Assmann <sassmann@kpanic.de>\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 16 +++++++---------\n 1 file changed, 7 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 56369761..f972f0d 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -8498,11 +8498,6 @@ static int i40e_sw_init(struct i40e_pf *pf)\n \tint err = 0;\n \tint size;\n \n-\tpf->msg_enable = netif_msg_init(debug,\n-\t\t\t\t\tNETIF_MSG_DRV |\n-\t\t\t\t\tNETIF_MSG_PROBE |\n-\t\t\t\t\tNETIF_MSG_LINK);\n-\n \t/* Set default capability flags */\n \tpf->flags = I40E_FLAG_RX_CSUM_ENABLED |\n \t\t I40E_FLAG_MSI_ENABLED |\n@@ -10812,10 +10807,13 @@ static int i40e_probe(struct pci_dev *pdev, const struct pci_device_id *ent)\n \tmutex_init(&hw->aq.asq_mutex);\n \tmutex_init(&hw->aq.arq_mutex);\n \n-\tif (debug != -1) {\n-\t\tpf->msg_enable = pf->hw.debug_mask;\n-\t\tpf->msg_enable = debug;\n-\t}\n+\t/* enable debug prints if requested */\n+\tpf->msg_enable = netif_msg_init(debug,\n+\t\t\t\t\tNETIF_MSG_DRV |\n+\t\t\t\t\tNETIF_MSG_PROBE |\n+\t\t\t\t\tNETIF_MSG_LINK);\n+\tif (debug != -1)\n+\t\tpf->hw.debug_mask = pf->msg_enable;\n \n \t/* do a special CORER for clearing PXE mode once at init */\n \tif (hw->revision_id == 0 &&\n", "prefixes": [ "net-next", "2/2" ] }