Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/670159/?format=api
{ "id": 670159, "url": "http://patchwork.ozlabs.org/api/patches/670159/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1473895479-23035-6-git-send-email-bimmy.pujari@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1473895479-23035-6-git-send-email-bimmy.pujari@intel.com>", "list_archive_url": null, "date": "2016-09-14T23:24:35", "name": "[next,S47,5/9] i40e: Drop code for unsupported flow types", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "d58dae448a4aa9d57fa931efd1335696dc6d1537", "submitter": { "id": 68919, "url": "http://patchwork.ozlabs.org/api/people/68919/?format=api", "name": "Pujari, Bimmy", "email": "bimmy.pujari@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1473895479-23035-6-git-send-email-bimmy.pujari@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/670159/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/670159/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3sZHhg2hwTz9s9N\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 15 Sep 2016 09:25:23 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id F154B861F7;\n\tWed, 14 Sep 2016 23:25:21 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id nHOt8D3B9OoR; Wed, 14 Sep 2016 23:25:20 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 0C4C48747D;\n\tWed, 14 Sep 2016 23:25:20 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 052181C1F19\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 14 Sep 2016 23:25:15 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id F41B086B92\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 14 Sep 2016 23:25:14 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id vPlKbnBLMILC for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 14 Sep 2016 23:25:13 +0000 (UTC)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 48B4C85E12\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 14 Sep 2016 23:25:13 +0000 (UTC)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby orsmga102.jf.intel.com with ESMTP; 14 Sep 2016 16:25:12 -0700", "from bimmy.jf.intel.com (HELO bimmy.linux1.jf.intel.com)\n\t([134.134.2.177])\n\tby fmsmga006.fm.intel.com with ESMTP; 14 Sep 2016 16:25:12 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.30,336,1470726000\"; d=\"scan'208\";a=\"8507714\"", "From": "Bimmy Pujari <bimmy.pujari@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 14 Sep 2016 16:24:35 -0700", "Message-Id": "<1473895479-23035-6-git-send-email-bimmy.pujari@intel.com>", "X-Mailer": "git-send-email 2.4.11", "In-Reply-To": "<1473895479-23035-1-git-send-email-bimmy.pujari@intel.com>", "References": "<1473895479-23035-1-git-send-email-bimmy.pujari@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S47 5/9] i40e: Drop code for\n\tunsupported flow types", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Alexander Duyck <alexander.h.duyck@intel.com>\n\nWe cannot currently support SCTP in the hardware, and IPV4_FLOW is not used\nanywhere by the software so we can go through and drop the functionality\nrelated to these two flow types.\n\nIn addition we cannot support masking based on the protocol value so if the\nuser is expecting a value other than TCP or UDP we should simply return an\nerror rather then trying to allocate a filter for a rule that will only\npartially match what the user requested.\n\nSigned-off-by: Alexander Duyck <alexander.h.duyck@intel.com>\nChange-ID: I10d52bb97d8104d76255fe244551814ff9531a63\n---\nTesting Hints:\n This change should have no impact on actual functionality. All it\n should be doing is removing dead code. As such we should see no\n actual change in how ethtool Flow Director filters are handled.\n\n drivers/net/ethernet/intel/i40e/i40e_txrx.c | 31 +++++------------------------\n 1 file changed, 5 insertions(+), 26 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c b/drivers/net/ethernet/intel/i40e/i40e_txrx.c\nindex d1c3a3a..eba16a1 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_txrx.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c\n@@ -330,22 +330,6 @@ static int i40e_add_del_fdir_tcpv4(struct i40e_vsi *vsi,\n \treturn err ? -EOPNOTSUPP : 0;\n }\n \n-/**\n- * i40e_add_del_fdir_sctpv4 - Add/Remove SCTPv4 Flow Director filters for\n- * a specific flow spec\n- * @vsi: pointer to the targeted VSI\n- * @fd_data: the flow director data required for the FDir descriptor\n- * @add: true adds a filter, false removes it\n- *\n- * Returns 0 if the filters were successfully added or removed\n- **/\n-static int i40e_add_del_fdir_sctpv4(struct i40e_vsi *vsi,\n-\t\t\t\t struct i40e_fdir_filter *fd_data,\n-\t\t\t\t bool add)\n-{\n-\treturn -EOPNOTSUPP;\n-}\n-\n #define I40E_IP_DUMMY_PACKET_LEN 34\n /**\n * i40e_add_del_fdir_ipv4 - Add/Remove IPv4 Flow Director filters for\n@@ -428,12 +412,6 @@ int i40e_add_del_fdir(struct i40e_vsi *vsi,\n \tcase UDP_V4_FLOW:\n \t\tret = i40e_add_del_fdir_udpv4(vsi, input, add);\n \t\tbreak;\n-\tcase SCTP_V4_FLOW:\n-\t\tret = i40e_add_del_fdir_sctpv4(vsi, input, add);\n-\t\tbreak;\n-\tcase IPV4_FLOW:\n-\t\tret = i40e_add_del_fdir_ipv4(vsi, input, add);\n-\t\tbreak;\n \tcase IP_USER_FLOW:\n \t\tswitch (input->ip4_proto) {\n \t\tcase IPPROTO_TCP:\n@@ -442,15 +420,16 @@ int i40e_add_del_fdir(struct i40e_vsi *vsi,\n \t\tcase IPPROTO_UDP:\n \t\t\tret = i40e_add_del_fdir_udpv4(vsi, input, add);\n \t\t\tbreak;\n-\t\tcase IPPROTO_SCTP:\n-\t\t\tret = i40e_add_del_fdir_sctpv4(vsi, input, add);\n-\t\t\tbreak;\n-\t\tdefault:\n+\t\tcase IPPROTO_IP:\n \t\t\tret = i40e_add_del_fdir_ipv4(vsi, input, add);\n \t\t\tbreak;\n+\t\tdefault:\n+\t\t\t/* We cannot support masking based on protocol */\n+\t\t\tgoto unsupported_flow;\n \t\t}\n \t\tbreak;\n \tdefault:\n+unsupported_flow:\n \t\tdev_info(&pf->pdev->dev, \"Could not specify spec type %d\\n\",\n \t\t\t input->flow_type);\n \t\tret = -EINVAL;\n", "prefixes": [ "next", "S47", "5/9" ] }