Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/669015/?format=api
{ "id": 669015, "url": "http://patchwork.ozlabs.org/api/patches/669015/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1473715124-31296-7-git-send-email-bimmy.pujari@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1473715124-31296-7-git-send-email-bimmy.pujari@intel.com>", "list_archive_url": null, "date": "2016-09-12T21:18:42", "name": "[next,S46,6/8] i40e: Strip out debugfs hook for Flow Director filter programming", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "1f04008d744258cd5fb1d9df2dbc33b245ff2719", "submitter": { "id": 68919, "url": "http://patchwork.ozlabs.org/api/people/68919/?format=api", "name": "Pujari, Bimmy", "email": "bimmy.pujari@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1473715124-31296-7-git-send-email-bimmy.pujari@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/669015/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/669015/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3sY10d6999z9sdg\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 13 Sep 2016 07:19:45 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 665628824E;\n\tMon, 12 Sep 2016 21:19:44 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id RbT8EX7H06Yg; Mon, 12 Sep 2016 21:19:35 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 9401188F71;\n\tMon, 12 Sep 2016 21:19:27 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id E826E1C684F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 12 Sep 2016 21:19:25 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id E1A4431618\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 12 Sep 2016 21:19:25 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 36wXsXBf+cvr for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 12 Sep 2016 21:19:17 +0000 (UTC)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 977CB31612\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 12 Sep 2016 21:19:17 +0000 (UTC)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga105.jf.intel.com with ESMTP; 12 Sep 2016 14:19:16 -0700", "from bimmy.jf.intel.com (HELO bimmy.linux1.jf.intel.com)\n\t([134.134.2.177])\n\tby orsmga003.jf.intel.com with ESMTP; 12 Sep 2016 14:19:17 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.30,324,1470726000\"; d=\"scan'208\";a=\"877982160\"", "From": "Bimmy Pujari <bimmy.pujari@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Mon, 12 Sep 2016 14:18:42 -0700", "Message-Id": "<1473715124-31296-7-git-send-email-bimmy.pujari@intel.com>", "X-Mailer": "git-send-email 2.4.11", "In-Reply-To": "<1473715124-31296-1-git-send-email-bimmy.pujari@intel.com>", "References": "<1473715124-31296-1-git-send-email-bimmy.pujari@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S46 6/8] i40e: Strip out debugfs hook\n\tfor Flow Director filter programming", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Alexander Duyck <alexander.h.duyck@intel.com>\n\nThis interface was only ever meant for debug only. Since it is not\nsupposed to be here we are removing it.\n\nSigned-off-by: Alexander Duyck <alexander.h.duyck@intel.com>\nChange-ID: Id771a1e5e7d3e2b4b7f56591b61fb48c921e1d04\n---\nTesting Hints:\n Verify the \"add fd_filter\" and \"rem fd_filter\" functionality\n and all references to it have been removed.\n\n drivers/net/ethernet/intel/i40e/i40e.h | 2 -\n drivers/net/ethernet/intel/i40e/i40e_debugfs.c | 80 --------------------------\n drivers/net/ethernet/intel/i40e/i40e_txrx.c | 5 +-\n 3 files changed, 3 insertions(+), 84 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e.h b/drivers/net/ethernet/intel/i40e/i40e.h\nindex ca2d317..dfc52a9 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e.h\n+++ b/drivers/net/ethernet/intel/i40e/i40e.h\n@@ -714,8 +714,6 @@ struct rtnl_link_stats64 *i40e_get_vsi_stats_struct(struct i40e_vsi *vsi);\n int i40e_fetch_switch_configuration(struct i40e_pf *pf,\n \t\t\t\t bool printconfig);\n \n-int i40e_program_fdir_filter(struct i40e_fdir_filter *fdir_data, u8 *raw_packet,\n-\t\t\t struct i40e_pf *pf, bool add);\n int i40e_add_del_fdir(struct i40e_vsi *vsi,\n \t\t struct i40e_fdir_filter *input, bool add);\n void i40e_fdir_check_and_reenable(struct i40e_pf *pf);\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c\nindex 05cf9a7..435b96c 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c\n@@ -1425,84 +1425,6 @@ static ssize_t i40e_dbg_command_write(struct file *filp,\n \t\tbuff = NULL;\n \t\tkfree(desc);\n \t\tdesc = NULL;\n-\t} else if ((strncmp(cmd_buf, \"add fd_filter\", 13) == 0) ||\n-\t\t (strncmp(cmd_buf, \"rem fd_filter\", 13) == 0)) {\n-\t\tstruct i40e_fdir_filter fd_data;\n-\t\tu16 packet_len, i, j = 0;\n-\t\tchar *asc_packet;\n-\t\tu8 *raw_packet;\n-\t\tbool add = false;\n-\t\tint ret;\n-\n-\t\tif (!(pf->flags & I40E_FLAG_FD_SB_ENABLED))\n-\t\t\tgoto command_write_done;\n-\n-\t\tif (strncmp(cmd_buf, \"add\", 3) == 0)\n-\t\t\tadd = true;\n-\n-\t\tif (add && (pf->auto_disable_flags & I40E_FLAG_FD_SB_ENABLED))\n-\t\t\tgoto command_write_done;\n-\n-\t\tasc_packet = kzalloc(I40E_FDIR_MAX_RAW_PACKET_SIZE,\n-\t\t\t\t GFP_KERNEL);\n-\t\tif (!asc_packet)\n-\t\t\tgoto command_write_done;\n-\n-\t\traw_packet = kzalloc(I40E_FDIR_MAX_RAW_PACKET_SIZE,\n-\t\t\t\t GFP_KERNEL);\n-\n-\t\tif (!raw_packet) {\n-\t\t\tkfree(asc_packet);\n-\t\t\tasc_packet = NULL;\n-\t\t\tgoto command_write_done;\n-\t\t}\n-\n-\t\tcnt = sscanf(&cmd_buf[13],\n-\t\t\t \"%hx %2hhx %2hhx %hx %2hhx %2hhx %hx %x %hd %511s\",\n-\t\t\t &fd_data.q_index,\n-\t\t\t &fd_data.flex_off, &fd_data.pctype,\n-\t\t\t &fd_data.dest_vsi, &fd_data.dest_ctl,\n-\t\t\t &fd_data.fd_status, &fd_data.cnt_index,\n-\t\t\t &fd_data.fd_id, &packet_len, asc_packet);\n-\t\tif (cnt != 10) {\n-\t\t\tdev_info(&pf->pdev->dev,\n-\t\t\t\t \"program fd_filter: bad command string, cnt=%d\\n\",\n-\t\t\t\t cnt);\n-\t\t\tkfree(asc_packet);\n-\t\t\tasc_packet = NULL;\n-\t\t\tkfree(raw_packet);\n-\t\t\tgoto command_write_done;\n-\t\t}\n-\n-\t\t/* fix packet length if user entered 0 */\n-\t\tif (packet_len == 0)\n-\t\t\tpacket_len = I40E_FDIR_MAX_RAW_PACKET_SIZE;\n-\n-\t\t/* make sure to check the max as well */\n-\t\tpacket_len = min_t(u16,\n-\t\t\t\t packet_len, I40E_FDIR_MAX_RAW_PACKET_SIZE);\n-\n-\t\tfor (i = 0; i < packet_len; i++) {\n-\t\t\tcnt = sscanf(&asc_packet[j], \"%2hhx \", &raw_packet[i]);\n-\t\t\tif (!cnt)\n-\t\t\t\tbreak;\n-\t\t\tj += 3;\n-\t\t}\n-\t\tdev_info(&pf->pdev->dev, \"FD raw packet dump\\n\");\n-\t\tprint_hex_dump(KERN_INFO, \"FD raw packet: \",\n-\t\t\t DUMP_PREFIX_OFFSET, 16, 1,\n-\t\t\t raw_packet, packet_len, true);\n-\t\tret = i40e_program_fdir_filter(&fd_data, raw_packet, pf, add);\n-\t\tif (!ret) {\n-\t\t\tdev_info(&pf->pdev->dev, \"Filter command send Status : Success\\n\");\n-\t\t} else {\n-\t\t\tdev_info(&pf->pdev->dev,\n-\t\t\t\t \"Filter command send failed %d\\n\", ret);\n-\t\t}\n-\t\tkfree(raw_packet);\n-\t\traw_packet = NULL;\n-\t\tkfree(asc_packet);\n-\t\tasc_packet = NULL;\n \t} else if (strncmp(cmd_buf, \"fd current cnt\", 14) == 0) {\n \t\tdev_info(&pf->pdev->dev, \"FD current total filter count for this interface: %d\\n\",\n \t\t\t i40e_get_current_fd_count(pf));\n@@ -1727,8 +1649,6 @@ static ssize_t i40e_dbg_command_write(struct file *filp,\n \t\tdev_info(&pf->pdev->dev, \" globr\\n\");\n \t\tdev_info(&pf->pdev->dev, \" send aq_cmd <flags> <opcode> <datalen> <retval> <cookie_h> <cookie_l> <param0> <param1> <param2> <param3>\\n\");\n \t\tdev_info(&pf->pdev->dev, \" send indirect aq_cmd <flags> <opcode> <datalen> <retval> <cookie_h> <cookie_l> <param0> <param1> <param2> <param3> <buffer_len>\\n\");\n-\t\tdev_info(&pf->pdev->dev, \" add fd_filter <dest q_index> <flex_off> <pctype> <dest_vsi> <dest_ctl> <fd_status> <cnt_index> <fd_id> <packet_len> <packet>\\n\");\n-\t\tdev_info(&pf->pdev->dev, \" rem fd_filter <dest q_index> <flex_off> <pctype> <dest_vsi> <dest_ctl> <fd_status> <cnt_index> <fd_id> <packet_len> <packet>\\n\");\n \t\tdev_info(&pf->pdev->dev, \" fd current cnt\");\n \t\tdev_info(&pf->pdev->dev, \" lldp start\\n\");\n \t\tdev_info(&pf->pdev->dev, \" lldp stop\\n\");\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c b/drivers/net/ethernet/intel/i40e/i40e_txrx.c\nindex 9b11fc6..e94e4e1 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_txrx.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c\n@@ -111,8 +111,9 @@ static void i40e_fdir(struct i40e_ring *tx_ring,\n * @pf: The PF pointer\n * @add: True for add/update, False for remove\n **/\n-int i40e_program_fdir_filter(struct i40e_fdir_filter *fdir_data, u8 *raw_packet,\n-\t\t\t struct i40e_pf *pf, bool add)\n+static int i40e_program_fdir_filter(struct i40e_fdir_filter *fdir_data,\n+\t\t\t\t u8 *raw_packet, struct i40e_pf *pf,\n+\t\t\t\t bool add)\n {\n \tstruct i40e_tx_buffer *tx_buf, *first;\n \tstruct i40e_tx_desc *tx_desc;\n", "prefixes": [ "next", "S46", "6/8" ] }