Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/668222/?format=api
{ "id": 668222, "url": "http://patchwork.ozlabs.org/api/patches/668222/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160909195910.32272.11650.stgit@localhost6.localdomain6/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20160909195910.32272.11650.stgit@localhost6.localdomain6>", "list_archive_url": null, "date": "2016-09-09T19:59:10", "name": "[next] ixgbe: reset before SRIOV init to avoid mailbox issues", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "278cd50e875479843e9b3ce9c638287f051629d6", "submitter": { "id": 1670, "url": "http://patchwork.ozlabs.org/api/people/1670/?format=api", "name": "Tantilov, Emil S", "email": "emil.s.tantilov@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160909195910.32272.11650.stgit@localhost6.localdomain6/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/668222/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/668222/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3sW7H94g26z9s3T\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 10 Sep 2016 05:55:49 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 393548B36E;\n\tFri, 9 Sep 2016 19:55:48 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id PA0QMP2bcAAX; Fri, 9 Sep 2016 19:55:46 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 8538B8B349;\n\tFri, 9 Sep 2016 19:55:46 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 90DC51C06D4\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 9 Sep 2016 19:55:45 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 8AEAF2D847\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 9 Sep 2016 19:55:45 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 4Mh54eZXd1fz for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 9 Sep 2016 19:55:45 +0000 (UTC)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby silver.osuosl.org (Postfix) with ESMTPS id E27512D80A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 9 Sep 2016 19:55:44 +0000 (UTC)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby orsmga103.jf.intel.com with ESMTP; 09 Sep 2016 12:55:44 -0700", "from estantil-desk3.jf.intel.com (HELO localhost6.localdomain6)\n\t([134.134.3.186])\n\tby fmsmga001.fm.intel.com with ESMTP; 09 Sep 2016 12:55:44 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.30,306,1470726000\"; d=\"scan'208\";\n\ta=\"1037690903\"", "From": "Emil Tantilov <emil.s.tantilov@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 09 Sep 2016 12:59:10 -0700", "Message-ID": "<20160909195910.32272.11650.stgit@localhost6.localdomain6>", "User-Agent": "StGit/0.17.1-17-ge4e0", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [next PATCH] ixgbe: reset before SRIOV init to\n\tavoid mailbox issues", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "Enabling SRIOV while the ixgbevf driver is loaded will result in all\nmailbox requests from ixgbevf_open() being rejected by ixgbe because\nadapter->clear_to_send is set to false on reset.\n\nCall ixgbe_sriov_reinit() before pci_enable_sriov() to make sure that\nmailbox requests are handled from the time ixgbevf is loaded.\n\nReported-by: Andrew Bowers <andrewx.bowers@intel.com>\nSigned-off-by: Emil Tantilov <emil.s.tantilov@intel.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c\nindex 8618599..343a182 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c\n@@ -329,13 +329,15 @@ static int ixgbe_pci_sriov_enable(struct pci_dev *dev, int num_vfs)\n \tfor (i = 0; i < adapter->num_vfs; i++)\n \t\tixgbe_vf_configuration(dev, (i | 0x10000000));\n \n+\t/* reset before enabling SRIOV to avoid mailbox issues */\n+\tixgbe_sriov_reinit(adapter);\n+\n \terr = pci_enable_sriov(dev, num_vfs);\n \tif (err) {\n \t\te_dev_warn(\"Failed to enable PCI sriov: %d\\n\", err);\n \t\treturn err;\n \t}\n \tixgbe_get_vfs(adapter);\n-\tixgbe_sriov_reinit(adapter);\n \n \treturn num_vfs;\n #else\n", "prefixes": [ "next" ] }