Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/666791/?format=api
{ "id": 666791, "url": "http://patchwork.ozlabs.org/api/patches/666791/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1473210312-29592-6-git-send-email-bimmy.pujari@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1473210312-29592-6-git-send-email-bimmy.pujari@intel.com>", "list_archive_url": null, "date": "2016-09-07T01:05:07", "name": "[next,S45,05/10] i40e: fix deleting mac filters", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "0c85eae94372dc03938e5ff0ff069c7c2d103774", "submitter": { "id": 68919, "url": "http://patchwork.ozlabs.org/api/people/68919/?format=api", "name": "Pujari, Bimmy", "email": "bimmy.pujari@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1473210312-29592-6-git-send-email-bimmy.pujari@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/666791/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/666791/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3sTQJQ4xnkz9s9Y\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 7 Sep 2016 11:05:58 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 42D7D8C01C;\n\tWed, 7 Sep 2016 01:05:57 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 0NQGkkKOLETU; Wed, 7 Sep 2016 01:05:55 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id AD6C68C023;\n\tWed, 7 Sep 2016 01:05:52 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 7AB4F1C105C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 7 Sep 2016 01:05:47 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 7747884751\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 7 Sep 2016 01:05:47 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 6vBt5cn02X7H for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 7 Sep 2016 01:05:45 +0000 (UTC)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 98B51C0908\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 7 Sep 2016 01:05:45 +0000 (UTC)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby orsmga104.jf.intel.com with ESMTP; 06 Sep 2016 18:05:45 -0700", "from bimmy.jf.intel.com (HELO bimmy.linux1.jf.intel.com)\n\t([134.134.2.177])\n\tby fmsmga002.fm.intel.com with ESMTP; 06 Sep 2016 18:05:45 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.30,294,1470726000\"; d=\"scan'208\";\n\ta=\"1052338762\"", "From": "Bimmy Pujari <bimmy.pujari@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 6 Sep 2016 18:05:07 -0700", "Message-Id": "<1473210312-29592-6-git-send-email-bimmy.pujari@intel.com>", "X-Mailer": "git-send-email 2.4.11", "In-Reply-To": "<1473210312-29592-1-git-send-email-bimmy.pujari@intel.com>", "References": "<1473210312-29592-1-git-send-email-bimmy.pujari@intel.com>", "Cc": "Alan Brady <alan.brady@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S45 05/10] i40e: fix deleting mac\n\tfilters", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Alan Brady <alan.brady@intel.com>\n\nThere exists a bug in which deleting a mac filter does not actually\noccur. The driver reports that the filter has been deleted with no\nerror. The problem occurs because the wrong cmd_flag is passed to the\nfirmware when deleting the filter. The firmware reports an error back\nto the driver but it is expressly ignored.\n\nThis fixes the bug by using the correct flag when deleting a filter.\nWithout this patch, deleted filters remain in firmware and function as\nif they had not been deleted.\n\nSigned-off-by: Alan Brady <alan.brady@intel.com>\nChange-ID: I5f22b874f3b83f457702f18f0d5602ca21ac40c3\n---\nTesting-hints:\n I used 'tcpdump -npi <iface>' to watch traffic.\n\n 1. Pass traffic with mac header 00:aa:00:aa:02:01 - no traffic\n 2. Add mac filter - ip maddr add 00:aa:00:aa:02:01 dev enp5s0f0\n 3. Pass traffic with mac header 00:aa:00:aa:02:01 - traffic\n 4. Delete mac filter - ip maddr del 00:aa:00:aa:02:01 dev enp5s0f0\n 5. Pass traffic with mac header 00:aa:00:aa:02:01\n Expected - no traffic\n Actual - traffic\n\n drivers/net/ethernet/intel/i40e/i40e_main.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex e83b317..4c3c6ce 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -1315,7 +1315,7 @@ static void i40e_rm_default_mac_filter(struct i40e_vsi *vsi, u8 *macaddr)\n \telement.vlan_tag = 0;\n \t/* ...and some firmware does it this way. */\n \telement.flags = I40E_AQC_MACVLAN_DEL_PERFECT_MATCH |\n-\t\t\tI40E_AQC_MACVLAN_ADD_IGNORE_VLAN;\n+\t\t\tI40E_AQC_MACVLAN_DEL_IGNORE_VLAN;\n \ti40e_aq_remove_macvlan(&pf->hw, vsi->seid, &element, 1, NULL);\n }\n \n@@ -1908,7 +1908,7 @@ int i40e_sync_vsi_filters(struct i40e_vsi *vsi)\n \t\t\tether_addr_copy(del_list[num_del].mac_addr, f->macaddr);\n \t\t\tif (f->vlan == I40E_VLAN_ANY) {\n \t\t\t\tdel_list[num_del].vlan_tag = 0;\n-\t\t\t\tcmd_flags |= I40E_AQC_MACVLAN_ADD_IGNORE_VLAN;\n+\t\t\t\tcmd_flags |= I40E_AQC_MACVLAN_DEL_IGNORE_VLAN;\n \t\t\t} else {\n \t\t\t\tdel_list[num_del].vlan_tag =\n \t\t\t\t\tcpu_to_le16((u16)(f->vlan));\n", "prefixes": [ "next", "S45", "05/10" ] }