Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/666788/?format=api
{ "id": 666788, "url": "http://patchwork.ozlabs.org/api/patches/666788/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1473210312-29592-2-git-send-email-bimmy.pujari@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1473210312-29592-2-git-send-email-bimmy.pujari@intel.com>", "list_archive_url": null, "date": "2016-09-07T01:05:03", "name": "[next,S45,01/10] i40evf: remove unnecessary error checking against i40evf_up_complete", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "4d1711dde939926703ba990f7c1371d5fd0a4017", "submitter": { "id": 68919, "url": "http://patchwork.ozlabs.org/api/people/68919/?format=api", "name": "Pujari, Bimmy", "email": "bimmy.pujari@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1473210312-29592-2-git-send-email-bimmy.pujari@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/666788/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/666788/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3sTQJM6MXGz9s9Y\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 7 Sep 2016 11:05:55 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 3A1578BF54;\n\tWed, 7 Sep 2016 01:05:54 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id H123EXP1FN-V; Wed, 7 Sep 2016 01:05:52 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id F2C248BFB7;\n\tWed, 7 Sep 2016 01:05:51 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 98A101C1035\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 7 Sep 2016 01:05:46 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 934BDC0901\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 7 Sep 2016 01:05:46 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id uM6mDqflhe6R for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 7 Sep 2016 01:05:45 +0000 (UTC)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 36DF7C0919\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 7 Sep 2016 01:05:45 +0000 (UTC)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby orsmga104.jf.intel.com with ESMTP; 06 Sep 2016 18:05:44 -0700", "from bimmy.jf.intel.com (HELO bimmy.linux1.jf.intel.com)\n\t([134.134.2.177])\n\tby fmsmga002.fm.intel.com with ESMTP; 06 Sep 2016 18:05:45 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.30,294,1470726000\"; d=\"scan'208\";\n\ta=\"1052338750\"", "From": "Bimmy Pujari <bimmy.pujari@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 6 Sep 2016 18:05:03 -0700", "Message-Id": "<1473210312-29592-2-git-send-email-bimmy.pujari@intel.com>", "X-Mailer": "git-send-email 2.4.11", "In-Reply-To": "<1473210312-29592-1-git-send-email-bimmy.pujari@intel.com>", "References": "<1473210312-29592-1-git-send-email-bimmy.pujari@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S45 01/10] i40evf: remove unnecessary\n\terror checking against i40evf_up_complete", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "Function i40evf_up_complete() always returns success. Changed this to a\nvoid type and removed the code that checks the return status and prints\nan error message.\n\nSigned-off-by: Bimmy Pujari <bimmy.pujari@intel.com>\nChange-ID: I8c400f174786b9c855f679e470f35af292fb50ad\n---\n drivers/net/ethernet/intel/i40evf/i40evf_main.c | 11 +++--------\n 1 file changed, 3 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c b/drivers/net/ethernet/intel/i40evf/i40evf_main.c\nindex f751f7b..2074a8f 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40evf_main.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40evf_main.c\n@@ -1007,7 +1007,7 @@ static void i40evf_configure(struct i40evf_adapter *adapter)\n * i40evf_up_complete - Finish the last steps of bringing up a connection\n * @adapter: board private structure\n **/\n-static int i40evf_up_complete(struct i40evf_adapter *adapter)\n+static void i40evf_up_complete(struct i40evf_adapter *adapter)\n {\n \tadapter->state = __I40EVF_RUNNING;\n \tclear_bit(__I40E_DOWN, &adapter->vsi.state);\n@@ -1016,7 +1016,6 @@ static int i40evf_up_complete(struct i40evf_adapter *adapter)\n \n \tadapter->aq_required |= I40EVF_FLAG_AQ_ENABLE_QUEUES;\n \tmod_timer_pending(&adapter->watchdog_timer, jiffies + 1);\n-\treturn 0;\n }\n \n /**\n@@ -1824,9 +1823,7 @@ continue_reset:\n \n \t\ti40evf_configure(adapter);\n \n-\t\terr = i40evf_up_complete(adapter);\n-\t\tif (err)\n-\t\t\tgoto reset_err;\n+\t\ti40evf_up_complete(adapter);\n \n \t\ti40evf_irq_enable(adapter, true);\n \t} else {\n@@ -2056,9 +2053,7 @@ static int i40evf_open(struct net_device *netdev)\n \ti40evf_add_filter(adapter, adapter->hw.mac.addr);\n \ti40evf_configure(adapter);\n \n-\terr = i40evf_up_complete(adapter);\n-\tif (err)\n-\t\tgoto err_req_irq;\n+\ti40evf_up_complete(adapter);\n \n \ti40evf_irq_enable(adapter, true);\n \n", "prefixes": [ "next", "S45", "01/10" ] }