Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/666785/?format=api
{ "id": 666785, "url": "http://patchwork.ozlabs.org/api/patches/666785/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1473210312-29592-4-git-send-email-bimmy.pujari@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1473210312-29592-4-git-send-email-bimmy.pujari@intel.com>", "list_archive_url": null, "date": "2016-09-07T01:05:05", "name": "[next,S45,03/10] i40evf: remove unnecessary error checking against i40e_shutdown_adminq", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "38adce1d0a6407b40d0ee53ea9286704ca831801", "submitter": { "id": 68919, "url": "http://patchwork.ozlabs.org/api/people/68919/?format=api", "name": "Pujari, Bimmy", "email": "bimmy.pujari@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1473210312-29592-4-git-send-email-bimmy.pujari@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/666785/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/666785/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3sTQJF6qmVz9sD5\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 7 Sep 2016 11:05:49 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 8E5478BFE8;\n\tWed, 7 Sep 2016 01:05:48 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id egck3yN0Olng; Wed, 7 Sep 2016 01:05:47 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 56EF48BF5C;\n\tWed, 7 Sep 2016 01:05:47 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id E96691C1035\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 7 Sep 2016 01:05:45 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id E5A39C0937\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 7 Sep 2016 01:05:45 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 1hNCMAmJ7WQE for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 7 Sep 2016 01:05:45 +0000 (UTC)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 67CE4C0901\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 7 Sep 2016 01:05:45 +0000 (UTC)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby orsmga104.jf.intel.com with ESMTP; 06 Sep 2016 18:05:44 -0700", "from bimmy.jf.intel.com (HELO bimmy.linux1.jf.intel.com)\n\t([134.134.2.177])\n\tby fmsmga002.fm.intel.com with ESMTP; 06 Sep 2016 18:05:45 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.30,294,1470726000\"; d=\"scan'208\";\n\ta=\"1052338756\"", "From": "Bimmy Pujari <bimmy.pujari@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 6 Sep 2016 18:05:05 -0700", "Message-Id": "<1473210312-29592-4-git-send-email-bimmy.pujari@intel.com>", "X-Mailer": "git-send-email 2.4.11", "In-Reply-To": "<1473210312-29592-1-git-send-email-bimmy.pujari@intel.com>", "References": "<1473210312-29592-1-git-send-email-bimmy.pujari@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S45 03/10] i40evf: remove unnecessary\n\terror checking against i40e_shutdown_adminq", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Lihong Yang <lihong.yang@intel.com>\n\nThe i40e_shutdown_adminq function never returns failure. There is no need to \ncheck the non-0 return value. Clean up the unnecessary error checking and \nwarning against it.\n\nSigned-off-by: Lihong Yang <lihong.yang@intel.com>\nChange-ID: Ibb616f09cfb93bd1a872ebf3241a15fb8354b31b\n---\nTesting Hints:\nFound by static code analysis. Check by code inspection.\n\n drivers/net/ethernet/intel/i40evf/i40evf_main.c | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c b/drivers/net/ethernet/intel/i40evf/i40evf_main.c\nindex 2074a8f..f2111d2 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40evf_main.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40evf_main.c\n@@ -1782,8 +1782,7 @@ continue_reset:\n \ti40evf_free_all_tx_resources(adapter);\n \n \t/* kill and reinit the admin queue */\n-\tif (i40evf_shutdown_adminq(hw))\n-\t\tdev_warn(&adapter->pdev->dev, \"Failed to shut down adminq\\n\");\n+\ti40evf_shutdown_adminq(hw);\n \tadapter->current_op = I40E_VIRTCHNL_OP_UNKNOWN;\n \terr = i40evf_init_adminq(hw);\n \tif (err)\n", "prefixes": [ "next", "S45", "03/10" ] }