Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 665330,
    "url": "http://patchwork.ozlabs.org/api/patches/665330/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/alpine.DEB.2.10.1609022241560.3378@hadrien/",
    "project": {
        "id": 2,
        "url": "http://patchwork.ozlabs.org/api/projects/2/?format=api",
        "name": "Linux PPC development",
        "link_name": "linuxppc-dev",
        "list_id": "linuxppc-dev.lists.ozlabs.org",
        "list_email": "linuxppc-dev@lists.ozlabs.org",
        "web_url": "https://github.com/linuxppc/wiki/wiki",
        "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git",
        "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/",
        "list_archive_url": "https://lore.kernel.org/linuxppc-dev/",
        "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/",
        "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}"
    },
    "msgid": "<alpine.DEB.2.10.1609022241560.3378@hadrien>",
    "list_archive_url": "https://lore.kernel.org/linuxppc-dev/alpine.DEB.2.10.1609022241560.3378@hadrien/",
    "date": "2016-09-02T20:43:14",
    "name": "[Ksummit-discuss,CORE,TOPIC] (group) maintainership models",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "c32ccfe2475ff6d0e423f0b109f0df44d855f324",
    "submitter": {
        "id": 10041,
        "url": "http://patchwork.ozlabs.org/api/people/10041/?format=api",
        "name": "Julia Lawall",
        "email": "julia.lawall@lip6.fr"
    },
    "delegate": null,
    "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/alpine.DEB.2.10.1609022241560.3378@hadrien/mbox/",
    "series": [],
    "comments": "http://patchwork.ozlabs.org/api/patches/665330/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/665330/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>",
        "X-Original-To": [
            "patchwork-incoming@ozlabs.org",
            "linuxppc-dev@lists.ozlabs.org"
        ],
        "Delivered-To": [
            "patchwork-incoming@ozlabs.org",
            "linuxppc-dev@lists.ozlabs.org"
        ],
        "Received": [
            "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3sQrmV6HpHz9s3T\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSat,  3 Sep 2016 06:47:54 +1000 (AEST)",
            "from ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3sQrmV5T5HzDsWl\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSat,  3 Sep 2016 06:47:54 +1000 (AEST)",
            "from mail2-relais-roc.national.inria.fr\n\t(mail2-relais-roc.national.inria.fr [192.134.164.83])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3sQrgH5W5QzDsd9\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tSat,  3 Sep 2016 06:43:21 +1000 (AEST)",
            "from 198.67.28.109.rev.sfr.net (HELO hadrien) ([109.28.67.198])\n\tby mail2-relais-roc.national.inria.fr with\n\tESMTP/TLS/DHE-RSA-AES256-SHA; 02 Sep 2016 22:43:14 +0200"
        ],
        "X-IronPort-AV": "E=Sophos;i=\"5.30,272,1470693600\"; d=\"scan'208\";a=\"235053501\"",
        "Date": "Fri, 2 Sep 2016 22:43:14 +0200 (CEST)",
        "From": "Julia Lawall <julia.lawall@lip6.fr>",
        "X-X-Sender": "jll@hadrien",
        "To": "Linus Torvalds <torvalds@linux-foundation.org>",
        "Subject": "Re: [Ksummit-discuss] [CORE TOPIC] (group) maintainership models",
        "In-Reply-To": "<CA+55aFzw-KkQOhVJG+c-WEFA=6o5aXy=yU9KXQ7jwy-xy--d9Q@mail.gmail.com>",
        "Message-ID": "<alpine.DEB.2.10.1609022241560.3378@hadrien>",
        "References": "<CAKMK7uEuqLLf2bCyB-sAuu5WvVA1Kp7Jvc33k3um5DfdQr4eyg@mail.gmail.com>\n\t<20160902104619.GD9355@localhost>\n\t<CA+55aFwSpNrOuOzaR5hh0A1XvuTu0=xVbE_CV1RVf9GMrTPDNQ@mail.gmail.com>\n\t<7359509.5sppVSLXcK@wuerfel>\n\t<CA+55aFzw-KkQOhVJG+c-WEFA=6o5aXy=yU9KXQ7jwy-xy--d9Q@mail.gmail.com>",
        "User-Agent": "Alpine 2.10 (DEB 1266 2009-07-14)",
        "MIME-Version": "1.0",
        "Content-Type": "TEXT/PLAIN; charset=US-ASCII",
        "X-BeenThere": "linuxppc-dev@lists.ozlabs.org",
        "X-Mailman-Version": "2.1.22",
        "Precedence": "list",
        "List-Id": "Linux on PowerPC Developers Mail List\n\t<linuxppc-dev.lists.ozlabs.org>",
        "List-Unsubscribe": "<https://lists.ozlabs.org/options/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>",
        "List-Archive": "<http://lists.ozlabs.org/pipermail/linuxppc-dev/>",
        "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>",
        "List-Help": "<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>",
        "List-Subscribe": "<https://lists.ozlabs.org/listinfo/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>",
        "Cc": "Arnd Bergmann <arnd@arndb.de>, ksummit-discuss@lists.linuxfoundation.org,\n\tDave Airlie <airlied@linux.ie>, \"Nikula,\n\tJani\" <jani.nikula@linux.intel.com>, \n\tGrant Likely <grant.likely@linaro.org>,\n\tppc-dev <linuxppc-dev@lists.ozlabs.org>",
        "Errors-To": "linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org",
        "Sender": "\"Linuxppc-dev\"\n\t<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>"
    },
    "content": "On Fri, 2 Sep 2016, Linus Torvalds wrote:\n\n> On Fri, Sep 2, 2016 at 1:06 PM, Arnd Bergmann <arnd@arndb.de> wrote:\n> >\n> > When I once looked, I thought all drivers using NO_IRQ were specific\n> > to powerpc or one of the less common architectures.\n>\n> powerpc definitely does seem to be the biggest case, with about half\n> the instances of NO_IRQ being under arch/powerpc/ (and a few more in\n> ppc-specific drivers).\n>\n> Adding the powerpc maintainers to the list - because it would really\n> be nice to get rid of it, or at least make it *so* rare that we don't\n> have people re-introducing it again because they thought it was the\n> right thing to do.\n>\n> A fair amount of of it could even be done by some trivial scripting.\n> Something like\n>\n>   git grep -wl NO_IRQ arch/powerpc/ | while read a\n>   do\n>       sed 's/(\\([a-z_]*irq\\) != NO_IRQ)/(\\1)/' < $a > $a.new\n>       sed 's/(\\([a-z_]*irq\\) == NO_IRQ)/(!\\1)/' < $a.new > $a\n>   done\n>\n> does fix at least a few of the cases. It still leaves several\n> assignments and \"return NO_IRQ;\" statements, but a few more\n> sed-scripts would take care of most of it. Then remove the #define,\n> and do a full build to find any straggling cases.\n\nLike this?\n\n@@\nexpression e;\n@@\n\ne\n- != NO_IRQ\n\n@@\nexpression e;\n@@\n\n+!\ne\n- == NO_IRQ\n\n@@\n@@\n\n- NO_IRQ\n+ 0\n\n---\n\nIs it always correct to replace return NO_IRQ by return 0?\n\nCompletely untested patch below.\n\njulia",
    "diff": "diff -u -p a/arch/powerpc/platforms/52xx/mpc52xx_pic.c b/arch/powerpc/platforms/52xx/mpc52xx_pic.c\n--- a/arch/powerpc/platforms/52xx/mpc52xx_pic.c\n+++ b/arch/powerpc/platforms/52xx/mpc52xx_pic.c\n@@ -511,7 +511,7 @@ unsigned int mpc52xx_get_irq(void)\n \t\t\tirq |= (MPC52xx_IRQ_L1_PERP << MPC52xx_IRQ_L1_OFFSET);\n \t\t}\n \t} else {\n-\t\treturn NO_IRQ;\n+\t\treturn 0;\n \t}\n\n \treturn irq_linear_revmap(mpc52xx_irqhost, irq);\ndiff -u -p a/arch/powerpc/platforms/chrp/setup.c b/arch/powerpc/platforms/chrp/setup.c\n--- a/arch/powerpc/platforms/chrp/setup.c\n+++ b/arch/powerpc/platforms/chrp/setup.c\n@@ -368,7 +368,7 @@ static void chrp_8259_cascade(struct irq\n \tstruct irq_chip *chip = irq_desc_get_chip(desc);\n \tunsigned int cascade_irq = i8259_irq();\n\n-\tif (cascade_irq != NO_IRQ)\n+\tif (cascade_irq)\n \t\tgeneric_handle_irq(cascade_irq);\n\n \tchip->irq_eoi(&desc->irq_data);\n@@ -514,7 +514,7 @@ static void __init chrp_find_8259(void)\n \t}\n \tif (chrp_mpic != NULL) {\n \t\tcascade_irq = irq_of_parse_and_map(pic, 0);\n-\t\tif (cascade_irq == NO_IRQ)\n+\t\tif (!cascade_irq)\n \t\t\tprintk(KERN_ERR \"i8259: failed to map cascade irq\\n\");\n \t\telse\n \t\t\tirq_set_chained_handler(cascade_irq,\ndiff -u -p a/arch/powerpc/platforms/maple/pci.c b/arch/powerpc/platforms/maple/pci.c\n--- a/arch/powerpc/platforms/maple/pci.c\n+++ b/arch/powerpc/platforms/maple/pci.c\n@@ -552,7 +552,7 @@ void maple_pci_irq_fixup(struct pci_dev\n \t    pci_bus_to_host(dev->bus) == u4_pcie) {\n \t\tprintk(KERN_DEBUG \"Fixup U4 PCIe IRQ\\n\");\n \t\tdev->irq = irq_create_mapping(NULL, 1);\n-\t\tif (dev->irq != NO_IRQ)\n+\t\tif (dev->irq)\n \t\t\tirq_set_irq_type(dev->irq, IRQ_TYPE_LEVEL_LOW);\n \t}\n\n@@ -562,7 +562,7 @@ void maple_pci_irq_fixup(struct pci_dev\n \tif (dev->vendor == PCI_VENDOR_ID_AMD &&\n \t    dev->device == PCI_DEVICE_ID_AMD_8111_IDE &&\n \t    (dev->class & 5) != 5) {\n-\t\tdev->irq = NO_IRQ;\n+\t\tdev->irq = 0;\n \t}\n\n \tDBG(\" <- maple_pci_irq_fixup\\n\");\n@@ -648,7 +648,7 @@ int maple_pci_get_legacy_ide_irq(struct\n \t\treturn defirq;\n \t}\n \tirq = irq_of_parse_and_map(np, channel & 0x1);\n-\tif (irq == NO_IRQ) {\n+\tif (!irq) {\n \t\tprintk(\"Failed to map onboard IDE interrupt for channel %d\\n\",\n \t\t       channel);\n \t\treturn defirq;\ndiff -u -p a/arch/powerpc/platforms/embedded6xx/flipper-pic.c b/arch/powerpc/platforms/embedded6xx/flipper-pic.c\n--- a/arch/powerpc/platforms/embedded6xx/flipper-pic.c\n+++ b/arch/powerpc/platforms/embedded6xx/flipper-pic.c\n@@ -181,7 +181,7 @@ unsigned int flipper_pic_get_irq(void)\n \tirq_status = in_be32(io_base + FLIPPER_ICR) &\n \t\t     in_be32(io_base + FLIPPER_IMR);\n \tif (irq_status == 0)\n-\t\treturn NO_IRQ;\t/* no more IRQs pending */\n+\t\treturn 0;\t/* no more IRQs pending */\n\n \tirq = __ffs(irq_status);\n \treturn irq_linear_revmap(flipper_irq_host, irq);\ndiff -u -p a/arch/powerpc/platforms/embedded6xx/hlwd-pic.c b/arch/powerpc/platforms/embedded6xx/hlwd-pic.c\n--- a/arch/powerpc/platforms/embedded6xx/hlwd-pic.c\n+++ b/arch/powerpc/platforms/embedded6xx/hlwd-pic.c\n@@ -114,7 +114,7 @@ static unsigned int __hlwd_pic_get_irq(s\n \tirq_status = in_be32(io_base + HW_BROADWAY_ICR) &\n \t\t     in_be32(io_base + HW_BROADWAY_IMR);\n \tif (irq_status == 0)\n-\t\treturn NO_IRQ;\t/* no more IRQs pending */\n+\t\treturn 0;\t/* no more IRQs pending */\n\n \tirq = __ffs(irq_status);\n \treturn irq_linear_revmap(h, irq);\n@@ -131,7 +131,7 @@ static void hlwd_pic_irq_cascade(struct\n \traw_spin_unlock(&desc->lock);\n\n \tvirq = __hlwd_pic_get_irq(irq_domain);\n-\tif (virq != NO_IRQ)\n+\tif (virq)\n \t\tgeneric_handle_irq(virq);\n \telse\n \t\tpr_err(\"spurious interrupt!\\n\");\ndiff -u -p a/arch/powerpc/platforms/embedded6xx/mvme5100.c b/arch/powerpc/platforms/embedded6xx/mvme5100.c\n--- a/arch/powerpc/platforms/embedded6xx/mvme5100.c\n+++ b/arch/powerpc/platforms/embedded6xx/mvme5100.c\n@@ -47,7 +47,7 @@ static void mvme5100_8259_cascade(struct\n \tstruct irq_chip *chip = irq_desc_get_chip(desc);\n \tunsigned int cascade_irq = i8259_irq();\n\n-\tif (cascade_irq != NO_IRQ)\n+\tif (cascade_irq)\n \t\tgeneric_handle_irq(cascade_irq);\n\n \tchip->irq_eoi(&desc->irq_data);\n@@ -84,7 +84,7 @@ static void __init mvme5100_pic_init(voi\n \t}\n\n \tcirq = irq_of_parse_and_map(cp, 0);\n-\tif (cirq == NO_IRQ) {\n+\tif (!cirq) {\n \t\tpr_warn(\"mvme5100_pic_init: no cascade interrupt?\\n\");\n \t\treturn;\n \t}\ndiff -u -p a/arch/powerpc/platforms/pasemi/misc.c b/arch/powerpc/platforms/pasemi/misc.c\n--- a/arch/powerpc/platforms/pasemi/misc.c\n+++ b/arch/powerpc/platforms/pasemi/misc.c\n@@ -76,7 +76,7 @@ static int __init pasemi_register_i2c_de\n \t\t\t}\n\n \t\t\tinfo.irq = irq_of_parse_and_map(node, 0);\n-\t\t\tif (info.irq == NO_IRQ)\n+\t\t\tif (!info.irq)\n \t\t\t\tinfo.irq = -1;\n\n \t\t\tif (find_i2c_driver(node, &info) < 0)\ndiff -u -p a/arch/powerpc/platforms/pasemi/msi.c b/arch/powerpc/platforms/pasemi/msi.c\n--- a/arch/powerpc/platforms/pasemi/msi.c\n+++ b/arch/powerpc/platforms/pasemi/msi.c\n@@ -68,7 +68,7 @@ static void pasemi_msi_teardown_msi_irqs\n \tpr_debug(\"pasemi_msi_teardown_msi_irqs, pdev %p\\n\", pdev);\n\n \tfor_each_pci_msi_entry(entry, pdev) {\n-\t\tif (entry->irq == NO_IRQ)\n+\t\tif (!entry->irq)\n \t\t\tcontinue;\n\n \t\thwirq = virq_to_hw(entry->irq);\n@@ -109,7 +109,7 @@ static int pasemi_msi_setup_msi_irqs(str\n \t\t}\n\n \t\tvirq = irq_create_mapping(msi_mpic->irqhost, hwirq);\n-\t\tif (virq == NO_IRQ) {\n+\t\tif (!virq) {\n \t\t\tpr_debug(\"pasemi_msi: failed mapping hwirq 0x%x\\n\",\n \t\t\t\t  hwirq);\n \t\t\tmsi_bitmap_free_hwirqs(&msi_mpic->msi_bitmap, hwirq,\ndiff -u -p a/arch/powerpc/platforms/pasemi/setup.c b/arch/powerpc/platforms/pasemi/setup.c\n--- a/arch/powerpc/platforms/pasemi/setup.c\n+++ b/arch/powerpc/platforms/pasemi/setup.c\n@@ -59,7 +59,7 @@ struct mce_regs {\n\n static struct mce_regs mce_regs[MAX_MCE_REGS];\n static int num_mce_regs;\n-static int nmi_virq = NO_IRQ;\n+static int nmi_virq = 0;\n\n\n static void __noreturn pas_restart(char *cmd)\n@@ -264,7 +264,7 @@ static int pas_machine_check_handler(str\n \tsrr0 = regs->nip;\n \tsrr1 = regs->msr;\n\n-\tif (nmi_virq != NO_IRQ && mpic_get_mcirq() == nmi_virq) {\n+\tif (nmi_virq && mpic_get_mcirq() == nmi_virq) {\n \t\tprintk(KERN_ERR \"NMI delivered\\n\");\n \t\tdebugger(regs);\n \t\tmpic_end_irq(irq_get_irq_data(nmi_virq));\ndiff -u -p a/arch/powerpc/platforms/85xx/common.c b/arch/powerpc/platforms/85xx/common.c\n--- a/arch/powerpc/platforms/85xx/common.c\n+++ b/arch/powerpc/platforms/85xx/common.c\n@@ -76,7 +76,7 @@ void __init mpc85xx_cpm2_pic_init(void)\n \t\treturn;\n \t}\n \tirq = irq_of_parse_and_map(np, 0);\n-\tif (irq == NO_IRQ) {\n+\tif (!irq) {\n \t\tof_node_put(np);\n \t\tprintk(KERN_ERR \"PIC init: got no IRQ for cpm cascade\\n\");\n \t\treturn;\ndiff -u -p a/arch/powerpc/platforms/85xx/socrates_fpga_pic.c b/arch/powerpc/platforms/85xx/socrates_fpga_pic.c\n--- a/arch/powerpc/platforms/85xx/socrates_fpga_pic.c\n+++ b/arch/powerpc/platforms/85xx/socrates_fpga_pic.c\n@@ -78,7 +78,7 @@ static inline unsigned int socrates_fpga\n \t\t\tbreak;\n \t}\n \tif (i == 3)\n-\t\treturn NO_IRQ;\n+\t\treturn 0;\n\n \traw_spin_lock_irqsave(&socrates_fpga_pic_lock, flags);\n \tcause = socrates_fpga_pic_read(FPGA_PIC_IRQMASK(i));\n@@ -103,7 +103,7 @@ static void socrates_fpga_pic_cascade(st\n \t */\n \tcascade_irq = socrates_fpga_pic_get_irq(irq);\n\n-\tif (cascade_irq != NO_IRQ)\n+\tif (cascade_irq)\n \t\tgeneric_handle_irq(cascade_irq);\n \tchip->irq_eoi(&desc->irq_data);\n }\n@@ -292,7 +292,7 @@ void socrates_fpga_pic_init(struct devic\n\n \tfor (i = 0; i < 3; i++) {\n \t\tsocrates_fpga_irqs[i] = irq_of_parse_and_map(pic, i);\n-\t\tif (socrates_fpga_irqs[i] == NO_IRQ) {\n+\t\tif (!socrates_fpga_irqs[i]) {\n \t\t\tpr_warning(\"FPGA PIC: can't get irq%d.\\n\", i);\n \t\t\tcontinue;\n \t\t}\ndiff -u -p a/arch/powerpc/platforms/85xx/mpc85xx_cds.c b/arch/powerpc/platforms/85xx/mpc85xx_cds.c\n--- a/arch/powerpc/platforms/85xx/mpc85xx_cds.c\n+++ b/arch/powerpc/platforms/85xx/mpc85xx_cds.c\n@@ -196,7 +196,7 @@ static void mpc85xx_8259_cascade_handler\n {\n \tunsigned int cascade_irq = i8259_irq();\n\n-\tif (cascade_irq != NO_IRQ)\n+\tif (cascade_irq)\n \t\t/* handle an interrupt from the 8259 */\n \t\tgeneric_handle_irq(cascade_irq);\n\n@@ -247,7 +247,7 @@ static int mpc85xx_cds_8259_attach(void)\n \t}\n\n \tcascade_irq = irq_of_parse_and_map(cascade_node, 0);\n-\tif (cascade_irq == NO_IRQ) {\n+\tif (!cascade_irq) {\n \t\tprintk(KERN_ERR \"Failed to map cascade interrupt\\n\");\n \t\treturn -ENXIO;\n \t}\ndiff -u -p a/arch/powerpc/platforms/85xx/mpc85xx_ds.c b/arch/powerpc/platforms/85xx/mpc85xx_ds.c\n--- a/arch/powerpc/platforms/85xx/mpc85xx_ds.c\n+++ b/arch/powerpc/platforms/85xx/mpc85xx_ds.c\n@@ -51,7 +51,7 @@ static void mpc85xx_8259_cascade(struct\n \tstruct irq_chip *chip = irq_desc_get_chip(desc);\n \tunsigned int cascade_irq = i8259_irq();\n\n-\tif (cascade_irq != NO_IRQ) {\n+\tif (cascade_irq) {\n \t\tgeneric_handle_irq(cascade_irq);\n \t}\n \tchip->irq_eoi(&desc->irq_data);\n@@ -96,7 +96,7 @@ void __init mpc85xx_ds_pic_init(void)\n \t}\n\n \tcascade_irq = irq_of_parse_and_map(cascade_node, 0);\n-\tif (cascade_irq == NO_IRQ) {\n+\tif (!cascade_irq) {\n \t\tprintk(KERN_ERR \"Failed to map cascade interrupt\\n\");\n \t\treturn;\n \t}\ndiff -u -p a/arch/powerpc/platforms/83xx/suspend.c b/arch/powerpc/platforms/83xx/suspend.c\n--- a/arch/powerpc/platforms/83xx/suspend.c\n+++ b/arch/powerpc/platforms/83xx/suspend.c\n@@ -352,7 +352,7 @@ static int pmc_probe(struct platform_dev\n \t\treturn -ENODEV;\n\n \tpmc_irq = irq_of_parse_and_map(np, 0);\n-\tif (pmc_irq != NO_IRQ) {\n+\tif (pmc_irq) {\n \t\tret = request_irq(pmc_irq, pmc_irq_handler, IRQF_SHARED,\n \t\t                  \"pmc\", ofdev);\n\n@@ -400,7 +400,7 @@ out_syscr:\n out_pmc:\n \tiounmap(pmc_regs);\n out:\n-\tif (pmc_irq != NO_IRQ)\n+\tif (pmc_irq)\n \t\tfree_irq(pmc_irq, ofdev);\n\n \treturn ret;\ndiff -u -p a/arch/powerpc/platforms/83xx/mpc832x_rdb.c b/arch/powerpc/platforms/83xx/mpc832x_rdb.c\n--- a/arch/powerpc/platforms/83xx/mpc832x_rdb.c\n+++ b/arch/powerpc/platforms/83xx/mpc832x_rdb.c\n@@ -89,7 +89,7 @@ static int __init of_fsl_spi_probe(char\n \t\t\tgoto err;\n\n \t\tret = of_irq_to_resource(np, 0, &res[1]);\n-\t\tif (ret == NO_IRQ)\n+\t\tif (!ret)\n \t\t\tgoto err;\n\n \t\tpdev = platform_device_alloc(\"mpc83xx_spi\", i);\ndiff -u -p a/arch/powerpc/platforms/44x/warp.c b/arch/powerpc/platforms/44x/warp.c\n--- a/arch/powerpc/platforms/44x/warp.c\n+++ b/arch/powerpc/platforms/44x/warp.c\n@@ -204,7 +204,7 @@ static void pika_setup_critical_temp(str\n \ti2c_smbus_write_byte_data(client, 3,  0); /* Tlow */\n\n \tirq = irq_of_parse_and_map(np, 0);\n-\tif (irq  == NO_IRQ) {\n+\tif (!irq) {\n \t\tprintk(KERN_ERR __FILE__ \": Unable to get ad7414 irq\\n\");\n \t\treturn;\n \t}\ndiff -u -p a/arch/powerpc/platforms/86xx/pic.c b/arch/powerpc/platforms/86xx/pic.c\n--- a/arch/powerpc/platforms/86xx/pic.c\n+++ b/arch/powerpc/platforms/86xx/pic.c\n@@ -22,7 +22,7 @@ static void mpc86xx_8259_cascade(struct\n \tstruct irq_chip *chip = irq_desc_get_chip(desc);\n \tunsigned int cascade_irq = i8259_irq();\n\n-\tif (cascade_irq != NO_IRQ)\n+\tif (cascade_irq)\n \t\tgeneric_handle_irq(cascade_irq);\n\n \tchip->irq_eoi(&desc->irq_data);\n@@ -58,7 +58,7 @@ void __init mpc86xx_init_irq(void)\n \t}\n\n \tcascade_irq = irq_of_parse_and_map(cascade_node, 0);\n-\tif (cascade_irq == NO_IRQ) {\n+\tif (!cascade_irq) {\n \t\tprintk(KERN_ERR \"Failed to map cascade interrupt\\n\");\n \t\treturn;\n \t}\ndiff -u -p a/arch/powerpc/platforms/pseries/msi.c b/arch/powerpc/platforms/pseries/msi.c\n--- a/arch/powerpc/platforms/pseries/msi.c\n+++ b/arch/powerpc/platforms/pseries/msi.c\n@@ -119,7 +119,7 @@ static void rtas_teardown_msi_irqs(struc\n \tstruct msi_desc *entry;\n\n \tfor_each_pci_msi_entry(entry, pdev) {\n-\t\tif (entry->irq == NO_IRQ)\n+\t\tif (!entry->irq)\n \t\t\tcontinue;\n\n \t\tirq_set_msi_desc(entry->irq, NULL);\n@@ -471,7 +471,7 @@ again:\n\n \t\tvirq = irq_create_mapping(NULL, hwirq);\n\n-\t\tif (virq == NO_IRQ) {\n+\t\tif (!virq) {\n \t\t\tpr_debug(\"rtas_msi: Failed mapping hwirq %d\\n\", hwirq);\n \t\t\treturn -ENOSPC;\n \t\t}\n@@ -490,7 +490,7 @@ again:\n static void rtas_msi_pci_irq_fixup(struct pci_dev *pdev)\n {\n \t/* No LSI -> leave MSIs (if any) configured */\n-\tif (pdev->irq == NO_IRQ) {\n+\tif (!pdev->irq) {\n \t\tdev_dbg(&pdev->dev, \"rtas_msi: no LSI, nothing to do.\\n\");\n \t\treturn;\n \t}\ndiff -u -p a/arch/powerpc/platforms/pseries/event_sources.c b/arch/powerpc/platforms/pseries/event_sources.c\n--- a/arch/powerpc/platforms/pseries/event_sources.c\n+++ b/arch/powerpc/platforms/pseries/event_sources.c\n@@ -34,7 +34,7 @@ void request_event_sources_irqs(struct d\n \t\tif (count > 15)\n \t\t\tbreak;\n \t\tvirqs[count] = irq_create_of_mapping(&oirq);\n-\t\tif (virqs[count] == NO_IRQ) {\n+\t\tif (!virqs[count]) {\n \t\t\tpr_err(\"event-sources: Unable to allocate \"\n \t\t\t       \"interrupt number for %s\\n\",\n \t\t\t       np->full_name);\ndiff -u -p a/arch/powerpc/platforms/pseries/setup.c b/arch/powerpc/platforms/pseries/setup.c\n--- a/arch/powerpc/platforms/pseries/setup.c\n+++ b/arch/powerpc/platforms/pseries/setup.c\n@@ -114,7 +114,7 @@ static void pseries_8259_cascade(struct\n \tstruct irq_chip *chip = irq_desc_get_chip(desc);\n \tunsigned int cascade_irq = i8259_irq();\n\n-\tif (cascade_irq != NO_IRQ)\n+\tif (cascade_irq)\n \t\tgeneric_handle_irq(cascade_irq);\n\n \tchip->irq_eoi(&desc->irq_data);\n@@ -141,7 +141,7 @@ static void __init pseries_setup_i8259_c\n \t}\n\n \tcascade = irq_of_parse_and_map(found, 0);\n-\tif (cascade == NO_IRQ) {\n+\tif (!cascade) {\n \t\tprintk(KERN_ERR \"pic: failed to map cascade interrupt\");\n \t\treturn;\n \t}\ndiff -u -p a/arch/powerpc/platforms/ps3/interrupt.c b/arch/powerpc/platforms/ps3/interrupt.c\n--- a/arch/powerpc/platforms/ps3/interrupt.c\n+++ b/arch/powerpc/platforms/ps3/interrupt.c\n@@ -192,7 +192,7 @@ static int ps3_virq_setup(enum ps3_cpu_b\n\n \t*virq = irq_create_mapping(NULL, outlet);\n\n-\tif (*virq == NO_IRQ) {\n+\tif (!*virq) {\n \t\tFAIL(\"%s:%d: irq_create_mapping failed: outlet %lu\\n\",\n \t\t\t__func__, __LINE__, outlet);\n \t\tresult = -ENOMEM;\n@@ -339,7 +339,7 @@ int ps3_event_receive_port_setup(enum ps\n \tif (result) {\n \t\tFAIL(\"%s:%d: lv1_construct_event_receive_port failed: %s\\n\",\n \t\t\t__func__, __LINE__, ps3_result(result));\n-\t\t*virq = NO_IRQ;\n+\t\t*virq = 0;\n \t\treturn result;\n \t}\n\n@@ -418,7 +418,7 @@ int ps3_sb_event_receive_port_setup(stru\n \t\t\t\" failed: %s\\n\", __func__, __LINE__,\n \t\t\tps3_result(result));\n \t\tps3_event_receive_port_destroy(*virq);\n-\t\t*virq = NO_IRQ;\n+\t\t*virq = 0;\n \t\treturn result;\n \t}\n\n@@ -724,12 +724,12 @@ static unsigned int ps3_get_irq(void)\n \tasm volatile(\"cntlzd %0,%1\" : \"=r\" (plug) : \"r\" (x));\n \tplug &= 0x3f;\n\n-\tif (unlikely(plug == NO_IRQ)) {\n+\tif (unlikely(!plug)) {\n \t\tDBG(\"%s:%d: no plug found: thread_id %llu\\n\", __func__,\n \t\t\t__LINE__, pd->thread_id);\n \t\tdump_bmp(&per_cpu(ps3_private, 0));\n \t\tdump_bmp(&per_cpu(ps3_private, 1));\n-\t\treturn NO_IRQ;\n+\t\treturn 0;\n \t}\n\n #if defined(DEBUG)\ndiff -u -p a/arch/powerpc/platforms/ps3/smp.c b/arch/powerpc/platforms/ps3/smp.c\n--- a/arch/powerpc/platforms/ps3/smp.c\n+++ b/arch/powerpc/platforms/ps3/smp.c\n@@ -91,7 +91,7 @@ static void __init ps3_smp_probe(void)\n \t\t\tresult = smp_request_message_ipi(virqs[i], i);\n\n \t\t\tif (result)\n-\t\t\t\tvirqs[i] = NO_IRQ;\n+\t\t\t\tvirqs[i] = 0;\n \t\t\telse\n \t\t\t\tps3_register_ipi_irq(cpu, virqs[i]);\n \t\t}\n@@ -112,7 +112,7 @@ void ps3_smp_cleanup_cpu(int cpu)\n \tfor (i = 0; i < MSG_COUNT; i++) {\n \t\t/* Can't call free_irq from interrupt context. */\n \t\tps3_event_receive_port_destroy(virqs[i]);\n-\t\tvirqs[i] = NO_IRQ;\n+\t\tvirqs[i] = 0;\n \t}\n\n \tDBG(\" <- %s:%d: (%d)\\n\", __func__, __LINE__, cpu);\ndiff -u -p a/arch/powerpc/platforms/ps3/spu.c b/arch/powerpc/platforms/ps3/spu.c\n--- a/arch/powerpc/platforms/ps3/spu.c\n+++ b/arch/powerpc/platforms/ps3/spu.c\n@@ -284,7 +284,7 @@ fail_alloc_2:\n fail_alloc_1:\n \tps3_spe_irq_destroy(spu->irqs[0]);\n fail_alloc_0:\n-\tspu->irqs[0] = spu->irqs[1] = spu->irqs[2] = NO_IRQ;\n+\tspu->irqs[0] = spu->irqs[1] = spu->irqs[2] = 0;\n \treturn result;\n }\n\n@@ -334,7 +334,7 @@ static int ps3_destroy_spu(struct spu *s\n \tps3_spe_irq_destroy(spu->irqs[1]);\n \tps3_spe_irq_destroy(spu->irqs[0]);\n\n-\tspu->irqs[0] = spu->irqs[1] = spu->irqs[2] = NO_IRQ;\n+\tspu->irqs[0] = spu->irqs[1] = spu->irqs[2] = 0;\n\n \tspu_unmap(spu);\n\ndiff -u -p a/arch/powerpc/platforms/powermac/pic.c b/arch/powerpc/platforms/powermac/pic.c\n--- a/arch/powerpc/platforms/powermac/pic.c\n+++ b/arch/powerpc/platforms/powermac/pic.c\n@@ -251,7 +251,7 @@ static unsigned int pmac_pic_get_irq(voi\n \t}\n \traw_spin_unlock_irqrestore(&pmac_pic_lock, flags);\n \tif (unlikely(irq < 0))\n-\t\treturn NO_IRQ;\n+\t\treturn 0;\n \treturn irq_linear_revmap(pmac_pic_host, irq);\n }\n\n@@ -389,7 +389,7 @@ static void __init pmac_pic_probe_oldsty\n \t\tout_le32(&pmac_irq_hw[i]->enable, 0);\n\n \t/* Hookup cascade irq */\n-\tif (slave && pmac_irq_cascade != NO_IRQ)\n+\tif (slave && pmac_irq_cascade)\n \t\tsetup_irq(pmac_irq_cascade, &gatwick_cascade_action);\n\n \tprintk(KERN_INFO \"irq: System has %d possible interrupts\\n\", max_irqs);\n@@ -444,7 +444,7 @@ static void __init pmac_pic_setup_mpic_n\n \tpswitch = of_find_node_by_name(NULL, \"programmer-switch\");\n \tif (pswitch) {\n \t\tnmi_irq = irq_of_parse_and_map(pswitch, 0);\n-\t\tif (nmi_irq != NO_IRQ) {\n+\t\tif (nmi_irq) {\n \t\t\tmpic_irq_set_priority(nmi_irq, 9);\n \t\t\tsetup_irq(nmi_irq, &xmon_action);\n \t\t}\ndiff -u -p a/arch/powerpc/platforms/powermac/low_i2c.c b/arch/powerpc/platforms/powermac/low_i2c.c\n--- a/arch/powerpc/platforms/powermac/low_i2c.c\n+++ b/arch/powerpc/platforms/powermac/low_i2c.c\n@@ -401,7 +401,7 @@ static int kw_i2c_xfer(struct pmac_i2c_b\n {\n \tstruct pmac_i2c_host_kw *host = bus->hostdata;\n \tu8 mode_reg = host->speed;\n-\tint use_irq = host->irq != NO_IRQ && !bus->polled;\n+\tint use_irq = host->irq && !bus->polled;\n\n \t/* Setup mode & subaddress if any */\n \tswitch(bus->mode) {\n@@ -535,7 +535,7 @@ static struct pmac_i2c_host_kw *__init k\n \t\tbreak;\n \t}\n \thost->irq = irq_of_parse_and_map(np, 0);\n-\tif (host->irq == NO_IRQ)\n+\tif (!host->irq)\n \t\tprintk(KERN_WARNING\n \t\t       \"low_i2c: Failed to map interrupt for %s\\n\",\n \t\t       np->full_name);\n@@ -557,7 +557,7 @@ static struct pmac_i2c_host_kw *__init k\n \t */\n \tif (request_irq(host->irq, kw_i2c_irq, IRQF_NO_SUSPEND,\n \t\t\t\"keywest i2c\", host))\n-\t\thost->irq = NO_IRQ;\n+\t\thost->irq = 0;\n\n \tprintk(KERN_INFO \"KeyWest i2c @0x%08x irq %d %s\\n\",\n \t       *addrp, host->irq, np->full_name);\ndiff -u -p a/arch/powerpc/platforms/powermac/pfunc_base.c b/arch/powerpc/platforms/powermac/pfunc_base.c\n--- a/arch/powerpc/platforms/powermac/pfunc_base.c\n+++ b/arch/powerpc/platforms/powermac/pfunc_base.c\n@@ -26,7 +26,7 @@ static irqreturn_t macio_gpio_irq(int ir\n static int macio_do_gpio_irq_enable(struct pmf_function *func)\n {\n \tunsigned int irq = irq_of_parse_and_map(func->node, 0);\n-\tif (irq == NO_IRQ)\n+\tif (!irq)\n \t\treturn -EINVAL;\n \treturn request_irq(irq, macio_gpio_irq, 0, func->node->name, func);\n }\n@@ -34,7 +34,7 @@ static int macio_do_gpio_irq_enable(stru\n static int macio_do_gpio_irq_disable(struct pmf_function *func)\n {\n \tunsigned int irq = irq_of_parse_and_map(func->node, 0);\n-\tif (irq == NO_IRQ)\n+\tif (!irq)\n \t\treturn -EINVAL;\n \tfree_irq(irq, func);\n \treturn 0;\ndiff -u -p a/arch/powerpc/platforms/512x/mpc5121_ads_cpld.c b/arch/powerpc/platforms/512x/mpc5121_ads_cpld.c\n--- a/arch/powerpc/platforms/512x/mpc5121_ads_cpld.c\n+++ b/arch/powerpc/platforms/512x/mpc5121_ads_cpld.c\n@@ -97,7 +97,7 @@ cpld_pic_get_irq(int offset, u8 ignore,\n \tstatus |= (ignore | mask);\n\n \tif (status == 0xff)\n-\t\treturn NO_IRQ;\n+\t\treturn 0;\n\n \tcpld_irq = ffz(status) + offset;\n\n@@ -110,14 +110,14 @@ static void cpld_pic_cascade(struct irq_\n\n \tirq = cpld_pic_get_irq(0, PCI_IGNORE, &cpld_regs->pci_status,\n \t\t&cpld_regs->pci_mask);\n-\tif (irq != NO_IRQ) {\n+\tif (irq) {\n \t\tgeneric_handle_irq(irq);\n \t\treturn;\n \t}\n\n \tirq = cpld_pic_get_irq(8, MISC_IGNORE, &cpld_regs->misc_status,\n \t\t&cpld_regs->misc_mask);\n-\tif (irq != NO_IRQ) {\n+\tif (irq) {\n \t\tgeneric_handle_irq(irq);\n \t\treturn;\n \t}\n@@ -177,7 +177,7 @@ mpc5121_ads_cpld_pic_init(void)\n \t\tgoto end;\n\n \tcascade_irq = irq_of_parse_and_map(np, 0);\n-\tif (cascade_irq == NO_IRQ)\n+\tif (!cascade_irq)\n \t\tgoto end;\n\n \t/*\ndiff -u -p a/arch/powerpc/platforms/512x/mpc512x_lpbfifo.c b/arch/powerpc/platforms/512x/mpc512x_lpbfifo.c\n--- a/arch/powerpc/platforms/512x/mpc512x_lpbfifo.c\n+++ b/arch/powerpc/platforms/512x/mpc512x_lpbfifo.c\n@@ -473,7 +473,7 @@ static int mpc512x_lpbfifo_probe(struct\n \t}\n\n \tlpbfifo.irq = irq_of_parse_and_map(pdev->dev.of_node, 0);\n-\tif (lpbfifo.irq == NO_IRQ) {\n+\tif (!lpbfifo.irq) {\n \t\tdev_err(&pdev->dev, \"mapping irq failed\\n\");\n \t\tret = -ENODEV;\n \t\tgoto err0;\ndiff -u -p a/arch/powerpc/platforms/8xx/m8xx_setup.c b/arch/powerpc/platforms/8xx/m8xx_setup.c\n--- a/arch/powerpc/platforms/8xx/m8xx_setup.c\n+++ b/arch/powerpc/platforms/8xx/m8xx_setup.c\n@@ -241,6 +241,6 @@ void __init mpc8xx_pics_init(void)\n \t}\n\n \tirq = cpm_pic_init();\n-\tif (irq != NO_IRQ)\n+\tif (irq)\n \t\tirq_set_chained_handler(irq, cpm_cascade);\n }\ndiff -u -p a/arch/powerpc/platforms/82xx/pq2ads-pci-pic.c b/arch/powerpc/platforms/82xx/pq2ads-pci-pic.c\n--- a/arch/powerpc/platforms/82xx/pq2ads-pci-pic.c\n+++ b/arch/powerpc/platforms/82xx/pq2ads-pci-pic.c\n@@ -131,7 +131,7 @@ int __init pq2ads_pci_init_irq(void)\n \t}\n\n \tirq = irq_of_parse_and_map(np, 0);\n-\tif (irq == NO_IRQ) {\n+\tif (!irq) {\n \t\tprintk(KERN_ERR \"No interrupt in pci pic node.\\n\");\n \t\tof_node_put(np);\n \t\tgoto out;\ndiff -u -p a/arch/powerpc/platforms/cell/spu_base.c b/arch/powerpc/platforms/cell/spu_base.c\n--- a/arch/powerpc/platforms/cell/spu_base.c\n+++ b/arch/powerpc/platforms/cell/spu_base.c\n@@ -402,7 +402,7 @@ static int spu_request_irqs(struct spu *\n {\n \tint ret = 0;\n\n-\tif (spu->irqs[0] != NO_IRQ) {\n+\tif (spu->irqs[0]) {\n \t\tsnprintf(spu->irq_c0, sizeof (spu->irq_c0), \"spe%02d.0\",\n \t\t\t spu->number);\n \t\tret = request_irq(spu->irqs[0], spu_irq_class_0,\n@@ -410,7 +410,7 @@ static int spu_request_irqs(struct spu *\n \t\tif (ret)\n \t\t\tgoto bail0;\n \t}\n-\tif (spu->irqs[1] != NO_IRQ) {\n+\tif (spu->irqs[1]) {\n \t\tsnprintf(spu->irq_c1, sizeof (spu->irq_c1), \"spe%02d.1\",\n \t\t\t spu->number);\n \t\tret = request_irq(spu->irqs[1], spu_irq_class_1,\n@@ -418,7 +418,7 @@ static int spu_request_irqs(struct spu *\n \t\tif (ret)\n \t\t\tgoto bail1;\n \t}\n-\tif (spu->irqs[2] != NO_IRQ) {\n+\tif (spu->irqs[2]) {\n \t\tsnprintf(spu->irq_c2, sizeof (spu->irq_c2), \"spe%02d.2\",\n \t\t\t spu->number);\n \t\tret = request_irq(spu->irqs[2], spu_irq_class_2,\n@@ -429,10 +429,10 @@ static int spu_request_irqs(struct spu *\n \treturn 0;\n\n bail2:\n-\tif (spu->irqs[1] != NO_IRQ)\n+\tif (spu->irqs[1])\n \t\tfree_irq(spu->irqs[1], spu);\n bail1:\n-\tif (spu->irqs[0] != NO_IRQ)\n+\tif (spu->irqs[0])\n \t\tfree_irq(spu->irqs[0], spu);\n bail0:\n \treturn ret;\n@@ -440,11 +440,11 @@ bail0:\n\n static void spu_free_irqs(struct spu *spu)\n {\n-\tif (spu->irqs[0] != NO_IRQ)\n+\tif (spu->irqs[0])\n \t\tfree_irq(spu->irqs[0], spu);\n-\tif (spu->irqs[1] != NO_IRQ)\n+\tif (spu->irqs[1])\n \t\tfree_irq(spu->irqs[1], spu);\n-\tif (spu->irqs[2] != NO_IRQ)\n+\tif (spu->irqs[2])\n \t\tfree_irq(spu->irqs[2], spu);\n }\n\ndiff -u -p a/arch/powerpc/platforms/cell/interrupt.c b/arch/powerpc/platforms/cell/interrupt.c\n--- a/arch/powerpc/platforms/cell/interrupt.c\n+++ b/arch/powerpc/platforms/cell/interrupt.c\n@@ -123,7 +123,7 @@ static void iic_ioexc_cascade(struct irq\n \t\t\t\tunsigned int cirq =\n \t\t\t\t\tirq_linear_revmap(iic_host,\n \t\t\t\t\t\t\t  base | cascade);\n-\t\t\t\tif (cirq != NO_IRQ)\n+\t\t\t\tif (cirq)\n \t\t\t\t\tgeneric_handle_irq(cirq);\n \t\t\t}\n \t\t/* post-ack level interrupts */\n@@ -153,10 +153,10 @@ static unsigned int iic_get_irq(void)\n \t*(unsigned long *) &pending =\n \t\tin_be64((u64 __iomem *) &iic->regs->pending_destr);\n \tif (!(pending.flags & CBE_IIC_IRQ_VALID))\n-\t\treturn NO_IRQ;\n+\t\treturn 0;\n \tvirq = irq_linear_revmap(iic_host, iic_pending_to_hwnum(pending));\n-\tif (virq == NO_IRQ)\n-\t\treturn NO_IRQ;\n+\tif (!virq)\n+\t\treturn 0;\n \tiic->eoi_stack[++iic->eoi_ptr] = pending.prio;\n \tBUG_ON(iic->eoi_ptr > 15);\n \treturn virq;\n@@ -198,7 +198,7 @@ static void iic_request_ipi(int msg)\n \tint virq;\n\n \tvirq = irq_create_mapping(iic_host, iic_msg_to_irq(msg));\n-\tif (virq == NO_IRQ) {\n+\tif (!virq) {\n \t\tprintk(KERN_ERR\n \t\t       \"iic: failed to map IPI %s\\n\", smp_ipi_name[msg]);\n \t\treturn;\n@@ -353,7 +353,7 @@ static int __init setup_iic(void)\n \t\tcascade |= 1 << IIC_IRQ_CLASS_SHIFT;\n \t\tcascade |= IIC_UNIT_IIC;\n \t\tcascade = irq_create_mapping(iic_host, cascade);\n-\t\tif (cascade == NO_IRQ)\n+\t\tif (!cascade)\n \t\t\tcontinue;\n \t\t/*\n \t\t * irq_data is a generic pointer that gets passed back\ndiff -u -p a/arch/powerpc/platforms/cell/pmu.c b/arch/powerpc/platforms/cell/pmu.c\n--- a/arch/powerpc/platforms/cell/pmu.c\n+++ b/arch/powerpc/platforms/cell/pmu.c\n@@ -385,7 +385,7 @@ static int __init cbe_init_pm_irq(void)\n \tfor_each_online_node(node) {\n \t\tirq = irq_create_mapping(NULL, IIC_IRQ_IOEX_PMI |\n \t\t\t\t\t       (node << IIC_IRQ_NODE_SHIFT));\n-\t\tif (irq == NO_IRQ) {\n+\t\tif (!irq) {\n \t\t\tprintk(\"ERROR: Unable to allocate irq for node %d\\n\",\n \t\t\t       node);\n \t\t\treturn -EINVAL;\n@@ -412,7 +412,7 @@ void cbe_sync_irq(int node)\n \t\t\t       IIC_IRQ_IOEX_PMI\n \t\t\t       | (node << IIC_IRQ_NODE_SHIFT));\n\n-\tif (irq == NO_IRQ) {\n+\tif (!irq) {\n \t\tprintk(KERN_WARNING \"ERROR, unable to get existing irq %d \" \\\n \t\t\"for node %d\\n\", irq, node);\n \t\treturn;\ndiff -u -p a/arch/powerpc/platforms/cell/spider-pic.c b/arch/powerpc/platforms/cell/spider-pic.c\n--- a/arch/powerpc/platforms/cell/spider-pic.c\n+++ b/arch/powerpc/platforms/cell/spider-pic.c\n@@ -207,11 +207,11 @@ static void spider_irq_cascade(struct ir\n\n \tcs = in_be32(pic->regs + TIR_CS) >> 24;\n \tif (cs == SPIDER_IRQ_INVALID)\n-\t\tvirq = NO_IRQ;\n+\t\tvirq = 0;\n \telse\n \t\tvirq = irq_linear_revmap(pic->host, cs);\n\n-\tif (virq != NO_IRQ)\n+\tif (virq)\n \t\tgeneric_handle_irq(virq);\n\n \tchip->irq_eoi(&desc->irq_data);\n@@ -245,19 +245,19 @@ static unsigned int __init spider_find_c\n \t/* Now do the horrible hacks */\n \ttmp = of_get_property(of_node, \"#interrupt-cells\", NULL);\n \tif (tmp == NULL)\n-\t\treturn NO_IRQ;\n+\t\treturn 0;\n \tintsize = *tmp;\n \timap = of_get_property(of_node, \"interrupt-map\", &imaplen);\n \tif (imap == NULL || imaplen < (intsize + 1))\n-\t\treturn NO_IRQ;\n+\t\treturn 0;\n \tiic = of_find_node_by_phandle(imap[intsize]);\n \tif (iic == NULL)\n-\t\treturn NO_IRQ;\n+\t\treturn 0;\n \timap += intsize + 1;\n \ttmp = of_get_property(iic, \"#interrupt-cells\", NULL);\n \tif (tmp == NULL) {\n \t\tof_node_put(iic);\n-\t\treturn NO_IRQ;\n+\t\treturn 0;\n \t}\n \tintsize = *tmp;\n \t/* Assume unit is last entry of interrupt specifier */\n@@ -266,7 +266,7 @@ static unsigned int __init spider_find_c\n \ttmp = of_get_property(iic, \"ibm,interrupt-server-ranges\", NULL);\n \tif (tmp == NULL) {\n \t\tof_node_put(iic);\n-\t\treturn NO_IRQ;\n+\t\treturn 0;\n \t}\n \t/* ugly as hell but works for now */\n \tpic->node_id = (*tmp) >> 1;\n@@ -281,7 +281,7 @@ static unsigned int __init spider_find_c\n \t\t\t\t  (pic->node_id << IIC_IRQ_NODE_SHIFT) |\n \t\t\t\t  (2 << IIC_IRQ_CLASS_SHIFT) |\n \t\t\t\t  unit);\n-\tif (virq == NO_IRQ)\n+\tif (!virq)\n \t\tprintk(KERN_ERR \"spider_pic: failed to map cascade !\");\n \treturn virq;\n }\n@@ -318,7 +318,7 @@ static void __init spider_init_one(struc\n\n \t/* Hook up the cascade interrupt to the iic and nodeid */\n \tvirq = spider_find_cascade_and_node(pic);\n-\tif (virq == NO_IRQ)\n+\tif (!virq)\n \t\treturn;\n \tirq_set_handler_data(virq, pic);\n \tirq_set_chained_handler(virq, spider_irq_cascade);\ndiff -u -p a/arch/powerpc/platforms/cell/spu_manage.c b/arch/powerpc/platforms/cell/spu_manage.c\n--- a/arch/powerpc/platforms/cell/spu_manage.c\n+++ b/arch/powerpc/platforms/cell/spu_manage.c\n@@ -105,7 +105,7 @@ static int __init spu_map_interrupts_old\n \tspu->irqs[2] = irq_create_mapping(NULL, IIC_IRQ_CLASS_2 | isrc);\n\n \t/* Right now, we only fail if class 2 failed */\n-\treturn spu->irqs[2] == NO_IRQ ? -EINVAL : 0;\n+\treturn !spu->irqs[2] ? -EINVAL : 0;\n }\n\n static void __iomem * __init spu_map_prop_old(struct spu *spu,\n@@ -191,7 +191,7 @@ static int __init spu_map_interrupts(str\n \t\tpr_debug(\"  irq %d no 0x%x on %s\\n\", i, oirq.args[0],\n \t\t\t oirq.np->full_name);\n \t\tspu->irqs[i] = irq_create_of_mapping(&oirq);\n-\t\tif (spu->irqs[i] == NO_IRQ) {\n+\t\tif (!spu->irqs[i]) {\n \t\t\tpr_debug(\"spu_new: failed to map it !\\n\");\n \t\t\tgoto err;\n \t\t}\n@@ -202,7 +202,7 @@ err:\n \tpr_debug(\"failed to map irq %x for spu %s\\n\", *oirq.args,\n \t\tspu->name);\n \tfor (; i >= 0; i--) {\n-\t\tif (spu->irqs[i] != NO_IRQ)\n+\t\tif (spu->irqs[i])\n \t\t\tirq_dispose_mapping(spu->irqs[i]);\n \t}\n \treturn ret;\ndiff -u -p a/arch/powerpc/platforms/cell/iommu.c b/arch/powerpc/platforms/cell/iommu.c\n--- a/arch/powerpc/platforms/cell/iommu.c\n+++ b/arch/powerpc/platforms/cell/iommu.c\n@@ -411,7 +411,7 @@ static void cell_iommu_enable_hardware(s\n\n \tvirq = irq_create_mapping(NULL,\n \t\t\tIIC_IRQ_IOEX_ATI | (iommu->nid << IIC_IRQ_NODE_SHIFT));\n-\tBUG_ON(virq == NO_IRQ);\n+\tBUG_ON(!virq);\n\n \tret = request_irq(virq, ioc_interrupt, 0, iommu->name, iommu);\n \tBUG_ON(ret);\ndiff -u -p a/arch/powerpc/platforms/cell/axon_msi.c b/arch/powerpc/platforms/cell/axon_msi.c\n--- a/arch/powerpc/platforms/cell/axon_msi.c\n+++ b/arch/powerpc/platforms/cell/axon_msi.c\n@@ -271,7 +271,7 @@ static int axon_msi_setup_msi_irqs(struc\n\n \tfor_each_pci_msi_entry(entry, dev) {\n \t\tvirq = irq_create_direct_mapping(msic->irq_domain);\n-\t\tif (virq == NO_IRQ) {\n+\t\tif (!virq) {\n \t\t\tdev_warn(&dev->dev,\n \t\t\t\t \"axon_msi: virq allocation failed!\\n\");\n \t\t\treturn -1;\n@@ -293,7 +293,7 @@ static void axon_msi_teardown_msi_irqs(s\n \tdev_dbg(&dev->dev, \"axon_msi: tearing down msi irqs\\n\");\n\n \tfor_each_pci_msi_entry(entry, dev) {\n-\t\tif (entry->irq == NO_IRQ)\n+\t\tif (!entry->irq)\n \t\t\tcontinue;\n\n \t\tirq_set_msi_desc(entry->irq, NULL);\n@@ -375,7 +375,7 @@ static int axon_msi_probe(struct platfor\n \t}\n\n \tvirq = irq_of_parse_and_map(dn, 0);\n-\tif (virq == NO_IRQ) {\n+\tif (!virq) {\n \t\tprintk(KERN_ERR \"axon_msi: irq parse and map failed for %s\\n\",\n \t\t       dn->full_name);\n \t\tgoto out_free_fifo;\ndiff -u -p a/arch/powerpc/platforms/powernv/opal-irqchip.c b/arch/powerpc/platforms/powernv/opal-irqchip.c\n--- a/arch/powerpc/platforms/powernv/opal-irqchip.c\n+++ b/arch/powerpc/platforms/powernv/opal-irqchip.c\n@@ -222,7 +222,7 @@ int __init opal_event_init(void)\n \t\t/* Get hardware and virtual IRQ */\n \t\tirq = be32_to_cpup(irqs);\n \t\tvirq = irq_create_mapping(NULL, irq);\n-\t\tif (virq == NO_IRQ) {\n+\t\tif (!virq) {\n \t\t\tpr_warn(\"Failed to map irq 0x%x\\n\", irq);\n \t\t\tcontinue;\n \t\t}\n@@ -260,7 +260,7 @@ machine_arch_initcall(powernv, opal_even\n int opal_event_request(unsigned int opal_event_nr)\n {\n \tif (WARN_ON_ONCE(!opal_event_irqchip.domain))\n-\t\treturn NO_IRQ;\n+\t\treturn 0;\n\n \treturn irq_create_mapping(opal_event_irqchip.domain, opal_event_nr);\n }\ndiff -u -p a/arch/powerpc/platforms/powernv/pci-cxl.c b/arch/powerpc/platforms/powernv/pci-cxl.c\n--- a/arch/powerpc/platforms/powernv/pci-cxl.c\n+++ b/arch/powerpc/platforms/powernv/pci-cxl.c\n@@ -344,7 +344,7 @@ int pnv_cxl_cx4_setup_msi_irqs(struct pc\n \t\t\treturn (hwirq ? hwirq : -ENOMEM);\n\n \t\tvirq = irq_create_mapping(NULL, hwirq);\n-\t\tif (virq == NO_IRQ) {\n+\t\tif (!virq) {\n \t\t\tpr_warn(\"%s: Failed to map cxl mode MSI to linux irq\\n\",\n \t\t\t\tpci_name(pdev));\n \t\t\treturn -ENOMEM;\n@@ -374,7 +374,7 @@ void pnv_cxl_cx4_teardown_msi_irqs(struc\n \t\treturn;\n\n \tfor_each_pci_msi_entry(entry, pdev) {\n-\t\tif (entry->irq == NO_IRQ)\n+\t\tif (!entry->irq)\n \t\t\tcontinue;\n \t\thwirq = virq_to_hw(entry->irq);\n \t\tirq_set_msi_desc(entry->irq, NULL);\ndiff -u -p a/arch/powerpc/platforms/powernv/pci.c b/arch/powerpc/platforms/powernv/pci.c\n--- a/arch/powerpc/platforms/powernv/pci.c\n+++ b/arch/powerpc/platforms/powernv/pci.c\n@@ -186,7 +186,7 @@ int pnv_setup_msi_irqs(struct pci_dev *p\n \t\t\treturn -ENOSPC;\n \t\t}\n \t\tvirq = irq_create_mapping(NULL, phb->msi_base + hwirq);\n-\t\tif (virq == NO_IRQ) {\n+\t\tif (!virq) {\n \t\t\tpr_warn(\"%s: Failed to map MSI to linux irq\\n\",\n \t\t\t\tpci_name(pdev));\n \t\t\tmsi_bitmap_free_hwirqs(&phb->msi_bmp, hwirq, 1);\n@@ -217,7 +217,7 @@ void pnv_teardown_msi_irqs(struct pci_de\n \t\treturn;\n\n \tfor_each_pci_msi_entry(entry, pdev) {\n-\t\tif (entry->irq == NO_IRQ)\n+\t\tif (!entry->irq)\n \t\t\tcontinue;\n \t\thwirq = virq_to_hw(entry->irq);\n \t\tirq_set_msi_desc(entry->irq, NULL);\ndiff -u -p a/arch/powerpc/sysdev/ehv_pic.c b/arch/powerpc/sysdev/ehv_pic.c\n--- a/arch/powerpc/sysdev/ehv_pic.c\n+++ b/arch/powerpc/sysdev/ehv_pic.c\n@@ -168,7 +168,7 @@ unsigned int ehv_pic_get_irq(void)\n \t\tev_int_iack(0, &irq); /* legacy mode */\n\n \tif (irq == 0xFFFF)    /* 0xFFFF --> no irq is pending */\n-\t\treturn NO_IRQ;\n+\t\treturn 0;\n\n \t/*\n \t * this will also setup revmap[] in the slow path for the first\ndiff -u -p a/arch/powerpc/sysdev/xics/icp-hv.c b/arch/powerpc/sysdev/xics/icp-hv.c\n--- a/arch/powerpc/sysdev/xics/icp-hv.c\n+++ b/arch/powerpc/sysdev/xics/icp-hv.c\n@@ -112,10 +112,10 @@ static unsigned int icp_hv_get_irq(void)\n \tunsigned int irq;\n\n \tif (vec == XICS_IRQ_SPURIOUS)\n-\t\treturn NO_IRQ;\n+\t\treturn 0;\n\n \tirq = irq_find_mapping(xics_host, vec);\n-\tif (likely(irq != NO_IRQ)) {\n+\tif (likely(irq)) {\n \t\txics_push_cppr(vec);\n \t\treturn irq;\n \t}\n@@ -126,7 +126,7 @@ static unsigned int icp_hv_get_irq(void)\n \t/* We might learn about it later, so EOI it */\n \ticp_hv_set_xirr(xirr);\n\n-\treturn NO_IRQ;\n+\treturn 0;\n }\n\n static void icp_hv_set_cpu_priority(unsigned char cppr)\ndiff -u -p a/arch/powerpc/sysdev/xics/xics-common.c b/arch/powerpc/sysdev/xics/xics-common.c\n--- a/arch/powerpc/sysdev/xics/xics-common.c\n+++ b/arch/powerpc/sysdev/xics/xics-common.c\n@@ -131,7 +131,7 @@ static void xics_request_ipi(void)\n \tunsigned int ipi;\n\n \tipi = irq_create_mapping(xics_host, XICS_IPI);\n-\tBUG_ON(ipi == NO_IRQ);\n+\tBUG_ON(!ipi);\n\n \t/*\n \t * IPIs are marked IRQF_PERCPU. The handler was set in map.\ndiff -u -p a/arch/powerpc/sysdev/xics/icp-native.c b/arch/powerpc/sysdev/xics/icp-native.c\n--- a/arch/powerpc/sysdev/xics/icp-native.c\n+++ b/arch/powerpc/sysdev/xics/icp-native.c\n@@ -124,10 +124,10 @@ static unsigned int icp_native_get_irq(v\n \tunsigned int irq;\n\n \tif (vec == XICS_IRQ_SPURIOUS)\n-\t\treturn NO_IRQ;\n+\t\treturn 0;\n\n \tirq = irq_find_mapping(xics_host, vec);\n-\tif (likely(irq != NO_IRQ)) {\n+\tif (likely(irq)) {\n \t\txics_push_cppr(vec);\n \t\treturn irq;\n \t}\n@@ -138,7 +138,7 @@ static unsigned int icp_native_get_irq(v\n \t/* We might learn about it later, so EOI it */\n \ticp_native_set_xirr(xirr);\n\n-\treturn NO_IRQ;\n+\treturn 0;\n }\n\n #ifdef CONFIG_SMP\ndiff -u -p a/arch/powerpc/sysdev/xics/icp-opal.c b/arch/powerpc/sysdev/xics/icp-opal.c\n--- a/arch/powerpc/sysdev/xics/icp-opal.c\n+++ b/arch/powerpc/sysdev/xics/icp-opal.c\n@@ -51,14 +51,14 @@ static unsigned int icp_opal_get_irq(voi\n\n \trc = opal_int_get_xirr(&xirr, false);\n \tif (rc < 0)\n-\t\treturn NO_IRQ;\n+\t\treturn 0;\n \txirr = be32_to_cpu(xirr);\n \tvec = xirr & 0x00ffffff;\n \tif (vec == XICS_IRQ_SPURIOUS)\n-\t\treturn NO_IRQ;\n+\t\treturn 0;\n\n \tirq = irq_find_mapping(xics_host, vec);\n-\tif (likely(irq != NO_IRQ)) {\n+\tif (likely(irq)) {\n \t\txics_push_cppr(vec);\n \t\treturn irq;\n \t}\n@@ -69,7 +69,7 @@ static unsigned int icp_opal_get_irq(voi\n \t/* We might learn about it later, so EOI it */\n \topal_int_eoi(xirr);\n\n-\treturn NO_IRQ;\n+\treturn 0;\n }\n\n static void icp_opal_set_cpu_priority(unsigned char cppr)\ndiff -u -p a/arch/powerpc/sysdev/mpc8xx_pic.c b/arch/powerpc/sysdev/mpc8xx_pic.c\n--- a/arch/powerpc/sysdev/mpc8xx_pic.c\n+++ b/arch/powerpc/sysdev/mpc8xx_pic.c\n@@ -79,7 +79,7 @@ unsigned int mpc8xx_get_irq(void)\n \tirq = in_be32(&siu_reg->sc_sivec) >> 26;\n\n \tif (irq == PIC_VEC_SPURRIOUS)\n-\t\tirq = NO_IRQ;\n+\t\tirq = 0;\n\n         return irq_linear_revmap(mpc8xx_pic_host, irq);\n\ndiff -u -p a/arch/powerpc/sysdev/tsi108_pci.c b/arch/powerpc/sysdev/tsi108_pci.c\n--- a/arch/powerpc/sysdev/tsi108_pci.c\n+++ b/arch/powerpc/sysdev/tsi108_pci.c\n@@ -433,7 +433,7 @@ void tsi108_irq_cascade(struct irq_desc\n \tstruct irq_chip *chip = irq_desc_get_chip(desc);\n \tunsigned int cascade_irq = get_pci_source();\n\n-\tif (cascade_irq != NO_IRQ)\n+\tif (cascade_irq)\n \t\tgeneric_handle_irq(cascade_irq);\n\n \tchip->irq_eoi(&desc->irq_data);\ndiff -u -p a/arch/powerpc/sysdev/fsl_msi.c b/arch/powerpc/sysdev/fsl_msi.c\n--- a/arch/powerpc/sysdev/fsl_msi.c\n+++ b/arch/powerpc/sysdev/fsl_msi.c\n@@ -131,7 +131,7 @@ static void fsl_teardown_msi_irqs(struct\n \tirq_hw_number_t hwirq;\n\n \tfor_each_pci_msi_entry(entry, pdev) {\n-\t\tif (entry->irq == NO_IRQ)\n+\t\tif (!entry->irq)\n \t\t\tcontinue;\n \t\thwirq = virq_to_hw(entry->irq);\n \t\tmsi_data = irq_get_chip_data(entry->irq);\n@@ -250,7 +250,7 @@ static int fsl_setup_msi_irqs(struct pci\n\n \t\tvirq = irq_create_mapping(msi_data->irqhost, hwirq);\n\n-\t\tif (virq == NO_IRQ) {\n+\t\tif (!virq) {\n \t\t\tdev_err(&pdev->dev, \"fail mapping hwirq %i\\n\", hwirq);\n \t\t\tmsi_bitmap_free_hwirqs(&msi_data->bitmap, hwirq, 1);\n \t\t\trc = -ENOSPC;\n@@ -285,7 +285,7 @@ static irqreturn_t fsl_msi_cascade(int i\n \tmsir_index = cascade_data->index;\n\n \tif (msir_index >= NR_MSI_REG_MAX)\n-\t\tcascade_irq = NO_IRQ;\n+\t\tcascade_irq = 0;\n\n \tswitch (msi_data->feature & FSL_PIC_IP_MASK) {\n \tcase FSL_PIC_IP_MPIC:\n@@ -315,7 +315,7 @@ static irqreturn_t fsl_msi_cascade(int i\n \t\tcascade_irq = irq_linear_revmap(msi_data->irqhost,\n \t\t\t\tmsi_hwirq(msi_data, msir_index,\n \t\t\t\t\t  intr_index + have_shift));\n-\t\tif (cascade_irq != NO_IRQ) {\n+\t\tif (cascade_irq) {\n \t\t\tgeneric_handle_irq(cascade_irq);\n \t\t\tret = IRQ_HANDLED;\n \t\t}\n@@ -337,7 +337,7 @@ static int fsl_of_msi_remove(struct plat\n \t\tif (msi->cascade_array[i]) {\n \t\t\tvirq = msi->cascade_array[i]->virq;\n\n-\t\t\tBUG_ON(virq == NO_IRQ);\n+\t\t\tBUG_ON(!virq);\n\n \t\t\tfree_irq(virq, msi->cascade_array[i]);\n \t\t\tkfree(msi->cascade_array[i]);\n@@ -362,7 +362,7 @@ static int fsl_msi_setup_hwirq(struct fs\n \tint virt_msir, i, ret;\n\n \tvirt_msir = irq_of_parse_and_map(dev->dev.of_node, irq_index);\n-\tif (virt_msir == NO_IRQ) {\n+\tif (!virt_msir) {\n \t\tdev_err(&dev->dev, \"%s: Cannot translate IRQ index %d\\n\",\n \t\t\t__func__, irq_index);\n \t\treturn 0;\ndiff -u -p a/arch/powerpc/sysdev/mpic_msgr.c b/arch/powerpc/sysdev/mpic_msgr.c\n--- a/arch/powerpc/sysdev/mpic_msgr.c\n+++ b/arch/powerpc/sysdev/mpic_msgr.c\n@@ -238,7 +238,7 @@ static int mpic_msgr_probe(struct platfo\n\n \t\tif (receive_mask & (1 << i)) {\n \t\t\tmsgr->irq = irq_of_parse_and_map(np, irq_index);\n-\t\t\tif (msgr->irq == NO_IRQ) {\n+\t\t\tif (!msgr->irq) {\n \t\t\t\tdev_err(&dev->dev,\n \t\t\t\t\t\t\"Missing interrupt specifier\");\n \t\t\t\tkfree(msgr);\n@@ -246,7 +246,7 @@ static int mpic_msgr_probe(struct platfo\n \t\t\t}\n \t\t\tirq_index += 1;\n \t\t} else {\n-\t\t\tmsgr->irq = NO_IRQ;\n+\t\t\tmsgr->irq = 0;\n \t\t}\n\n \t\tmpic_msgrs[reg_number] = msgr;\ndiff -u -p a/arch/powerpc/sysdev/mv64x60_pic.c b/arch/powerpc/sysdev/mv64x60_pic.c\n--- a/arch/powerpc/sysdev/mv64x60_pic.c\n+++ b/arch/powerpc/sysdev/mv64x60_pic.c\n@@ -272,7 +272,7 @@ unsigned int mv64x60_get_irq(void)\n \tu32 cause;\n \tint level1;\n \tirq_hw_number_t hwirq;\n-\tint virq = NO_IRQ;\n+\tint virq = 0;\n\n \tcause = in_le32(mv64x60_irq_reg_base + MV64X60_IC_CPU0_SELECT_CAUSE);\n \tif (cause & MV64X60_SELECT_CAUSE_HIGH) {\ndiff -u -p a/arch/powerpc/sysdev/ge/ge_pic.c b/arch/powerpc/sysdev/ge/ge_pic.c\n--- a/arch/powerpc/sysdev/ge/ge_pic.c\n+++ b/arch/powerpc/sysdev/ge/ge_pic.c\n@@ -102,7 +102,7 @@ static void gef_pic_cascade(struct irq_d\n \t */\n \tcascade_irq = gef_pic_get_irq();\n\n-\tif (cascade_irq != NO_IRQ)\n+\tif (cascade_irq)\n \t\tgeneric_handle_irq(cascade_irq);\n\n \tchip->irq_eoi(&desc->irq_data);\n@@ -206,7 +206,7 @@ void __init gef_pic_init(struct device_n\n\n \t/* Map controller */\n \tgef_pic_cascade_irq = irq_of_parse_and_map(np, 0);\n-\tif (gef_pic_cascade_irq == NO_IRQ) {\n+\tif (!gef_pic_cascade_irq) {\n \t\tprintk(KERN_ERR \"SBC610: failed to map cascade interrupt\");\n \t\treturn;\n \t}\n@@ -228,7 +228,7 @@ void __init gef_pic_init(struct device_n\n unsigned int gef_pic_get_irq(void)\n {\n \tu32 cause, mask, active;\n-\tunsigned int virq = NO_IRQ;\n+\tunsigned int virq = 0;\n \tint hwirq;\n\n \tcause = in_be32(gef_pic_irq_reg_base + GEF_PIC_INTR_STATUS);\ndiff -u -p a/arch/powerpc/sysdev/mpic_u3msi.c b/arch/powerpc/sysdev/mpic_u3msi.c\n--- a/arch/powerpc/sysdev/mpic_u3msi.c\n+++ b/arch/powerpc/sysdev/mpic_u3msi.c\n@@ -110,7 +110,7 @@ static void u3msi_teardown_msi_irqs(stru\n \tirq_hw_number_t hwirq;\n\n \tfor_each_pci_msi_entry(entry, pdev) {\n-\t\tif (entry->irq == NO_IRQ)\n+\t\tif (!entry->irq)\n \t\t\tcontinue;\n\n \t\thwirq = virq_to_hw(entry->irq);\n@@ -155,7 +155,7 @@ static int u3msi_setup_msi_irqs(struct p\n \t\tmsg.address_hi = addr >> 32;\n\n \t\tvirq = irq_create_mapping(msi_mpic->irqhost, hwirq);\n-\t\tif (virq == NO_IRQ) {\n+\t\tif (!virq) {\n \t\t\tpr_debug(\"u3msi: failed mapping hwirq 0x%x\\n\", hwirq);\n \t\t\tmsi_bitmap_free_hwirqs(&msi_mpic->msi_bitmap, hwirq, 1);\n \t\t\treturn -ENOSPC;\ndiff -u -p a/arch/powerpc/sysdev/mpic.c b/arch/powerpc/sysdev/mpic.c\n--- a/arch/powerpc/sysdev/mpic.c\n+++ b/arch/powerpc/sysdev/mpic.c\n@@ -1649,7 +1649,7 @@ void __init mpic_init(struct mpic *mpic)\n \t/* Check if this MPIC is chained from a parent interrupt controller */\n \tif (mpic->flags & MPIC_SECONDARY) {\n \t\tint virq = irq_of_parse_and_map(mpic->node, 0);\n-\t\tif (virq != NO_IRQ) {\n+\t\tif (virq) {\n \t\t\tprintk(KERN_INFO \"%s: hooking up to IRQ %d\\n\",\n \t\t\t\t\tmpic->node->full_name, virq);\n \t\t\tirq_set_handler_data(virq, mpic);\n@@ -1778,13 +1778,13 @@ static unsigned int _mpic_get_one_irq(st\n \tif (unlikely(src == mpic->spurious_vec)) {\n \t\tif (mpic->flags & MPIC_SPV_EOI)\n \t\t\tmpic_eoi(mpic);\n-\t\treturn NO_IRQ;\n+\t\treturn 0;\n \t}\n \tif (unlikely(mpic->protected && test_bit(src, mpic->protected))) {\n \t\tprintk_ratelimited(KERN_WARNING \"%s: Got protected source %d !\\n\",\n \t\t\t\t   mpic->name, (int)src);\n \t\tmpic_eoi(mpic);\n-\t\treturn NO_IRQ;\n+\t\treturn 0;\n \t}\n\n \treturn irq_linear_revmap(mpic->irqhost, src);\n@@ -1817,17 +1817,17 @@ unsigned int mpic_get_coreint_irq(void)\n \tif (unlikely(src == mpic->spurious_vec)) {\n \t\tif (mpic->flags & MPIC_SPV_EOI)\n \t\t\tmpic_eoi(mpic);\n-\t\treturn NO_IRQ;\n+\t\treturn 0;\n \t}\n \tif (unlikely(mpic->protected && test_bit(src, mpic->protected))) {\n \t\tprintk_ratelimited(KERN_WARNING \"%s: Got protected source %d !\\n\",\n \t\t\t\t   mpic->name, (int)src);\n-\t\treturn NO_IRQ;\n+\t\treturn 0;\n \t}\n\n \treturn irq_linear_revmap(mpic->irqhost, src);\n #else\n-\treturn NO_IRQ;\n+\treturn 0;\n #endif\n }\n\n@@ -1852,7 +1852,7 @@ void mpic_request_ipis(void)\n \tfor (i = 0; i < 4; i++) {\n \t\tunsigned int vipi = irq_create_mapping(mpic->irqhost,\n \t\t\t\t\t\t       mpic->ipi_vecs[0] + i);\n-\t\tif (vipi == NO_IRQ) {\n+\t\tif (!vipi) {\n \t\t\tprintk(KERN_ERR \"Failed to map %s\\n\", smp_ipi_name[i]);\n \t\t\tcontinue;\n \t\t}\ndiff -u -p a/arch/powerpc/sysdev/ppc4xx_msi.c b/arch/powerpc/sysdev/ppc4xx_msi.c\n--- a/arch/powerpc/sysdev/ppc4xx_msi.c\n+++ b/arch/powerpc/sysdev/ppc4xx_msi.c\n@@ -102,7 +102,7 @@ static int ppc4xx_setup_msi_irqs(struct\n \t\t\t\t\t__func__);\n \t\t}\n \t\tvirq = irq_of_parse_and_map(msi_data->msi_dev, int_no);\n-\t\tif (virq == NO_IRQ) {\n+\t\tif (!virq) {\n \t\t\tdev_err(&dev->dev, \"%s: fail mapping irq\\n\", __func__);\n \t\t\tmsi_bitmap_free_hwirqs(&msi_data->bitmap, int_no, 1);\n \t\t\treturn -ENOSPC;\n@@ -129,7 +129,7 @@ void ppc4xx_teardown_msi_irqs(struct pci\n \tdev_dbg(&dev->dev, \"PCIE-MSI: tearing down msi irqs\\n\");\n\n \tfor_each_pci_msi_entry(entry, dev) {\n-\t\tif (entry->irq == NO_IRQ)\n+\t\tif (!entry->irq)\n \t\t\tcontinue;\n \t\thwirq = virq_to_hw(entry->irq);\n \t\tirq_set_msi_desc(entry->irq, NULL);\n@@ -201,7 +201,7 @@ static int ppc4xx_of_msi_remove(struct p\n\n \tfor (i = 0; i < msi_irqs; i++) {\n \t\tvirq = msi->msi_virqs[i];\n-\t\tif (virq != NO_IRQ)\n+\t\tif (virq)\n \t\t\tirq_dispose_mapping(virq);\n \t}\n\ndiff -u -p a/arch/powerpc/sysdev/fsl_mpic_err.c b/arch/powerpc/sysdev/fsl_mpic_err.c\n--- a/arch/powerpc/sysdev/fsl_mpic_err.c\n+++ b/arch/powerpc/sysdev/fsl_mpic_err.c\n@@ -115,8 +115,8 @@ static irqreturn_t fsl_error_int_handler\n \t\terrint = __builtin_clz(eisr);\n \t\tcascade_irq = irq_linear_revmap(mpic->irqhost,\n \t\t\t\t mpic->err_int_vecs[errint]);\n-\t\tWARN_ON(cascade_irq == NO_IRQ);\n-\t\tif (cascade_irq != NO_IRQ) {\n+\t\tWARN_ON(!cascade_irq);\n+\t\tif (cascade_irq) {\n \t\t\tgeneric_handle_irq(cascade_irq);\n \t\t} else {\n \t\t\teimr |=  1 << (31 - errint);\n@@ -134,7 +134,7 @@ void mpic_err_int_init(struct mpic *mpic\n \tint ret;\n\n \tvirq = irq_create_mapping(mpic->irqhost, irqnum);\n-\tif (virq == NO_IRQ) {\n+\tif (!virq) {\n \t\tpr_err(\"Error interrupt setup failed\\n\");\n \t\treturn;\n \t}\ndiff -u -p a/arch/powerpc/sysdev/i8259.c b/arch/powerpc/sysdev/i8259.c\n--- a/arch/powerpc/sysdev/i8259.c\n+++ b/arch/powerpc/sysdev/i8259.c\n@@ -68,9 +68,9 @@ unsigned int i8259_irq(void)\n \t\tif (!pci_intack)\n \t\t\toutb(0x0B, 0x20);\t/* ISR register */\n \t\tif(~inb(0x20) & 0x80)\n-\t\t\tirq = NO_IRQ;\n+\t\t\tirq = 0;\n \t} else if (irq == 0xff)\n-\t\tirq = NO_IRQ;\n+\t\tirq = 0;\n\n \tif (lock)\n \t\traw_spin_unlock(&i8259_lock);\ndiff -u -p a/arch/powerpc/sysdev/ppc4xx_hsta_msi.c b/arch/powerpc/sysdev/ppc4xx_hsta_msi.c\n--- a/arch/powerpc/sysdev/ppc4xx_hsta_msi.c\n+++ b/arch/powerpc/sysdev/ppc4xx_hsta_msi.c\n@@ -60,7 +60,7 @@ static int hsta_setup_msi_irqs(struct pc\n \t\t}\n\n \t\thwirq = ppc4xx_hsta_msi.irq_map[irq];\n-\t\tif (hwirq == NO_IRQ) {\n+\t\tif (!hwirq) {\n \t\t\tpr_err(\"%s: Failed mapping irq %d\\n\", __func__, irq);\n \t\t\treturn -EINVAL;\n \t\t}\n@@ -110,7 +110,7 @@ static void hsta_teardown_msi_irqs(struc\n \tint irq;\n\n \tfor_each_pci_msi_entry(entry, dev) {\n-\t\tif (entry->irq == NO_IRQ)\n+\t\tif (!entry->irq)\n \t\t\tcontinue;\n\n \t\tirq = hsta_find_hwirq_offset(entry->irq);\n@@ -166,7 +166,7 @@ static int hsta_msi_probe(struct platfor\n \tfor (irq = 0; irq < irq_count; irq++) {\n \t\tppc4xx_hsta_msi.irq_map[irq] =\n \t\t\tirq_of_parse_and_map(dev->of_node, irq);\n-\t\tif (ppc4xx_hsta_msi.irq_map[irq] == NO_IRQ) {\n+\t\tif (!ppc4xx_hsta_msi.irq_map[irq]) {\n \t\t\tdev_err(dev, \"Unable to map IRQ\\n\");\n \t\t\tret = -EINVAL;\n \t\t\tgoto out2;\ndiff -u -p a/arch/powerpc/sysdev/axonram.c b/arch/powerpc/sysdev/axonram.c\n--- a/arch/powerpc/sysdev/axonram.c\n+++ b/arch/powerpc/sysdev/axonram.c\n@@ -240,7 +240,7 @@ static int axon_ram_probe(struct platfor\n \tdevice_add_disk(&device->dev, bank->disk);\n\n \tbank->irq_id = irq_of_parse_and_map(device->dev.of_node, 0);\n-\tif (bank->irq_id == NO_IRQ) {\n+\tif (!bank->irq_id) {\n \t\tdev_err(&device->dev, \"Cannot access ECC interrupt ID\\n\");\n \t\trc = -EFAULT;\n \t\tgoto failed;\n@@ -250,7 +250,7 @@ static int axon_ram_probe(struct platfor\n \t\t\tAXON_RAM_IRQ_FLAGS, bank->disk->disk_name, device);\n \tif (rc != 0) {\n \t\tdev_err(&device->dev, \"Cannot register ECC interrupt handler\\n\");\n-\t\tbank->irq_id = NO_IRQ;\n+\t\tbank->irq_id = 0;\n \t\trc = -EFAULT;\n \t\tgoto failed;\n \t}\n@@ -268,7 +268,7 @@ static int axon_ram_probe(struct platfor\n\n failed:\n \tif (bank != NULL) {\n-\t\tif (bank->irq_id != NO_IRQ)\n+\t\tif (bank->irq_id)\n \t\t\tfree_irq(bank->irq_id, device);\n \t\tif (bank->disk != NULL) {\n \t\t\tif (bank->disk->major > 0)\ndiff -u -p a/arch/powerpc/sysdev/fsl_gtm.c b/arch/powerpc/sysdev/fsl_gtm.c\n--- a/arch/powerpc/sysdev/fsl_gtm.c\n+++ b/arch/powerpc/sysdev/fsl_gtm.c\n@@ -406,7 +406,7 @@ static int __init fsl_gtm_init(void)\n \t\t\tunsigned int irq;\n\n \t\t\tirq = irq_of_parse_and_map(np, i);\n-\t\t\tif (irq == NO_IRQ) {\n+\t\t\tif (!irq) {\n \t\t\t\tpr_err(\"%s: not enough interrupts specified\\n\",\n \t\t\t\t       np->full_name);\n \t\t\t\tgoto err;\ndiff -u -p a/arch/powerpc/sysdev/pmi.c b/arch/powerpc/sysdev/pmi.c\n--- a/arch/powerpc/sysdev/pmi.c\n+++ b/arch/powerpc/sysdev/pmi.c\n@@ -158,7 +158,7 @@ static int pmi_of_probe(struct platform_\n \tdata->dev = dev;\n\n \tdata->irq = irq_of_parse_and_map(np, 0);\n-\tif (data->irq == NO_IRQ) {\n+\tif (!data->irq) {\n \t\tprintk(KERN_ERR \"pmi: invalid interrupt.\\n\");\n \t\trc = -EFAULT;\n \t\tgoto error_cleanup_iomap;\ndiff -u -p a/arch/powerpc/sysdev/cpm1.c b/arch/powerpc/sysdev/cpm1.c\n--- a/arch/powerpc/sysdev/cpm1.c\n+++ b/arch/powerpc/sysdev/cpm1.c\n@@ -132,7 +132,7 @@ unsigned int cpm_pic_init(void)\n {\n \tstruct device_node *np = NULL;\n \tstruct resource res;\n-\tunsigned int sirq = NO_IRQ, hwirq, eirq;\n+\tunsigned int sirq = 0, hwirq, eirq;\n \tint ret;\n\n \tpr_debug(\"cpm_pic_init\\n\");\n@@ -154,7 +154,7 @@ unsigned int cpm_pic_init(void)\n \t\tgoto end;\n\n \tsirq = irq_of_parse_and_map(np, 0);\n-\tif (sirq == NO_IRQ)\n+\tif (!sirq)\n \t\tgoto end;\n\n \t/* Initialize the CPM interrupt controller. */\n@@ -168,7 +168,7 @@ unsigned int cpm_pic_init(void)\n \tcpm_pic_host = irq_domain_add_linear(np, 64, &cpm_pic_host_ops, NULL);\n \tif (cpm_pic_host == NULL) {\n \t\tprintk(KERN_ERR \"CPM2 PIC: failed to allocate irq host!\\n\");\n-\t\tsirq = NO_IRQ;\n+\t\tsirq = 0;\n \t\tgoto end;\n \t}\n\n@@ -182,7 +182,7 @@ unsigned int cpm_pic_init(void)\n \t}\n\n \teirq = irq_of_parse_and_map(np, 0);\n-\tif (eirq == NO_IRQ)\n+\tif (!eirq)\n \t\tgoto end;\n\n \tif (setup_irq(eirq, &cpm_error_irqaction))\ndiff -u -p a/arch/powerpc/sysdev/ppc4xx_soc.c b/arch/powerpc/sysdev/ppc4xx_soc.c\n--- a/arch/powerpc/sysdev/ppc4xx_soc.c\n+++ b/arch/powerpc/sysdev/ppc4xx_soc.c\n@@ -109,7 +109,7 @@ static int __init ppc4xx_l2c_probe(void)\n\n \t/* Get and map irq number from device tree */\n \tirq = irq_of_parse_and_map(np, 0);\n-\tif (irq == NO_IRQ) {\n+\tif (!irq) {\n \t\tprintk(KERN_ERR \"irq_of_parse_and_map failed\\n\");\n \t\tof_node_put(np);\n \t\treturn -ENODEV;\ndiff -u -p a/arch/powerpc/sysdev/ipic.c b/arch/powerpc/sysdev/ipic.c\n--- a/arch/powerpc/sysdev/ipic.c\n+++ b/arch/powerpc/sysdev/ipic.c\n@@ -864,7 +864,7 @@ unsigned int ipic_get_irq(void)\n \tirq = ipic_read(primary_ipic->regs, IPIC_SIVCR) & IPIC_SIVCR_VECTOR_MASK;\n\n \tif (irq == 0)    /* 0 --> no irq is pending */\n-\t\treturn NO_IRQ;\n+\t\treturn 0;\n\n \treturn irq_linear_revmap(primary_ipic->irqhost, irq);\n }\ndiff -u -p a/arch/powerpc/kernel/legacy_serial.c b/arch/powerpc/kernel/legacy_serial.c\n--- a/arch/powerpc/kernel/legacy_serial.c\n+++ b/arch/powerpc/kernel/legacy_serial.c\n@@ -193,10 +193,10 @@ static int __init add_legacy_soc_port(st\n \t */\n \tif (tsi && !strcmp(tsi->type, \"tsi-bridge\"))\n \t\treturn add_legacy_port(np, -1, UPIO_TSI, addr, addr,\n-\t\t\t\t       NO_IRQ, legacy_port_flags, 0);\n+\t\t\t\t       0, legacy_port_flags, 0);\n \telse\n \t\treturn add_legacy_port(np, -1, UPIO_MEM, addr, addr,\n-\t\t\t\t       NO_IRQ, legacy_port_flags, 0);\n+\t\t\t\t       0, legacy_port_flags, 0);\n }\n\n static int __init add_legacy_isa_port(struct device_node *np,\n@@ -242,7 +242,7 @@ static int __init add_legacy_isa_port(st\n\n \t/* Add port, irq will be dealt with later */\n \treturn add_legacy_port(np, index, UPIO_PORT, be32_to_cpu(reg[1]),\n-\t\t\t       taddr, NO_IRQ, legacy_port_flags, 0);\n+\t\t\t       taddr, 0, legacy_port_flags, 0);\n\n }\n\n@@ -314,7 +314,7 @@ static int __init add_legacy_pci_port(st\n \t/* Add port, irq will be dealt with later. We passed a translated\n \t * IO port value. It will be fixed up later along with the irq\n \t */\n-\treturn add_legacy_port(np, index, iotype, base, addr, NO_IRQ,\n+\treturn add_legacy_port(np, index, iotype, base, addr, 0,\n \t\t\t       legacy_port_flags, np != pci_dev);\n }\n #endif\n@@ -462,14 +462,14 @@ static void __init fixup_port_irq(int in\n \tDBG(\"fixup_port_irq(%d)\\n\", index);\n\n \tvirq = irq_of_parse_and_map(np, 0);\n-\tif (virq == NO_IRQ && legacy_serial_infos[index].irq_check_parent) {\n+\tif (!virq && legacy_serial_infos[index].irq_check_parent) {\n \t\tnp = of_get_parent(np);\n \t\tif (np == NULL)\n \t\t\treturn;\n \t\tvirq = irq_of_parse_and_map(np, 0);\n \t\tof_node_put(np);\n \t}\n-\tif (virq == NO_IRQ)\n+\tif (!virq)\n \t\treturn;\n\n \tport->irq = virq;\n@@ -543,7 +543,7 @@ static int __init serial_dev_init(void)\n \t\tstruct plat_serial8250_port *port = &legacy_serial_ports[i];\n \t\tstruct device_node *np = legacy_serial_infos[i].np;\n\n-\t\tif (port->irq == NO_IRQ)\n+\t\tif (!port->irq)\n \t\t\tfixup_port_irq(i, np, port);\n \t\tif (port->iotype == UPIO_PORT)\n \t\t\tfixup_port_pio(i, np, port);\ndiff -u -p a/arch/powerpc/kernel/pci_of_scan.c b/arch/powerpc/kernel/pci_of_scan.c\n--- a/arch/powerpc/kernel/pci_of_scan.c\n+++ b/arch/powerpc/kernel/pci_of_scan.c\n@@ -178,7 +178,7 @@ struct pci_dev *of_create_pci_dev(struct\n \t\tdev->hdr_type = PCI_HEADER_TYPE_NORMAL;\n \t\tdev->rom_base_reg = PCI_ROM_ADDRESS;\n \t\t/* Maybe do a default OF mapping here */\n-\t\tdev->irq = NO_IRQ;\n+\t\tdev->irq = 0;\n \t}\n\n \tof_pci_parse_addrs(node, dev);\ndiff -u -p a/arch/powerpc/kernel/pci-common.c b/arch/powerpc/kernel/pci-common.c\n--- a/arch/powerpc/kernel/pci-common.c\n+++ b/arch/powerpc/kernel/pci-common.c\n@@ -324,7 +324,7 @@ static int pci_read_irq_line(struct pci_\n \t\t\t line, pin);\n\n \t\tvirq = irq_create_mapping(NULL, line);\n-\t\tif (virq != NO_IRQ)\n+\t\tif (virq)\n \t\t\tirq_set_irq_type(virq, IRQ_TYPE_LEVEL_LOW);\n \t} else {\n \t\tpr_debug(\" Got one, spec %d cells (0x%08x 0x%08x...) on %s\\n\",\n@@ -333,7 +333,7 @@ static int pci_read_irq_line(struct pci_\n\n \t\tvirq = irq_create_of_mapping(&oirq);\n \t}\n-\tif(virq == NO_IRQ) {\n+\tif(!virq) {\n \t\tpr_debug(\" Failed to map !\\n\");\n \t\treturn -1;\n \t}\ndiff -u -p a/arch/powerpc/kernel/irq.c b/arch/powerpc/kernel/irq.c\n--- a/arch/powerpc/kernel/irq.c\n+++ b/arch/powerpc/kernel/irq.c\n@@ -514,7 +514,7 @@ void __do_irq(struct pt_regs *regs)\n \tmay_hard_irq_enable();\n\n \t/* And finally process it */\n-\tif (unlikely(irq == NO_IRQ))\n+\tif (unlikely(!irq))\n \t\t__this_cpu_inc(irq_stat.spurious_irqs);\n \telse\n \t\tgeneric_handle_irq(irq);\ndiff -u -p a/arch/powerpc/kernel/ibmebus.c b/arch/powerpc/kernel/ibmebus.c\n--- a/arch/powerpc/kernel/ibmebus.c\n+++ b/arch/powerpc/kernel/ibmebus.c\n@@ -227,7 +227,7 @@ int ibmebus_request_irq(u32 ist, irq_han\n {\n \tunsigned int irq = irq_create_mapping(NULL, ist);\n\n-\tif (irq == NO_IRQ)\n+\tif (!irq)\n \t\treturn -EINVAL;\n\n \treturn request_irq(irq, handler, irq_flags, devname, dev_id);\n",
    "prefixes": [
        "Ksummit-discuss",
        "CORE",
        "TOPIC"
    ]
}