Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/665034/?format=api
{ "id": 665034, "url": "http://patchwork.ozlabs.org/api/patches/665034/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1472761647-2595-1-git-send-email-sridhar.samudrala@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1472761647-2595-1-git-send-email-sridhar.samudrala@intel.com>", "list_archive_url": null, "date": "2016-09-01T20:27:27", "name": "[dev-queue,v2] i40evf: Fix link state event handling.", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "89209c680906e76dc643642c2e59faa922c6d5bd", "submitter": { "id": 65219, "url": "http://patchwork.ozlabs.org/api/people/65219/?format=api", "name": "Samudrala, Sridhar", "email": "sridhar.samudrala@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1472761647-2595-1-git-send-email-sridhar.samudrala@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/665034/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/665034/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3sQFrc0Syrz9s5w\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 2 Sep 2016 07:34:24 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 6D5C231B17;\n\tThu, 1 Sep 2016 21:34:22 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id l0yUG+c3uClw; Thu, 1 Sep 2016 21:34:19 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 602B731B16;\n\tThu, 1 Sep 2016 21:34:19 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 67EC31D09F0\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 1 Sep 2016 21:34:18 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 62C908AD17\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 1 Sep 2016 21:34:18 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id zNxsjAUJqzLD for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 1 Sep 2016 21:34:17 +0000 (UTC)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 177A88AD10\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 1 Sep 2016 21:34:17 +0000 (UTC)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby orsmga101.jf.intel.com with ESMTP; 01 Sep 2016 14:33:41 -0700", "from unknown (HELO sri-mi-02.jf.intel.com) ([10.166.31.66])\n\tby fmsmga002.fm.intel.com with ESMTP; 01 Sep 2016 14:33:41 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.30,268,1470726000\"; d=\"scan'208\";\n\ta=\"1050341600\"", "From": "Sridhar Samudrala <sridhar.samudrala@intel.com>", "To": "intel-wired-lan@lists.osuosl.org, john.r.fastabend@intel.com,\n\tanjali.singhai@intel.com", "Date": "Thu, 1 Sep 2016 22:27:27 +0200", "Message-Id": "<1472761647-2595-1-git-send-email-sridhar.samudrala@intel.com>", "X-Mailer": "git-send-email 2.5.5", "Subject": "[Intel-wired-lan] [dev-queue PATCH v2] i40evf: Fix link state event\n\thandling.", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "Currently disabling the link state from PF via\n\tip link set enp5s0f0 vf 0 state disable\ndoesn't disable the CARRIER on the VF.\n\nThis patch updates the carrier and starts/stops the tx queues based on the\nlink state notification from PF.\n\n PF: enp5s0f0, VF: enp5s2\n #modprobe i40e\n #echo 2 > /sys/class/net/enp5s0f0/device/sriov_numvfs\n #ip link set enp5s2 up\n #ip -d link show enp5s2\n 175: enp5s2: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UP mode DEFAULT group default qlen 1000\n link/ether ea:4d:60:bc:6f:85 brd ff:ff:ff:ff:ff:ff promiscuity 0 addrgenmode eui64\n #ip link set enp5s0f0 vf 0 state disable\n #ip -d link show enp5s0f0\n 171: enp5s0f0: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000\n link/ether 68:05:ca:2e:72:68 brd ff:ff:ff:ff:ff:ff promiscuity 0 addrgenmode eui64 numtxqueues 72 numrxqueues 72 portid 6805ca2e7268\n vf 0 MAC 00:00:00:00:00:00, spoof checking on, link-state disable, trust off\n vf 1 MAC 00:00:00:00:00:00, spoof checking on, link-state auto, trust off\n #ip -d link show enp5s2\n 175: enp5s2: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc mq state DOWN mode DEFAULT group default qlen 1000\n link/ether ea:4d:60:bc:6f:85 brd ff:ff:ff:ff:ff:ff promiscuity 0 addrgenmode eui64 numtxqueues 16 numrxqueues 16\n\nv2:\nUpdate adapter->link_up when carrier is turned off.\n\nSigned-off-by: Sridhar Samudrala <sridhar.samudrala@intel.com>\n---\n drivers/net/ethernet/intel/i40evf/i40evf_main.c | 4 ++++\n drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c | 10 +++++++---\n 2 files changed, 11 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c b/drivers/net/ethernet/intel/i40evf/i40evf_main.c\nindex f751f7b..e0a8cd8 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40evf_main.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40evf_main.c\n@@ -1037,6 +1037,7 @@ void i40evf_down(struct i40evf_adapter *adapter)\n \n \tnetif_carrier_off(netdev);\n \tnetif_tx_disable(netdev);\n+\tadapter->link_up = false;\n \ti40evf_napi_disable_all(adapter);\n \ti40evf_irq_disable(adapter);\n \n@@ -1731,6 +1732,7 @@ static void i40evf_reset_task(struct work_struct *work)\n \t\t\tset_bit(__I40E_DOWN, &adapter->vsi.state);\n \t\t\tnetif_carrier_off(netdev);\n \t\t\tnetif_tx_disable(netdev);\n+\t\t\tadapter->link_up = false;\n \t\t\ti40evf_napi_disable_all(adapter);\n \t\t\ti40evf_irq_disable(adapter);\n \t\t\ti40evf_free_traffic_irqs(adapter);\n@@ -1769,6 +1771,7 @@ continue_reset:\n \tif (netif_running(adapter->netdev)) {\n \t\tnetif_carrier_off(netdev);\n \t\tnetif_tx_stop_all_queues(netdev);\n+\t\tadapter->link_up = false;\n \t\ti40evf_napi_disable_all(adapter);\n \t}\n \ti40evf_irq_disable(adapter);\n@@ -2457,6 +2460,7 @@ static void i40evf_init_task(struct work_struct *work)\n \t\tgoto err_sw_init;\n \n \tnetif_carrier_off(netdev);\n+\tadapter->link_up = false;\n \n \tif (!adapter->netdev_registered) {\n \t\terr = register_netdev(netdev);\ndiff --git a/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c b/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c\nindex cc6cb30..ddf478d 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c\n@@ -898,8 +898,14 @@ void i40evf_virtchnl_completion(struct i40evf_adapter *adapter,\n \t\t\t vpe->event_data.link_event.link_status) {\n \t\t\t\tadapter->link_up =\n \t\t\t\t\tvpe->event_data.link_event.link_status;\n+\t\t\t\tif (adapter->link_up) {\n+\t\t\t\t\tnetif_tx_start_all_queues(netdev);\n+\t\t\t\t\tnetif_carrier_on(netdev);\n+\t\t\t\t} else {\n+\t\t\t\t\tnetif_tx_stop_all_queues(netdev);\n+\t\t\t\t\tnetif_carrier_off(netdev);\n+\t\t\t\t}\n \t\t\t\ti40evf_print_link_message(adapter);\n-\t\t\t\tnetif_tx_stop_all_queues(netdev);\n \t\t\t}\n \t\t\tbreak;\n \t\tcase I40E_VIRTCHNL_EVENT_RESET_IMPENDING:\n@@ -974,8 +980,6 @@ void i40evf_virtchnl_completion(struct i40evf_adapter *adapter,\n \tcase I40E_VIRTCHNL_OP_ENABLE_QUEUES:\n \t\t/* enable transmits */\n \t\ti40evf_irq_enable(adapter, true);\n-\t\tnetif_tx_start_all_queues(adapter->netdev);\n-\t\tnetif_carrier_on(adapter->netdev);\n \t\tbreak;\n \tcase I40E_VIRTCHNL_OP_DISABLE_QUEUES:\n \t\ti40evf_free_all_tx_resources(adapter);\n", "prefixes": [ "dev-queue", "v2" ] }