Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/665010/?format=api
{ "id": 665010, "url": "http://patchwork.ozlabs.org/api/patches/665010/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/147276353170.65625.9520381365094159590.stgit@mdrustad-wks.jf.intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<147276353170.65625.9520381365094159590.stgit@mdrustad-wks.jf.intel.com>", "list_archive_url": null, "date": "2016-09-01T20:58:51", "name": "ixgbe: Use MDIO_PRTAD_NONE consistently", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "00739cf2e8d543992cf8bb57c400241d59f77e30", "submitter": { "id": 13252, "url": "http://patchwork.ozlabs.org/api/people/13252/?format=api", "name": "Rustad, Mark D", "email": "mark.d.rustad@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/147276353170.65625.9520381365094159590.stgit@mdrustad-wks.jf.intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/665010/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/665010/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3sQF3k0fw9z9sBg\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 2 Sep 2016 06:58:57 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 70D2EC0D21;\n\tThu, 1 Sep 2016 20:58:56 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 9wljNSLLE4w9; Thu, 1 Sep 2016 20:58:54 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id E0810C0D11;\n\tThu, 1 Sep 2016 20:58:54 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 6E5601C1761\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 1 Sep 2016 20:58:53 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 4912E8AE73\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 1 Sep 2016 20:58:53 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id wLg4WAbf8lzg for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 1 Sep 2016 20:58:52 +0000 (UTC)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 795638AE70\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 1 Sep 2016 20:58:52 +0000 (UTC)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga103.fm.intel.com with ESMTP; 01 Sep 2016 13:58:51 -0700", "from mdrustad-wks.jf.intel.com ([134.134.3.196])\n\tby orsmga002.jf.intel.com with ESMTP; 01 Sep 2016 13:58:51 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.30,268,1470726000\"; d=\"scan'208\";\n\ta=\"1044587695\"", "From": "Mark D Rustad <mark.d.rustad@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 01 Sep 2016 13:58:51 -0700", "Message-ID": "<147276353170.65625.9520381365094159590.stgit@mdrustad-wks.jf.intel.com>", "User-Agent": "StGit/unknown-version", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH] ixgbe: Use MDIO_PRTAD_NONE consistently", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "The value MDIO_PRTAD_NONE should be used to indicate no PHY address.\nNot 0, not 0xFFFF. Use the MDIO_PRTAD_NONE value consistently.\n\nSigned-off-by: Mark Rustad <mark.d.rustad@intel.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c | 4 ++--\n drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 2 +-\n 2 files changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c\nindex db0731e05401..021ab9b89c71 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c\n@@ -346,8 +346,8 @@ s32 ixgbe_identify_phy_generic(struct ixgbe_hw *hw)\n \t\t\t\treturn 0;\n \t\t\t}\n \t\t}\n-\t\t/* clear value if nothing found */\n-\t\thw->phy.mdio.prtad = 0;\n+\t\t/* indicate no PHY found */\n+\t\thw->phy.mdio.prtad = MDIO_PRTAD_NONE;\n \t\treturn IXGBE_ERR_PHY_ADDR_INVALID;\n \t}\n \treturn 0;\ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c\nindex cd22efb940ad..7e6b9267ca9d 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c\n@@ -1459,7 +1459,7 @@ ixgbe_setup_mac_link_sfp_x550a(struct ixgbe_hw *hw, ixgbe_link_speed speed,\n \t/* Configure internal PHY for KR/KX. */\n \tixgbe_setup_kr_speed_x550em(hw, speed);\n \n-\tif (!hw->phy.mdio.prtad || hw->phy.mdio.prtad == 0xFFFF)\n+\tif (hw->phy.mdio.prtad == MDIO_PRTAD_NONE)\n \t\treturn IXGBE_ERR_PHY_ADDR_INVALID;\n \n \t/* Get external PHY device id */\n", "prefixes": [] }