Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/663884/?format=api
{ "id": 663884, "url": "http://patchwork.ozlabs.org/api/patches/663884/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160829233928.10108.99079.stgit@localhost6.localdomain6/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20160829233928.10108.99079.stgit@localhost6.localdomain6>", "list_archive_url": null, "date": "2016-08-29T23:39:28", "name": "ixgbevf: add spinlocks for MTU change calls", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "7fd78104921fd911a7c97d98e4b2ad2259011291", "submitter": { "id": 1670, "url": "http://patchwork.ozlabs.org/api/people/1670/?format=api", "name": "Tantilov, Emil S", "email": "emil.s.tantilov@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160829233928.10108.99079.stgit@localhost6.localdomain6/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/663884/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/663884/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3sNSj10QdLz9sC3\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 30 Aug 2016 09:36:36 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 39AF73121B;\n\tMon, 29 Aug 2016 23:36:34 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id hwQr2yW0PPeS; Mon, 29 Aug 2016 23:36:32 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id C441B2F9FB;\n\tMon, 29 Aug 2016 23:36:32 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id A0CD31C1641\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 29 Aug 2016 23:36:31 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 9BF4288C1C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 29 Aug 2016 23:36:31 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id VD4o3MQDWSZi for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 29 Aug 2016 23:36:30 +0000 (UTC)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id A493588B50\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 29 Aug 2016 23:36:30 +0000 (UTC)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga104.fm.intel.com with ESMTP; 29 Aug 2016 16:36:29 -0700", "from estantil-desk3.jf.intel.com (HELO localhost6.localdomain6)\n\t([134.134.3.186])\n\tby fmsmga002.fm.intel.com with ESMTP; 29 Aug 2016 16:36:28 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.30,253,1470726000\"; d=\"scan'208\";\n\ta=\"1048884749\"", "From": "Emil Tantilov <emil.s.tantilov@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Mon, 29 Aug 2016 16:39:28 -0700", "Message-ID": "<20160829233928.10108.99079.stgit@localhost6.localdomain6>", "User-Agent": "StGit/0.17.1-17-ge4e0", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH] ixgbevf: add spinlocks for MTU change\n\tcalls", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "Protect set_rlpml with mailbox lock to make sure tha MTU configuration\nis handled properly.\n\nThis change resolves an issue where set_rlpml can fail when the VF\ninterface is brought up:\nixgbevf 0000:03:1d.6: Failed to set MTU at 1500\n\nSigned-off-by: Emil Tantilov <emil.s.tantilov@intel.com>\n---\n drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 4 ++++\n 1 file changed, 4 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c\nindex 4044608..7eaac32 100644\n--- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c\n+++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c\n@@ -1810,8 +1810,10 @@ static void ixgbevf_configure_rx(struct ixgbevf_adapter *adapter)\n \tif (hw->mac.type >= ixgbe_mac_X550_vf)\n \t\tixgbevf_setup_vfmrqc(adapter);\n \n+\tspin_lock_bh(&adapter->mbx_lock);\n \t/* notify the PF of our intent to use this size of frame */\n \tret = hw->mac.ops.set_rlpml(hw, netdev->mtu + ETH_HLEN + ETH_FCS_LEN);\n+\tspin_unlock_bh(&adapter->mbx_lock);\n \tif (ret)\n \t\tdev_err(&adapter->pdev->dev,\n \t\t\t\"Failed to set MTU at %d\\n\", netdev->mtu);\n@@ -3758,8 +3760,10 @@ static int ixgbevf_change_mtu(struct net_device *netdev, int new_mtu)\n \tif ((new_mtu < 68) || (max_frame > max_possible_frame))\n \t\treturn -EINVAL;\n \n+\tspin_lock_bh(&adapter->mbx_lock);\n \t/* notify the PF of our intent to use this size of frame */\n \tret = hw->mac.ops.set_rlpml(hw, max_frame);\n+\tspin_unlock_bh(&adapter->mbx_lock);\n \tif (ret)\n \t\treturn -EINVAL;\n \n", "prefixes": [] }