Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/663400/?format=api
{ "id": 663400, "url": "http://patchwork.ozlabs.org/api/patches/663400/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160828174101.9671-1-colin.king@canonical.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20160828174101.9671-1-colin.king@canonical.com>", "list_archive_url": null, "date": "2016-08-28T17:41:01", "name": "i40e: avoid potential null pointer dereference when assigning len", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "7f69356f67a9780a882c3490d04de6db1cadff65", "submitter": { "id": 2900, "url": "http://patchwork.ozlabs.org/api/people/2900/?format=api", "name": "Colin Ian King", "email": "colin.king@canonical.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160828174101.9671-1-colin.king@canonical.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/663400/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/663400/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3sMhtr4tSLz9s9c\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 29 Aug 2016 03:42:27 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 41DC48A521;\n\tSun, 28 Aug 2016 17:42:24 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id c6NZn7VPSFnT; Sun, 28 Aug 2016 17:42:23 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 2927A89C42;\n\tSun, 28 Aug 2016 17:42:23 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 150D51C28F9\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSun, 28 Aug 2016 17:42:22 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 0C68F89C42\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSun, 28 Aug 2016 17:42:22 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id AsHJoZJjauh6 for <intel-wired-lan@lists.osuosl.org>;\n\tSun, 28 Aug 2016 17:42:21 +0000 (UTC)", "from youngberry.canonical.com (youngberry.canonical.com\n\t[91.189.89.112])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 41E7F89ACE\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSun, 28 Aug 2016 17:42:21 +0000 (UTC)", "from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost)\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.76) (envelope-from <colin.king@canonical.com>)\n\tid 1be465-0007lq-G3; Sun, 28 Aug 2016 17:42:17 +0000" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "Colin King <colin.king@canonical.com>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>,\n\tintel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org", "Date": "Sun, 28 Aug 2016 18:41:01 +0100", "Message-Id": "<20160828174101.9671-1-colin.king@canonical.com>", "X-Mailer": "git-send-email 2.9.3", "Cc": "linux-kernel@vger.kernel.org", "Subject": "[Intel-wired-lan] [PATCH] i40e: avoid potential null pointer\n\tdereference when assigning len", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Colin Ian King <colin.king@canonical.com>\n\nThere is a sanitcy check for desc being null in the first line of\nfunction i40evf_debug_aq. However, before that, aq_desc is cast from\ndesc, and aq_desc is being dereferenced on the assignment of len, so\nthis could be a potential null pointer deference. Fix this by moving\nthe initialization of len to the code block where len is being used\nand hence at this point we know it is OK to dereference aq_desc.\n\nSigned-off-by: Colin Ian King <colin.king@canonical.com>\n---\n drivers/net/ethernet/intel/i40evf/i40e_common.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40evf/i40e_common.c b/drivers/net/ethernet/intel/i40evf/i40e_common.c\nindex 4db0c03..7953c13 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40e_common.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40e_common.c\n@@ -302,7 +302,6 @@ void i40evf_debug_aq(struct i40e_hw *hw, enum i40e_debug_mask mask, void *desc,\n \t\t void *buffer, u16 buf_len)\n {\n \tstruct i40e_aq_desc *aq_desc = (struct i40e_aq_desc *)desc;\n-\tu16 len = le16_to_cpu(aq_desc->datalen);\n \tu8 *buf = (u8 *)buffer;\n \tu16 i = 0;\n \n@@ -326,6 +325,8 @@ void i40evf_debug_aq(struct i40e_hw *hw, enum i40e_debug_mask mask, void *desc,\n \t\t le32_to_cpu(aq_desc->params.external.addr_low));\n \n \tif ((buffer != NULL) && (aq_desc->datalen != 0)) {\n+\t\tu16 len = le16_to_cpu(aq_desc->datalen);\n+\n \t\ti40e_debug(hw, mask, \"AQ CMD Buffer:\\n\");\n \t\tif (buf_len < len)\n \t\t\tlen = buf_len;\n", "prefixes": [] }