Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/663256/?format=api
{ "id": 663256, "url": "http://patchwork.ozlabs.org/api/patches/663256/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/147224810290.93893.8237532391891649262.stgit@mdrustad-wks.jf.intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<147224810290.93893.8237532391891649262.stgit@mdrustad-wks.jf.intel.com>", "list_archive_url": null, "date": "2016-08-26T21:48:22", "name": "ixgbe: Eliminate useless message and improve logic", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "b951b2cceec9922cc11d1a87f6d08f2438c52482", "submitter": { "id": 13252, "url": "http://patchwork.ozlabs.org/api/people/13252/?format=api", "name": "Rustad, Mark D", "email": "mark.d.rustad@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/147224810290.93893.8237532391891649262.stgit@mdrustad-wks.jf.intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/663256/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/663256/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3sLZRf1JZCz9sDf\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 27 Aug 2016 07:48:29 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 3DC1E8A818;\n\tFri, 26 Aug 2016 21:48:27 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id BxSZ+t1ALq48; Fri, 26 Aug 2016 21:48:26 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id A95AB8A628;\n\tFri, 26 Aug 2016 21:48:26 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 1AABF1C25EB\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 26 Aug 2016 21:48:25 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 11FDA2EF40\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 26 Aug 2016 21:48:25 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 4eXXgcPs+1Om for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 26 Aug 2016 21:48:23 +0000 (UTC)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 8B3CE2EDB7\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 26 Aug 2016 21:48:23 +0000 (UTC)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby fmsmga105.fm.intel.com with ESMTP; 26 Aug 2016 14:48:23 -0700", "from mdrustad-wks.jf.intel.com ([134.134.3.196])\n\tby orsmga003.jf.intel.com with ESMTP; 26 Aug 2016 14:48:22 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.28,583,1464678000\"; d=\"scan'208\";a=\"871551369\"", "From": "Mark D Rustad <mark.d.rustad@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 26 Aug 2016 14:48:22 -0700", "Message-ID": "<147224810290.93893.8237532391891649262.stgit@mdrustad-wks.jf.intel.com>", "User-Agent": "StGit/unknown-version", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH] ixgbe: Eliminate useless message and\n\timprove logic", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "Remove a useless log message and improve the logic for setting\na PHY address from the contents of the MNG_IF_SEL register.\n\nSigned-off-by: Mark Rustad <mark.d.rustad@intel.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 16 +++++-----------\n 1 file changed, 5 insertions(+), 11 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c\nindex 417913e2deb1..dec8b116e6a2 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c\n@@ -2394,18 +2394,12 @@ static void ixgbe_read_mng_if_sel_x550em(struct ixgbe_hw *hw)\n \t/* If X552 (X550EM_a) and MDIO is connected to external PHY, then set\n \t * PHY address. This register field was has only been used for X552.\n \t */\n-\tif (!hw->phy.nw_mng_if_sel) {\n-\t\tif (hw->mac.type == ixgbe_mac_x550em_a) {\n-\t\t\tstruct ixgbe_adapter *adapter = hw->back;\n-\n-\t\t\te_warn(drv, \"nw_mng_if_sel not set\\n\");\n-\t\t}\n-\t\treturn;\n+\tif (hw->mac.type == ixgbe_mac_x550em_a &&\n+\t hw->phy.nw_mng_if_sel & IXGBE_NW_MNG_IF_SEL_MDIO_ACT) {\n+\t\thw->phy.mdio.prtad = (hw->phy.nw_mng_if_sel &\n+\t\t\t\t IXGBE_NW_MNG_IF_SEL_MDIO_PHY_ADD) >>\n+\t\t\t\t IXGBE_NW_MNG_IF_SEL_MDIO_PHY_ADD_SHIFT;\n \t}\n-\n-\thw->phy.mdio.prtad = (hw->phy.nw_mng_if_sel &\n-\t\t\t IXGBE_NW_MNG_IF_SEL_MDIO_PHY_ADD) >>\n-\t\t\t IXGBE_NW_MNG_IF_SEL_MDIO_PHY_ADD_SHIFT;\n }\n \n /** ixgbe_init_phy_ops_X550em - PHY/SFP specific init\n", "prefixes": [] }