Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/662458/?format=api
{ "id": 662458, "url": "http://patchwork.ozlabs.org/api/patches/662458/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1472063631-9033-6-git-send-email-bimmy.pujari@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1472063631-9033-6-git-send-email-bimmy.pujari@intel.com>", "list_archive_url": null, "date": "2016-08-24T18:33:50", "name": "[next,S44,5/6] i40e: Fix to check for NULL", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "b05f40b925f6eec038a9c32c608ad7bf601607fd", "submitter": { "id": 68919, "url": "http://patchwork.ozlabs.org/api/people/68919/?format=api", "name": "Pujari, Bimmy", "email": "bimmy.pujari@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1472063631-9033-6-git-send-email-bimmy.pujari@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/662458/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/662458/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3sKGF43dfDz9sCy\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 25 Aug 2016 04:34:48 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id B6C8E315B1;\n\tWed, 24 Aug 2016 18:34:46 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id JoTCsMIpQl-w; Wed, 24 Aug 2016 18:34:42 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 1E6CB31573;\n\tWed, 24 Aug 2016 18:34:40 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 772A51C16C7\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 24 Aug 2016 18:34:37 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 73BA085771\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 24 Aug 2016 18:34:37 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Af67yUAfwomf for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 24 Aug 2016 18:34:36 +0000 (UTC)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 30DC5853F3\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 24 Aug 2016 18:34:36 +0000 (UTC)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby fmsmga105.fm.intel.com with ESMTP; 24 Aug 2016 11:34:26 -0700", "from bimmy.jf.intel.com (HELO bimmy.linux1.jf.intel.com)\n\t([134.134.2.177])\n\tby FMSMGA003.fm.intel.com with ESMTP; 24 Aug 2016 11:34:23 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.28,571,1464678000\"; d=\"scan'208\";a=\"753043626\"", "From": "Bimmy Pujari <bimmy.pujari@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 24 Aug 2016 11:33:50 -0700", "Message-Id": "<1472063631-9033-6-git-send-email-bimmy.pujari@intel.com>", "X-Mailer": "git-send-email 2.4.11", "In-Reply-To": "<1472063631-9033-1-git-send-email-bimmy.pujari@intel.com>", "References": "<1472063631-9033-1-git-send-email-bimmy.pujari@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S44 5/6] i40e: Fix to check for NULL", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Carolyn Wyborny <carolyn.wyborny@intel.com>\n\nThis patch fixes an issue in the virt channel code, where a return\nfrom i40e_find_vsi_from_id was not checked for NULL when applicable.\nWithout this patch, there is a risk for panic and static analysis\ntools complain. This patch fixes the problem by adding the check\nand adding an additional input check for similar reasons.\n\nSigned-off-by: Carolyn Wyborny <carolyn.wyborny@intel.com>\nChange-ID: I7e9be88eb7a3addb50eadc451c8336d9e06f5394\n---\n drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 11 ++++++++++-\n 1 file changed, 10 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\nindex 27df091..5eb2069 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n@@ -502,8 +502,16 @@ static int i40e_config_vsi_tx_queue(struct i40e_vf *vf, u16 vsi_id,\n \tu32 qtx_ctl;\n \tint ret = 0;\n \n+\tif (!i40e_vc_isvalid_vsi_id(vf, info->vsi_id)) {\n+\t\tret = -ENOENT;\n+\t\tgoto error_context;\n+\t}\n \tpf_queue_id = i40e_vc_get_pf_queue_id(vf, vsi_id, vsi_queue_id);\n \tvsi = i40e_find_vsi_from_id(pf, vsi_id);\n+\tif (!vsi) {\n+\t\tret = -ENOENT;\n+\t\tgoto error_context;\n+\t}\n \n \t/* clear the context structure first */\n \tmemset(&tx_ctx, 0, sizeof(struct i40e_hmc_obj_txq));\n@@ -1624,7 +1632,8 @@ static int i40e_vc_config_promiscuous_mode_msg(struct i40e_vf *vf,\n \n \tvsi = i40e_find_vsi_from_id(pf, info->vsi_id);\n \tif (!test_bit(I40E_VF_STAT_ACTIVE, &vf->vf_states) ||\n-\t !i40e_vc_isvalid_vsi_id(vf, info->vsi_id)) {\n+\t !i40e_vc_isvalid_vsi_id(vf, info->vsi_id) ||\n+\t !vsi) {\n \t\taq_ret = I40E_ERR_PARAM;\n \t\tgoto error_param;\n \t}\n", "prefixes": [ "next", "S44", "5/6" ] }