Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/659423/?format=api
{ "id": 659423, "url": "http://patchwork.ozlabs.org/api/patches/659423/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1471295839-13587-2-git-send-email-bimmy.pujari@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1471295839-13587-2-git-send-email-bimmy.pujari@intel.com>", "list_archive_url": null, "date": "2016-08-15T21:17:19", "name": "[next,S42-V2,2/2] i40e: Initialize pointer in client_release function", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "f0a619b656402ff514044df5136176ba14b6b983", "submitter": { "id": 68919, "url": "http://patchwork.ozlabs.org/api/people/68919/?format=api", "name": "Pujari, Bimmy", "email": "bimmy.pujari@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1471295839-13587-2-git-send-email-bimmy.pujari@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/659423/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/659423/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3sCpHW3rDlz9t2M\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 16 Aug 2016 07:17:59 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 207C230D1E;\n\tMon, 15 Aug 2016 21:17:58 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id G15xvfMEgoSw; Mon, 15 Aug 2016 21:17:56 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 3C3CB30D08;\n\tMon, 15 Aug 2016 21:17:56 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id E4F621C2A49\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 15 Aug 2016 21:17:54 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id E23FA89045\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 15 Aug 2016 21:17:54 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id PUzELt6TsGu4 for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 15 Aug 2016 21:17:51 +0000 (UTC)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id F0CB489100\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 15 Aug 2016 21:17:50 +0000 (UTC)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga103.jf.intel.com with ESMTP; 15 Aug 2016 14:17:50 -0700", "from bimmy.jf.intel.com (HELO bimmy.linux1.jf.intel.com)\n\t([134.134.2.177])\n\tby orsmga002.jf.intel.com with ESMTP; 15 Aug 2016 14:17:50 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.28,527,1464678000\"; d=\"scan'208\";\n\ta=\"1036026602\"", "From": "Bimmy Pujari <bimmy.pujari@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Mon, 15 Aug 2016 14:17:19 -0700", "Message-Id": "<1471295839-13587-2-git-send-email-bimmy.pujari@intel.com>", "X-Mailer": "git-send-email 2.4.11", "In-Reply-To": "<1471295839-13587-1-git-send-email-bimmy.pujari@intel.com>", "References": "<1471295839-13587-1-git-send-email-bimmy.pujari@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S42-V2 2/2] i40e: Initialize pointer\n\tin client_release function", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Harshitha Ramamurthy <harshitha.ramamurthy@intel.com>\n\nThe function i40e_client_release has a print statement that uses an\nadapter pointer which is not initialized if a previous if statement\nis not true. Hence, intialize it in the right place.\n\nTesting Hints: Compile check\n\nSigned-off-by: Harshitha Ramamurthy <harshitha.ramamurthy@intel.com>\nChange-ID: I1afdaa2c46771ac42be56edcc41bb56b455b06c8\n---\n drivers/net/ethernet/intel/i40e/i40e_client.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_client.c b/drivers/net/ethernet/intel/i40e/i40e_client.c\nindex 1035f88..09a37cf 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_client.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_client.c\n@@ -662,7 +662,7 @@ int i40e_lan_del_device(struct i40e_pf *pf)\n static int i40e_client_release(struct i40e_client *client)\n {\n \tstruct i40e_client_instance *cdev, *tmp;\n-\tstruct i40e_pf *pf = NULL;\n+\tstruct i40e_pf *pf;\n \tint ret = 0;\n \n \tLIST_HEAD(cdevs_tmp);\n@@ -672,12 +672,12 @@ static int i40e_client_release(struct i40e_client *client)\n \t\tif (strncmp(cdev->client->name, client->name,\n \t\t\t I40E_CLIENT_STR_LENGTH))\n \t\t\tcontinue;\n+\t\tpf = (struct i40e_pf *)cdev->lan_info.pf;\n \t\tif (test_bit(__I40E_CLIENT_INSTANCE_OPENED, &cdev->state)) {\n \t\t\tif (atomic_read(&cdev->ref_cnt) > 0) {\n \t\t\t\tret = I40E_ERR_NOT_READY;\n \t\t\t\tgoto out;\n \t\t\t}\n-\t\t\tpf = (struct i40e_pf *)cdev->lan_info.pf;\n \t\t\tif (client->ops && client->ops->close)\n \t\t\t\tclient->ops->close(&cdev->lan_info, client,\n \t\t\t\t\t\t false);\n", "prefixes": [ "next", "S42-V2", "2/2" ] }