Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/659422/?format=api
{ "id": 659422, "url": "http://patchwork.ozlabs.org/api/patches/659422/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1471295839-13587-1-git-send-email-bimmy.pujari@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1471295839-13587-1-git-send-email-bimmy.pujari@intel.com>", "list_archive_url": null, "date": "2016-08-15T21:17:18", "name": "[next,S42-V2,1/2] i40e: Check client is open before calling client ops", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "1c6752359685365ce96b6603d97d5c561274f118", "submitter": { "id": 68919, "url": "http://patchwork.ozlabs.org/api/people/68919/?format=api", "name": "Pujari, Bimmy", "email": "bimmy.pujari@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1471295839-13587-1-git-send-email-bimmy.pujari@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/659422/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/659422/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3sCpHT67Y4z9t2M\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 16 Aug 2016 07:17:57 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 570FC30D14;\n\tMon, 15 Aug 2016 21:17:56 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id mie6S4Hu676T; Mon, 15 Aug 2016 21:17:53 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id BD5F730CA3;\n\tMon, 15 Aug 2016 21:17:53 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id B868B1C2A49\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 15 Aug 2016 21:17:51 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id B378F891AE\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 15 Aug 2016 21:17:51 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id p4WYud5hcPJE for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 15 Aug 2016 21:17:50 +0000 (UTC)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id DCECA89045\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 15 Aug 2016 21:17:50 +0000 (UTC)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga103.jf.intel.com with ESMTP; 15 Aug 2016 14:17:50 -0700", "from bimmy.jf.intel.com (HELO bimmy.linux1.jf.intel.com)\n\t([134.134.2.177])\n\tby orsmga002.jf.intel.com with ESMTP; 15 Aug 2016 14:17:50 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.28,527,1464678000\"; d=\"scan'208\";\n\ta=\"1036026601\"", "From": "Bimmy Pujari <bimmy.pujari@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Mon, 15 Aug 2016 14:17:18 -0700", "Message-Id": "<1471295839-13587-1-git-send-email-bimmy.pujari@intel.com>", "X-Mailer": "git-send-email 2.4.11", "Cc": "Catherine Sullivan <catherine.sullivan@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S42-V2 1/2] i40e: Check client is\n\topen before calling client ops", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Catherine Sullivan <catherine.sullivan@intel.com>\n\nWe were having a race between the completion of the client open and\ncalls to the client ops so don't call a client op unless we are sure the\nclient is open.\n\nTesting Hints: Load IWARP driver and make sure it works as expected.\n\nSigned-off-by: Catherine Sullivan <catherine.sullivan@intel.com>\nChange-Id: I741f4f2aa4fcbfdad3e40dabbbb1b005856c396b\n---\n drivers/net/ethernet/intel/i40e/i40e_client.c | 25 +++++++++++++++++++++++++\n 1 file changed, 25 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_client.c b/drivers/net/ethernet/intel/i40e/i40e_client.c\nindex 677dae5..1035f88 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_client.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_client.c\n@@ -148,6 +148,11 @@ i40e_notify_client_of_vf_msg(struct i40e_vsi *vsi, u32 vf_id, u8 *msg, u16 len)\n \t\t\t\t\t\"Cannot locate client instance virtual channel receive routine\\n\");\n \t\t\t\tcontinue;\n \t\t\t}\n+\t\t\tif (!test_bit(__I40E_CLIENT_INSTANCE_OPENED,\n+\t\t\t\t &cdev->state)) {\n+\t\t\t\tdev_dbg(&vsi->back->pdev->dev, \"Client is not open, abort virtchnl_receive\\n\");\n+\t\t\t\tcontinue;\n+\t\t\t}\n \t\t\tcdev->client->ops->virtchnl_receive(&cdev->lan_info,\n \t\t\t\t\t\t\t cdev->client,\n \t\t\t\t\t\t\t vf_id, msg, len);\n@@ -181,6 +186,11 @@ void i40e_notify_client_of_l2_param_changes(struct i40e_vsi *vsi)\n \t\t\t\t\t\"Cannot locate client instance l2_param_change routine\\n\");\n \t\t\t\tcontinue;\n \t\t\t}\n+\t\t\tif (!test_bit(__I40E_CLIENT_INSTANCE_OPENED,\n+\t\t\t\t &cdev->state)) {\n+\t\t\t\tdev_dbg(&vsi->back->pdev->dev, \"Client is not open, abort l2 param change\\n\");\n+\t\t\t\tcontinue;\n+\t\t\t}\n \t\t\tcdev->lan_info.params = params;\n \t\t\tcdev->client->ops->l2_param_change(&cdev->lan_info,\n \t\t\t\t\t\t\t cdev->client,\n@@ -298,6 +308,11 @@ void i40e_notify_client_of_vf_reset(struct i40e_pf *pf, u32 vf_id)\n \t\t\t\t\t\"Cannot locate client instance VF reset routine\\n\");\n \t\t\t\tcontinue;\n \t\t\t}\n+\t\t\tif (!test_bit(__I40E_CLIENT_INSTANCE_OPENED,\n+\t\t\t\t &cdev->state)) {\n+\t\t\t\tdev_dbg(&pf->pdev->dev, \"Client is not open, abort vf-reset\\n\");\n+\t\t\t\tcontinue;\n+\t\t\t}\n \t\t\tcdev->client->ops->vf_reset(&cdev->lan_info,\n \t\t\t\t\t\t cdev->client, vf_id);\n \t\t}\n@@ -328,6 +343,11 @@ void i40e_notify_client_of_vf_enable(struct i40e_pf *pf, u32 num_vfs)\n \t\t\t\t\t\"Cannot locate client instance VF enable routine\\n\");\n \t\t\t\tcontinue;\n \t\t\t}\n+\t\t\tif (!test_bit(__I40E_CLIENT_INSTANCE_OPENED,\n+\t\t\t\t &cdev->state)) {\n+\t\t\t\tdev_dbg(&pf->pdev->dev, \"Client is not open, abort vf-enable\\n\");\n+\t\t\t\tcontinue;\n+\t\t\t}\n \t\t\tcdev->client->ops->vf_enable(&cdev->lan_info,\n \t\t\t\t\t\t cdev->client, num_vfs);\n \t\t}\n@@ -362,6 +382,11 @@ int i40e_vf_client_capable(struct i40e_pf *pf, u32 vf_id,\n \t\t\t\t\t\"Cannot locate client instance VF capability routine\\n\");\n \t\t\t\tcontinue;\n \t\t\t}\n+\t\t\tif (!test_bit(__I40E_CLIENT_INSTANCE_OPENED,\n+\t\t\t\t &cdev->state)) {\n+\t\t\t\tdev_dbg(&pf->pdev->dev, \"Client is not open, abort vf-capable\\n\");\n+\t\t\t\tcontinue;\n+\t\t\t}\n \t\t\tcapable = cdev->client->ops->vf_capable(&cdev->lan_info,\n \t\t\t\t\t\t\t\tcdev->client,\n \t\t\t\t\t\t\t\tvf_id);\n", "prefixes": [ "next", "S42-V2", "1/2" ] }