Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/655889/?format=api
{ "id": 655889, "url": "http://patchwork.ozlabs.org/api/patches/655889/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1470335825-15534-3-git-send-email-bimmy.pujari@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1470335825-15534-3-git-send-email-bimmy.pujari@intel.com>", "list_archive_url": null, "date": "2016-08-04T18:37:02", "name": "[next,S41-V2,2/5] i40evf: report link speed", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "ae715d0064d341f048d845413ecb524f47d6dcd4", "submitter": { "id": 68919, "url": "http://patchwork.ozlabs.org/api/people/68919/?format=api", "name": "Pujari, Bimmy", "email": "bimmy.pujari@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1470335825-15534-3-git-send-email-bimmy.pujari@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/655889/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/655889/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3s4zFh08Jyz9sXR\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 5 Aug 2016 04:37:43 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 26DBF2F352;\n\tThu, 4 Aug 2016 18:37:42 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id d25JeoJG8Jtj; Thu, 4 Aug 2016 18:37:38 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id B0B3F3122A;\n\tThu, 4 Aug 2016 18:37:37 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 72BCD1CEA96\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 4 Aug 2016 18:37:35 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 6FE628A183\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 4 Aug 2016 18:37:35 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id GHxytarZMKIi for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 4 Aug 2016 18:37:32 +0000 (UTC)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 9699F89F34\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 4 Aug 2016 18:37:32 +0000 (UTC)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga104.fm.intel.com with ESMTP; 04 Aug 2016 11:37:32 -0700", "from bimmy.jf.intel.com (HELO bimmy.linux1.jf.intel.com)\n\t([134.134.2.177])\n\tby orsmga001.jf.intel.com with ESMTP; 04 Aug 2016 11:37:32 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.28,471,1464678000\"; d=\"scan'208\";\n\ta=\"1008560092\"", "From": "Bimmy Pujari <bimmy.pujari@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 4 Aug 2016 11:37:02 -0700", "Message-Id": "<1470335825-15534-3-git-send-email-bimmy.pujari@intel.com>", "X-Mailer": "git-send-email 2.4.11", "In-Reply-To": "<1470335825-15534-1-git-send-email-bimmy.pujari@intel.com>", "References": "<1470335825-15534-1-git-send-email-bimmy.pujari@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S41-V2 2/5] i40evf: report link speed", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Mitch Williams <mitch.a.williams@intel.com>\n\nThe PF driver tells us the link speed, so do something with that\ninformation. Add link speed to log messages, and report speed through\nethtool.\n\nSigned-off-by: Mitch Williams <mitch.a.williams@intel.com>\nChange-Id: I279dc9540cc5203376406050a3e8d67e128d5882\n---\nTesting Hints : Test reporting of link up/down and\nvarious speeds.\n\n drivers/net/ethernet/intel/i40evf/i40evf.h | 1 +\n drivers/net/ethernet/intel/i40evf/i40evf_ethtool.c | 26 ++++++++--\n .../net/ethernet/intel/i40evf/i40evf_virtchnl.c | 55 ++++++++++++++++++----\n 3 files changed, 70 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40evf/i40evf.h b/drivers/net/ethernet/intel/i40evf/i40evf.h\nindex 2ef12a0..be1ca4c 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40evf.h\n+++ b/drivers/net/ethernet/intel/i40evf/i40evf.h\n@@ -251,6 +251,7 @@ struct i40evf_adapter {\n \tstruct work_struct watchdog_task;\n \tbool netdev_registered;\n \tbool link_up;\n+\tenum i40e_aq_link_speed link_speed;\n \tenum i40e_virtchnl_ops current_op;\n #define CLIENT_ENABLED(_a) ((_a)->vf_res ? \\\n \t\t\t (_a)->vf_res->vf_offload_flags & \\\ndiff --git a/drivers/net/ethernet/intel/i40evf/i40evf_ethtool.c b/drivers/net/ethernet/intel/i40evf/i40evf_ethtool.c\nindex c6bd659..daae492 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40evf_ethtool.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40evf_ethtool.c\n@@ -74,13 +74,33 @@ static const struct i40evf_stats i40evf_gstrings_stats[] = {\n static int i40evf_get_settings(struct net_device *netdev,\n \t\t\t struct ethtool_cmd *ecmd)\n {\n-\t/* In the future the VF will be able to query the PF for\n-\t * some information - for now use a dummy value\n-\t */\n+\tstruct i40evf_adapter *adapter = netdev_priv(netdev);\n+\n \tecmd->supported = 0;\n \tecmd->autoneg = AUTONEG_DISABLE;\n \tecmd->transceiver = XCVR_DUMMY1;\n \tecmd->port = PORT_NONE;\n+\t/* Set speed and duplex */\n+\tswitch (adapter->link_speed) {\n+\tcase I40E_LINK_SPEED_40GB:\n+\t\tethtool_cmd_speed_set(ecmd, SPEED_40000);\n+\t\tbreak;\n+\tcase I40E_LINK_SPEED_20GB:\n+\t\tethtool_cmd_speed_set(ecmd, SPEED_20000);\n+\t\tbreak;\n+\tcase I40E_LINK_SPEED_10GB:\n+\t\tethtool_cmd_speed_set(ecmd, SPEED_10000);\n+\t\tbreak;\n+\tcase I40E_LINK_SPEED_1GB:\n+\t\tethtool_cmd_speed_set(ecmd, SPEED_1000);\n+\t\tbreak;\n+\tcase I40E_LINK_SPEED_100MB:\n+\t\tethtool_cmd_speed_set(ecmd, SPEED_100);\n+\t\tbreak;\n+\tdefault:\n+\t\tbreak;\n+\t}\n+\tecmd->duplex = DUPLEX_FULL;\n \n \treturn 0;\n }\ndiff --git a/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c b/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c\nindex d76c221..cc6cb30 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c\n@@ -817,6 +817,45 @@ void i40evf_set_rss_lut(struct i40evf_adapter *adapter)\n }\n \n /**\n+ * i40evf_print_link_message - print link up or down\n+ * @adapter: adapter structure\n+ *\n+ * Log a message telling the world of our wonderous link status\n+ */\n+static void i40evf_print_link_message(struct i40evf_adapter *adapter)\n+{\n+\tstruct net_device *netdev = adapter->netdev;\n+\tchar *speed = \"Unknown \";\n+\n+\tif (!adapter->link_up) {\n+\t\tnetdev_info(netdev, \"NIC Link is Down\\n\");\n+\t\treturn;\n+\t}\n+\n+\tswitch (adapter->link_speed) {\n+\tcase I40E_LINK_SPEED_40GB:\n+\t\tspeed = \"40 G\";\n+\t\tbreak;\n+\tcase I40E_LINK_SPEED_20GB:\n+\t\tspeed = \"20 G\";\n+\t\tbreak;\n+\tcase I40E_LINK_SPEED_10GB:\n+\t\tspeed = \"10 G\";\n+\t\tbreak;\n+\tcase I40E_LINK_SPEED_1GB:\n+\t\tspeed = \"1000 M\";\n+\t\tbreak;\n+\tcase I40E_LINK_SPEED_100MB:\n+\t\tspeed = \"100 M\";\n+\t\tbreak;\n+\tdefault:\n+\t\tbreak;\n+\t}\n+\n+\tnetdev_info(netdev, \"NIC Link is Up %sbps Full Duplex\\n\", speed);\n+}\n+\n+/**\n * i40evf_request_reset\n * @adapter: adapter structure\n *\n@@ -853,15 +892,13 @@ void i40evf_virtchnl_completion(struct i40evf_adapter *adapter,\n \t\t\t(struct i40e_virtchnl_pf_event *)msg;\n \t\tswitch (vpe->event) {\n \t\tcase I40E_VIRTCHNL_EVENT_LINK_CHANGE:\n-\t\t\tadapter->link_up =\n-\t\t\t\tvpe->event_data.link_event.link_status;\n-\t\t\tif (adapter->link_up && !netif_carrier_ok(netdev)) {\n-\t\t\t\tdev_info(&adapter->pdev->dev, \"NIC Link is Up\\n\");\n-\t\t\t\tnetif_carrier_on(netdev);\n-\t\t\t\tnetif_tx_wake_all_queues(netdev);\n-\t\t\t} else if (!adapter->link_up) {\n-\t\t\t\tdev_info(&adapter->pdev->dev, \"NIC Link is Down\\n\");\n-\t\t\t\tnetif_carrier_off(netdev);\n+\t\t\tadapter->link_speed =\n+\t\t\t\tvpe->event_data.link_event.link_speed;\n+\t\t\tif (adapter->link_up !=\n+\t\t\t vpe->event_data.link_event.link_status) {\n+\t\t\t\tadapter->link_up =\n+\t\t\t\t\tvpe->event_data.link_event.link_status;\n+\t\t\t\ti40evf_print_link_message(adapter);\n \t\t\t\tnetif_tx_stop_all_queues(netdev);\n \t\t\t}\n \t\t\tbreak;\n", "prefixes": [ "next", "S41-V2", "2/5" ] }