Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/655619/?format=api
{ "id": 655619, "url": "http://patchwork.ozlabs.org/api/patches/655619/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160803220528.26222-1-jacob.e.keller@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20160803220528.26222-1-jacob.e.keller@intel.com>", "list_archive_url": null, "date": "2016-08-03T22:05:27", "name": "[v1,1/2] fm10k: don't clear the RXQCTL register when enabling or disabling queues", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "4b806801929fbe50a09e0d9e05b5548251bc8068", "submitter": { "id": 9784, "url": "http://patchwork.ozlabs.org/api/people/9784/?format=api", "name": "Jacob Keller", "email": "jacob.e.keller@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160803220528.26222-1-jacob.e.keller@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/655619/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/655619/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3s4RwF20L3z9sxR\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 4 Aug 2016 08:05:48 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id BE802310CA;\n\tWed, 3 Aug 2016 22:05:46 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id kfPENzV0WjN9; Wed, 3 Aug 2016 22:05:46 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 0786B310AE;\n\tWed, 3 Aug 2016 22:05:46 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id C99D61C1E74\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 3 Aug 2016 22:05:43 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id A44C589E8F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 3 Aug 2016 22:05:43 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id URu1AJSscw5A for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 3 Aug 2016 22:05:37 +0000 (UTC)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 706E489D0C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 3 Aug 2016 22:05:37 +0000 (UTC)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby fmsmga102.fm.intel.com with ESMTP; 03 Aug 2016 15:05:37 -0700", "from jekeller-desk.amr.corp.intel.com ([134.134.3.116])\n\tby orsmga003.jf.intel.com with ESMTP; 03 Aug 2016 15:05:36 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.28,467,1464678000\"; d=\"scan'208\";a=\"859277549\"", "From": "Jacob Keller <jacob.e.keller@intel.com>", "To": "Intel Wired LAN <intel-wired-lan@lists.osuosl.org>", "Date": "Wed, 3 Aug 2016 15:05:27 -0700", "Message-Id": "<20160803220528.26222-1-jacob.e.keller@intel.com>", "X-Mailer": "git-send-email 2.9.2.701.gf965a18", "Subject": "[Intel-wired-lan] [PATCH v1 1/2] fm10k: don't clear the RXQCTL\n\tregister when enabling or disabling queues", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "Ensure that other bits in the RXQCTL register do not get cleared. This\nensures that bits related to queue ownership are maintained.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/intel/fm10k/fm10k_pci.c | 8 +++++---\n 1 file changed, 5 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c\nindex 59dc13f3f321..eea411472f1d 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c\n@@ -734,15 +734,15 @@ static void fm10k_configure_rx_ring(struct fm10k_intfc *interface,\n \tu64 rdba = ring->dma;\n \tstruct fm10k_hw *hw = &interface->hw;\n \tu32 size = ring->count * sizeof(union fm10k_rx_desc);\n-\tu32 rxqctl = FM10K_RXQCTL_ENABLE | FM10K_RXQCTL_PF;\n-\tu32 rxdctl = FM10K_RXDCTL_WRITE_BACK_MIN_DELAY;\n+\tu32 rxqctl, rxdctl = FM10K_RXDCTL_WRITE_BACK_MIN_DELAY;\n \tu32 srrctl = FM10K_SRRCTL_BUFFER_CHAINING_EN;\n \tu32 rxint = FM10K_INT_MAP_DISABLE;\n \tu8 rx_pause = interface->rx_pause;\n \tu8 reg_idx = ring->reg_idx;\n \n \t/* disable queue to avoid issues while updating state */\n-\tfm10k_write_reg(hw, FM10K_RXQCTL(reg_idx), 0);\n+\trxqctl = fm10k_read_reg(hw, FM10K_RXQCTL(reg_idx));\n+\trxqctl &= ~FM10K_RXQCTL_ENABLE;\n \tfm10k_write_flush(hw);\n \n \t/* possible poll here to verify ring resources have been cleaned */\n@@ -797,6 +797,8 @@ static void fm10k_configure_rx_ring(struct fm10k_intfc *interface,\n \tfm10k_write_reg(hw, FM10K_RXINT(reg_idx), rxint);\n \n \t/* enable queue */\n+\trxqctl = fm10k_read_reg(hw, FM10K_RXQCTL(reg_idx));\n+\trxqctl |= FM10K_RXQCTL_ENABLE;\n \tfm10k_write_reg(hw, FM10K_RXQCTL(reg_idx), rxqctl);\n \n \t/* place buffers on ring for receive data */\n", "prefixes": [ "v1", "1/2" ] }