Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/655178/?format=api
{ "id": 655178, "url": "http://patchwork.ozlabs.org/api/patches/655178/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/CAB=NE6Xu2t7JYUfvZcPSpX_Yt2yN9ooWgzctZFMr3LZGG1hVzw@mail.gmail.com/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<CAB=NE6Xu2t7JYUfvZcPSpX_Yt2yN9ooWgzctZFMr3LZGG1hVzw@mail.gmail.com>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/CAB=NE6Xu2t7JYUfvZcPSpX_Yt2yN9ooWgzctZFMr3LZGG1hVzw@mail.gmail.com/", "date": "2016-08-02T21:14:22", "name": "linker tables on powerpc - build issues", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "d6cf6a9fb976de9e6dd9bea040265fb1ecf5c143", "submitter": { "id": 13599, "url": "http://patchwork.ozlabs.org/api/people/13599/?format=api", "name": "Luis R. Rodriguez", "email": "mcgrof@do-not-panic.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/CAB=NE6Xu2t7JYUfvZcPSpX_Yt2yN9ooWgzctZFMr3LZGG1hVzw@mail.gmail.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/655178/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/655178/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3s3rKP44Lkz9sRB\n\tfor <patchwork-incoming@ozlabs.org>;\n\tWed, 3 Aug 2016 08:22:01 +1000 (AEST)", "from ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3s3rKP2xg5zDrTk\n\tfor <patchwork-incoming@ozlabs.org>;\n\tWed, 3 Aug 2016 08:22:01 +1000 (AEST)", "from mail-yw0-x243.google.com (mail-yw0-x243.google.com\n\t[IPv6:2607:f8b0:4002:c05::243])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3s3pqn2VHlzDqPn\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tWed, 3 Aug 2016 07:14:45 +1000 (AEST)", "by mail-yw0-x243.google.com with SMTP id z8so15553689ywa.0\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tTue, 02 Aug 2016 14:14:45 -0700 (PDT)", "by 10.37.2.200 with HTTP; Tue, 2 Aug 2016 14:14:22 -0700 (PDT)" ], "Authentication-Results": [ "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com header.b=zoJ+h5F9;\n\tdkim-atps=neutral", "lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com header.b=zoJ+h5F9;\n\tdkim-atps=neutral", "lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com header.b=zoJ+h5F9;\n\tdkim-atps=neutral" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\n\th=mime-version:sender:from:date:message-id:subject:to:cc;\n\tbh=QhsB3w3z/Ow8GfyHnMlOMfht/z988mQy1Ud9Lx6O22U=;\n\tb=zoJ+h5F9UEIEwcdB/ha1f7+j7NXv9292j1yhvdvapPYfhmzaYdGdVMg6mBkaxih70I\n\te00zejo6ViG3BlzR2k9uVB2D+ijadXuh41iVQfOKyiGzcALbSWCa5p4aLGPg9EyqkYOT\n\tYWOIsGma33A+QQiE/U7sL2+QkJiR3v9li0OqaBbEXKQ1+2/cT5OlziT4aW+U9Pct7jLc\n\t3T7/sY7vd+5Tr6rz1nzMf8G3MFM+Fg8JWl6YUajgKH85NSBIZNa9PhsB4HzLjTaFNQuI\n\tGvPx7zz7jJ5YJYmeV+hlaR2kb6lCZsiaKha2mVvnvdj71uJWhwt+BM7v6nnO9iKL3FOa\n\tfBbw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:mime-version:sender:from:date:message-id:subject\n\t:to:cc;\n\tbh=QhsB3w3z/Ow8GfyHnMlOMfht/z988mQy1Ud9Lx6O22U=;\n\tb=hVEBc9/F8QONzGmcepGd7Cw7wi0eqQlcYUjdo4cTxjzM5U05IY0hphz+DiTS9vneE9\n\tyBzvCPF97JpG+8J6NPzWUuxXkzZtQ0hYsoIzDAiaJbW+kAzypeHw5OdAsIG0reoDWbHc\n\tGDi5aOCDcz17U1qxXnRxo/cp0aOgxS2ncsCFK3GIRy0ho5I4ZTj11dOYKRMBsgeewiSA\n\t7DB4Nans+KlVW4IcdLlU5GseGI59e47USf8b/Sz+3BGFFJedYJvmtoxYL9NNZA+Ujkml\n\ttS/rqHiQfCNHhcLZEL8xB7Tc5P1I6/7giPz1UU4GuWbgyAlqeu56AGmA9N6cYOZUir8I\n\tL9yA==", "X-Gm-Message-State": "AEkoouuhYY0DgjNVwvziqaNLtjKkrIQCN/7iV6f+qEtsYp7xSvJyNOuLCEsIG2OrXUDFLMfIM6yt/Y5fDvrjxA==", "X-Received": "by 10.13.212.139 with SMTP id w133mr52479914ywd.49.1470172483280;\n\tTue, 02 Aug 2016 14:14:43 -0700 (PDT)", "MIME-Version": "1.0", "From": "\"Luis R. Rodriguez\" <mcgrof@do-not-panic.com>", "Date": "Tue, 2 Aug 2016 14:14:22 -0700", "X-Google-Sender-Auth": "8v8aKbR2tO-oZsCQgaR3W2WYj8A", "Message-ID": "<CAB=NE6Xu2t7JYUfvZcPSpX_Yt2yN9ooWgzctZFMr3LZGG1hVzw@mail.gmail.com>", "Subject": "linker tables on powerpc - build issues", "To": "Benjamin Herrenschmidt <benh@kernel.crashing.org>,\n\tPaul Mackerras <paulus@samba.org>, Michael Ellerman <mpe@ellerman.id.au>", "X-Mailman-Approved-At": "Wed, 03 Aug 2016 07:56:16 +1000", "X-BeenThere": "linuxppc-dev@lists.ozlabs.org", "X-Mailman-Version": "2.1.22", "Precedence": "list", "List-Id": "Linux on PowerPC Developers Mail List\n\t<linuxppc-dev.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>", "Cc": "Fengguang Wu <fengguang.wu@intel.com>, linuxppc-dev@lists.ozlabs.org,\n\t\"linux-kernel@vger.kernel.org\" <linux-kernel@vger.kernel.org>,\n\tGuenter Roeck <linux@roeck-us.net>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org", "Sender": "\"Linuxppc-dev\"\n\t<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>" }, "content": "I've run into a few compilation issues with linker tables support [0]\n[1] on only a few architectures:\n\nblackfin - compiler issue it seems, I have a work around now in place\narm - some alignment issue - still need to iron this out\npowerpc - issue with including <asm/sections.h> on <asm/jump_labels.h>\n\nThe issue with powerpc can be replicated easily with the patch below,\nand compilation fails even on a 'make defconfig' configuration, the\nissues are recurring include header ordering issues. I've given this\nsome tries to fix but am still a bit bewildered how to best do this\nwithout affecting non-powerpc compilations. The patch below\nreplicates the changes in question, it does not include the linker\ntable work at all, it just includes <asm/sections.h> instead of\n<asm/tables.h> to reduce and provide an example of the issues\nobserved. The list of errors are also pretty endless... so was hoping\nsome power folks might be able to take a glance if possible. If you\nhave any ideas, please let me know.\n\n[0] https://lkml.kernel.org/r/1469222687-1600-1-git-send-email-mcgrof@kernel.org\n[1] https://git.kernel.org/cgit/linux/kernel/git/mcgrof/linux-next.git/log/?h=20160729-linker-table-v4-blackfin2\n\n+\n #endif /* _ASM_GENERIC_SECTIONS_H_ */\n\n\n Luis", "diff": "diff --git a/arch/powerpc/include/asm/jump_label.h\nb/arch/powerpc/include/asm/jump_label.h\nindex 9a287e0ac8b1..68e46825b0f8 100644\n--- a/arch/powerpc/include/asm/jump_label.h\n+++ b/arch/powerpc/include/asm/jump_label.h\n@@ -9,6 +9,7 @@\n * as published by the Free Software Foundation; either version\n * 2 of the License, or (at your option) any later version.\n */\n+#include <asm/sections.h>\n\n #ifndef __ASSEMBLY__\n #include <linux/types.h>\ndiff --git a/arch/powerpc/include/asm/sections.h\nb/arch/powerpc/include/asm/sections.h\nindex 7dc006b58369..929decb62d9c 100644\n--- a/arch/powerpc/include/asm/sections.h\n+++ b/arch/powerpc/include/asm/sections.h\n@@ -1,11 +1,14 @@\n #ifndef _ASM_POWERPC_SECTIONS_H\n #define _ASM_POWERPC_SECTIONS_H\n-#ifdef __KERNEL__\n\n+#if defined(__KERNEL__) && !defined(__ASSEMBLER__) && !defined(__ASSEMBLY__)\n #include <linux/elf.h>\n #include <linux/uaccess.h>\n+#endif /* defined(__KERNEL__) && !defined(__ASSEMBLER__) &&\n!defined(__ASSEMBLY__) */\n+\n #include <asm-generic/sections.h>\n\n+#if defined(__KERNEL__) && !defined(__ASSEMBLER__) && !defined(__ASSEMBLY__)\n #ifdef __powerpc64__\n\n extern char __start_interrupts[];\n@@ -77,5 +80,5 @@ static inline void *dereference_function_descriptor(void *ptr)\n\n #endif\n\n-#endif /* __KERNEL__ */\n+#endif /* defined(__KERNEL__) && !defined(__ASSEMBLER__) &&\n!defined(__ASSEMBLY__) */\n #endif /* _ASM_POWERPC_SECTIONS_H */\ndiff --git a/include/asm-generic/sections.h b/include/asm-generic/sections.h\nindex af0254c09424..06bceee909da 100644\n--- a/include/asm-generic/sections.h\n+++ b/include/asm-generic/sections.h\n@@ -1,6 +1,8 @@\n #ifndef _ASM_GENERIC_SECTIONS_H_\n #define _ASM_GENERIC_SECTIONS_H_\n\n+#if defined(__KERNEL__) && !defined(__ASSEMBLER__) && !defined(__ASSEMBLY__)\n+\n /* References to section boundaries */\n\n #include <linux/compiler.h>\n@@ -128,4 +130,6 @@ static inline bool init_section_intersects(void\n*virt, size_t size)\n return memory_intersects(__init_begin, __init_end, virt, size);\n }\n\n+#endif /* defined(__KERNEL__) && !defined(__ASSEMBLER__) &&\n!defined(__ASSEMBLY__) */\n", "prefixes": [] }