Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/655079/?format=api
{ "id": 655079, "url": "http://patchwork.ozlabs.org/api/patches/655079/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1470161718-8824-1-git-send-email-xypron.glpk@gmx.de/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1470161718-8824-1-git-send-email-xypron.glpk@gmx.de>", "list_archive_url": null, "date": "2016-08-02T18:15:18", "name": "[1/1,v2] net: i10e: use matching format indentifiers", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "00a76329447c7d558628f46c9e448346bc152441", "submitter": { "id": 61270, "url": "http://patchwork.ozlabs.org/api/people/61270/?format=api", "name": "Heinrich Schuchardt", "email": "xypron.glpk@gmx.de" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1470161718-8824-1-git-send-email-xypron.glpk@gmx.de/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/655079/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/655079/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3s3ktQ6tGzz9sCY\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 3 Aug 2016 04:16:46 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 17E37895D8;\n\tTue, 2 Aug 2016 18:16:45 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id z1IuykIMxdSV; Tue, 2 Aug 2016 18:16:44 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 47E9A894B8;\n\tTue, 2 Aug 2016 18:16:44 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 2A1D01C1E55\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 2 Aug 2016 18:16:43 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 25A5786A09\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 2 Aug 2016 18:16:43 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id WiCvqX9iLqSz for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 2 Aug 2016 18:16:42 +0000 (UTC)", "from mout.gmx.net (mout.gmx.net [212.227.17.22])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id CAD5C866EB\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 2 Aug 2016 18:16:41 +0000 (UTC)", "from workstation4.fritz.box ([109.91.48.91]) by mail.gmx.com\n\t(mrgmx102) with ESMTPSA (Nemesis) id 0MIPhr-1bYmYL0BvL-0049O6;\n\tTue, 02 Aug 2016 20:15:26 +0200" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "Heinrich Schuchardt <xypron.glpk@gmx.de>", "To": "David Miller <davem@davemloft.net>", "Date": "Tue, 2 Aug 2016 20:15:18 +0200", "Message-Id": "<1470161718-8824-1-git-send-email-xypron.glpk@gmx.de>", "X-Mailer": "git-send-email 2.1.4", "In-Reply-To": "<20160731.204759.1283451349474511870.davem@davemloft.net>", "References": "<20160731.204759.1283451349474511870.davem@davemloft.net>", "X-Provags-ID": "V03:K0:+XDJkRJP2xtrOHLJSGLAvIGez9KOrovokX9L5Wk2R0+54PYgawy\n\tx3OH0+7FxeBQV0kDYchwxHowoT4K6BIsRbMtly6aL8vBtzWqACWtWSqFH1INl6RYLZUil6E\n\tXhjCr/ppyVxQpkp3eV0EYnYN/zO2v0uSNriAbIaEc4wpRNLBgZF3vau4GqBAU1PQnIkO8he\n\t460Dz/L3IXTXFhxjUk6xw==", "X-UI-Out-Filterresults": "notjunk:1; V01:K0:RoS4AJIIsrw=:ybekSD9PL+TlPOvsesP4nh\n\tvh+IPCq3osYvDysWyD9lv42cH96H5Wd4deT5c1dRrnnUlKw2BpHRpc/Q3kDjjUddJ7TAI0w1g\n\tCT0VKIHIsSd4KIXI1LqxdU64/ErVD8LqoSpwln4SbpNvVFfZR72cRoUoWFcA/g3BHm0ycryHw\n\tIh4O/qEO2krBqOeXnHMLb//j1FO2dYgqMxhx12DFH/3pVf3pQer+qBmQScQBvXc78b1O6BhhN\n\t4m9iVaGXEOXbUIEuTnaN94643o47RqJB2N9eGKjCafTZIO13mC3PtGsTDfiaQKdx0fjpb4PZX\n\t40I5nNM3D0hPxoBIbSYO/vbYmtUJ9HFNU7QUlDd3JwWeI6FRYv0ULSirhHUj+pgxSk5iid59n\n\tXI7lenPgm5RTLQuNWx48w9CJ9sQGZJzLuHfSvHWspjgERKNygdF/kGXzIJVmU2LjmKfcmCtne\n\tFbGo2f7NLmiTRXPx3At4XsqB6yDJaAa6zN6dNBQqd+TYr9H9aTbHYWh4aDzDJQHLvuGHzJcJa\n\t7ZoGPMcBPs0IlF15gdhAl8UDaTjJaAVazXLW7loKiDKuMw6Zy/WwmqyzhEUHu4QE6nZxd/d+S\n\t96CBOs0S6ZFxZfzlL91QqcKGP5PnhLHUGkxrHaR1WGLnUMwV5Q/SC/NO5XtO3qIqkMpOSA/VH\n\tAHkZTNka4/r9qWNzEDR3d1HZ5a1VEibKSNa1H6PM6eGXkmHJvqWpJCCedZvEIvjxWNLO+vUQV\n\tY+XGk2Dds3KsmCLX16KrVuFV1VYcAH9Iam4xelybVfaDon088biSR5jj8Lw=", "Cc": "Heinrich Schuchardt <xypron.glpk@gmx.de>, netdev@vger.kernel.org,\n\tintel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org", "Subject": "[Intel-wired-lan] [PATCH 1/1 v2] net: i10e: use matching format\n\tindentifiers", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "i is defined as int but output as %u several times.\nAdjust the format identifiers.\n\nv2:\n\tKeep definition of i as int.\n\tDavid indicated that this is the preferable way to define\n\tloop variables.\n\nSigned-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>\n---\n drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 26 +++++++++++++-------------\n 1 file changed, 13 insertions(+), 13 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\nindex c912e04..94ac712 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n@@ -1560,13 +1560,13 @@ static void i40e_get_strings(struct net_device *netdev, u32 stringset,\n \t\t}\n #endif\n \t\tfor (i = 0; i < vsi->num_queue_pairs; i++) {\n-\t\t\tsnprintf(p, ETH_GSTRING_LEN, \"tx-%u.tx_packets\", i);\n+\t\t\tsnprintf(p, ETH_GSTRING_LEN, \"tx-%d.tx_packets\", i);\n \t\t\tp += ETH_GSTRING_LEN;\n-\t\t\tsnprintf(p, ETH_GSTRING_LEN, \"tx-%u.tx_bytes\", i);\n+\t\t\tsnprintf(p, ETH_GSTRING_LEN, \"tx-%d.tx_bytes\", i);\n \t\t\tp += ETH_GSTRING_LEN;\n-\t\t\tsnprintf(p, ETH_GSTRING_LEN, \"rx-%u.rx_packets\", i);\n+\t\t\tsnprintf(p, ETH_GSTRING_LEN, \"rx-%d.rx_packets\", i);\n \t\t\tp += ETH_GSTRING_LEN;\n-\t\t\tsnprintf(p, ETH_GSTRING_LEN, \"rx-%u.rx_bytes\", i);\n+\t\t\tsnprintf(p, ETH_GSTRING_LEN, \"rx-%d.rx_bytes\", i);\n \t\t\tp += ETH_GSTRING_LEN;\n \t\t}\n \t\tif (vsi != pf->vsi[pf->lan_vsi] || pf->hw.partition_id != 1)\n@@ -1581,16 +1581,16 @@ static void i40e_get_strings(struct net_device *netdev, u32 stringset,\n \t\t\t}\n \t\t\tfor (i = 0; i < I40E_MAX_TRAFFIC_CLASS; i++) {\n \t\t\t\tsnprintf(p, ETH_GSTRING_LEN,\n-\t\t\t\t\t \"veb.tc_%u_tx_packets\", i);\n+\t\t\t\t\t \"veb.tc_%d_tx_packets\", i);\n \t\t\t\tp += ETH_GSTRING_LEN;\n \t\t\t\tsnprintf(p, ETH_GSTRING_LEN,\n-\t\t\t\t\t \"veb.tc_%u_tx_bytes\", i);\n+\t\t\t\t\t \"veb.tc_%d_tx_bytes\", i);\n \t\t\t\tp += ETH_GSTRING_LEN;\n \t\t\t\tsnprintf(p, ETH_GSTRING_LEN,\n-\t\t\t\t\t \"veb.tc_%u_rx_packets\", i);\n+\t\t\t\t\t \"veb.tc_%d_rx_packets\", i);\n \t\t\t\tp += ETH_GSTRING_LEN;\n \t\t\t\tsnprintf(p, ETH_GSTRING_LEN,\n-\t\t\t\t\t \"veb.tc_%u_rx_bytes\", i);\n+\t\t\t\t\t \"veb.tc_%d_rx_bytes\", i);\n \t\t\t\tp += ETH_GSTRING_LEN;\n \t\t\t}\n \t\t}\n@@ -1601,23 +1601,23 @@ static void i40e_get_strings(struct net_device *netdev, u32 stringset,\n \t\t}\n \t\tfor (i = 0; i < I40E_MAX_USER_PRIORITY; i++) {\n \t\t\tsnprintf(p, ETH_GSTRING_LEN,\n-\t\t\t\t \"port.tx_priority_%u_xon\", i);\n+\t\t\t\t \"port.tx_priority_%d_xon\", i);\n \t\t\tp += ETH_GSTRING_LEN;\n \t\t\tsnprintf(p, ETH_GSTRING_LEN,\n-\t\t\t\t \"port.tx_priority_%u_xoff\", i);\n+\t\t\t\t \"port.tx_priority_%d_xoff\", i);\n \t\t\tp += ETH_GSTRING_LEN;\n \t\t}\n \t\tfor (i = 0; i < I40E_MAX_USER_PRIORITY; i++) {\n \t\t\tsnprintf(p, ETH_GSTRING_LEN,\n-\t\t\t\t \"port.rx_priority_%u_xon\", i);\n+\t\t\t\t \"port.rx_priority_%d_xon\", i);\n \t\t\tp += ETH_GSTRING_LEN;\n \t\t\tsnprintf(p, ETH_GSTRING_LEN,\n-\t\t\t\t \"port.rx_priority_%u_xoff\", i);\n+\t\t\t\t \"port.rx_priority_%d_xoff\", i);\n \t\t\tp += ETH_GSTRING_LEN;\n \t\t}\n \t\tfor (i = 0; i < I40E_MAX_USER_PRIORITY; i++) {\n \t\t\tsnprintf(p, ETH_GSTRING_LEN,\n-\t\t\t\t \"port.rx_priority_%u_xon_2_xoff\", i);\n+\t\t\t\t \"port.rx_priority_%d_xon_2_xoff\", i);\n \t\t\tp += ETH_GSTRING_LEN;\n \t\t}\n \t\t/* BUG_ON(p - data != I40E_STATS_LEN * ETH_GSTRING_LEN); */\n", "prefixes": [ "1/1", "v2" ] }