Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/654172/?format=api
{ "id": 654172, "url": "http://patchwork.ozlabs.org/api/patches/654172/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160729173006.25548.93033.stgit@localhost6.localdomain6/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20160729173006.25548.93033.stgit@localhost6.localdomain6>", "list_archive_url": null, "date": "2016-07-29T17:30:06", "name": "[1/3] ixgbe: only check Tx queue enablement when debugging", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "0c6ec3f9070e6b1e5bdbe87296f5da4dbab762bf", "submitter": { "id": 1670, "url": "http://patchwork.ozlabs.org/api/people/1670/?format=api", "name": "Tantilov, Emil S", "email": "emil.s.tantilov@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160729173006.25548.93033.stgit@localhost6.localdomain6/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/654172/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/654172/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3s1G0r15yYz9syB\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 30 Jul 2016 03:28:44 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id B38788ABCE;\n\tFri, 29 Jul 2016 17:28:42 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Sjecn45iFFhE; Fri, 29 Jul 2016 17:28:41 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 3FFF28ABC2;\n\tFri, 29 Jul 2016 17:28:41 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 11EC61C1F52\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 29 Jul 2016 17:28:40 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 0EBC48ABCD\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 29 Jul 2016 17:28:40 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id txd9r3DuNNpZ for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 29 Jul 2016 17:28:38 +0000 (UTC)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id C936B8ABC2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 29 Jul 2016 17:28:38 +0000 (UTC)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga102.fm.intel.com with ESMTP; 29 Jul 2016 10:28:22 -0700", "from estantil-desk3.jf.intel.com (HELO localhost6.localdomain6)\n\t([134.134.3.186])\n\tby orsmga001.jf.intel.com with ESMTP; 29 Jul 2016 10:28:22 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.28,440,1464678000\"; d=\"scan'208\";\n\ta=\"1005020457\"", "From": "Emil Tantilov <emil.s.tantilov@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 29 Jul 2016 10:30:06 -0700", "Message-ID": "<20160729173006.25548.93033.stgit@localhost6.localdomain6>", "User-Agent": "StGit/0.17.1-17-ge4e0", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH 1/3] ixgbe: only check Tx queue enablement\n\twhen debugging", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "Following a write the TXDCTL.ENABLE bit is set only when the Tx queue\nis actually enabled, which may not happen during the configure phase even\nif we waited for it. Make this check debug only since this is causing\nconfusion with users who notice the warning in dmesg.\n\nSigned-off-by: Emil Tantilov <emil.s.tantilov@intel.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex 7871f53..f687b76 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -3224,7 +3224,7 @@ void ixgbe_configure_tx_ring(struct ixgbe_adapter *adapter,\n \t\ttxdctl = IXGBE_READ_REG(hw, IXGBE_TXDCTL(reg_idx));\n \t} while (--wait_loop && !(txdctl & IXGBE_TXDCTL_ENABLE));\n \tif (!wait_loop)\n-\t\te_err(drv, \"Could not enable Tx Queue %d\\n\", reg_idx);\n+\t\thw_dbg(hw, \"Could not enable Tx Queue %d\\n\", reg_idx);\n }\n \n static void ixgbe_setup_mtqc(struct ixgbe_adapter *adapter)\n", "prefixes": [ "1/3" ] }