Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/653461/?format=api
{ "id": 653461, "url": "http://patchwork.ozlabs.org/api/patches/653461/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1469646161-30024-6-git-send-email-bimmy.pujari@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1469646161-30024-6-git-send-email-bimmy.pujari@intel.com>", "list_archive_url": null, "date": "2016-07-27T19:02:34", "name": "[next,S40-V2,05/12] i40e: Fix static analysis tool warning", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "8c78cbd6d010964d28c35021010824611675aca5", "submitter": { "id": 68919, "url": "http://patchwork.ozlabs.org/api/people/68919/?format=api", "name": "Pujari, Bimmy", "email": "bimmy.pujari@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1469646161-30024-6-git-send-email-bimmy.pujari@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/653461/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/653461/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3s04BJ0Mhbz9t1r\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 28 Jul 2016 05:02:47 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 444F531291;\n\tWed, 27 Jul 2016 19:02:46 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id PcHvU-cTThjX; Wed, 27 Jul 2016 19:02:41 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id A43D73127A;\n\tWed, 27 Jul 2016 19:02:35 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id DFEE21C1774\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 27 Jul 2016 19:02:31 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id D21DA3123F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 27 Jul 2016 19:02:31 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 9jcFcj74cuCY for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 27 Jul 2016 19:02:30 +0000 (UTC)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby silver.osuosl.org (Postfix) with ESMTP id B7D6130950\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 27 Jul 2016 19:02:29 +0000 (UTC)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga103.jf.intel.com with ESMTP; 27 Jul 2016 12:02:08 -0700", "from bimmy.jf.intel.com (HELO bimmy.linux1.jf.intel.com)\n\t([134.134.2.177])\n\tby orsmga003.jf.intel.com with ESMTP; 27 Jul 2016 12:02:08 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.28,430,1464678000\"; d=\"scan'208\";a=\"854735001\"", "From": "Bimmy Pujari <bimmy.pujari@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 27 Jul 2016 12:02:34 -0700", "Message-Id": "<1469646161-30024-6-git-send-email-bimmy.pujari@intel.com>", "X-Mailer": "git-send-email 2.4.11", "In-Reply-To": "<1469646161-30024-1-git-send-email-bimmy.pujari@intel.com>", "References": "<1469646161-30024-1-git-send-email-bimmy.pujari@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S40-V2 05/12] i40e: Fix static\n\tanalysis tool warning", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Dave Ertman <david.m.ertman@intel.com>\n\nThis patch fixes a problem where a static analysis tool generates\na warning for \"INVARIANT_CONDITION: Expression 'enabled_tc' used\nin the condition always yields the same result.\"\n\nWithout this patch, the driver will not pass the static analysis\ntool checks without generating warnings.\n\nThis patch fixes the problem by eliminating the irrelevant check\nand redundant assignment for the value of enabled_tc.\n\nSigned-off-by: Dave Ertman <david.m.ertman@intel.com>\nChange-ID: Ia7d44cb050f507df7de333e96369d322e08bf408\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 4 +---\n 1 file changed, 1 insertion(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 77a35cf..d80efc1 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -4590,7 +4590,7 @@ static u8 i40e_dcb_get_enabled_tc(struct i40e_dcbx_config *dcbcfg)\n static u8 i40e_pf_get_num_tc(struct i40e_pf *pf)\n {\n \tstruct i40e_hw *hw = &pf->hw;\n-\tu8 i, enabled_tc;\n+\tu8 i, enabled_tc = 1;\n \tu8 num_tc = 0;\n \tstruct i40e_dcbx_config *dcbcfg = &hw->local_dcbx_config;\n \n@@ -4608,8 +4608,6 @@ static u8 i40e_pf_get_num_tc(struct i40e_pf *pf)\n \telse\n \t\treturn 1; /* Only TC0 */\n \n-\t/* At least have TC0 */\n-\tenabled_tc = (enabled_tc ? enabled_tc : 0x1);\n \tfor (i = 0; i < I40E_MAX_TRAFFIC_CLASS; i++) {\n \t\tif (enabled_tc & BIT(i))\n \t\t\tnum_tc++;\n", "prefixes": [ "next", "S40-V2", "05/12" ] }