Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/653444/?format=api
{ "id": 653444, "url": "http://patchwork.ozlabs.org/api/patches/653444/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160727175508.31818.55615.stgit@localhost6.localdomain6/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20160727175508.31818.55615.stgit@localhost6.localdomain6>", "list_archive_url": null, "date": "2016-07-27T17:55:08", "name": "ixgbevf: fix incorrect MAC address on load", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "3759bf2fdff953bef388851f27671d451b96ce76", "submitter": { "id": 1670, "url": "http://patchwork.ozlabs.org/api/people/1670/?format=api", "name": "Tantilov, Emil S", "email": "emil.s.tantilov@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160727175508.31818.55615.stgit@localhost6.localdomain6/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/653444/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/653444/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3s02fS32ygz9t2P\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 28 Jul 2016 03:53:35 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 2B92231203;\n\tWed, 27 Jul 2016 17:53:33 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Meyow5jcxfxA; Wed, 27 Jul 2016 17:53:31 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 42A383117A;\n\tWed, 27 Jul 2016 17:53:31 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 58F6B1C1774\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 27 Jul 2016 17:53:30 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 5281D87B75\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 27 Jul 2016 17:53:30 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id ZZMESYPKps3n for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 27 Jul 2016 17:53:29 +0000 (UTC)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 4151687B90\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 27 Jul 2016 17:53:29 +0000 (UTC)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby orsmga102.jf.intel.com with ESMTP; 27 Jul 2016 10:53:29 -0700", "from estantil-desk3.jf.intel.com (HELO localhost6.localdomain6)\n\t([134.134.3.186])\n\tby fmsmga004.fm.intel.com with ESMTP; 27 Jul 2016 10:53:28 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.28,430,1464678000\"; d=\"scan'208\";a=\"146442082\"", "From": "Emil Tantilov <emil.s.tantilov@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 27 Jul 2016 10:55:08 -0700", "Message-ID": "<20160727175508.31818.55615.stgit@localhost6.localdomain6>", "User-Agent": "StGit/0.17.1-17-ge4e0", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH] ixgbevf: fix incorrect MAC address on load", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "The PF driver was only receiving the first 4 bytes of the MAC due\nto an incorrect size parameter for ixgbevf_write_msg_read_ack()\nin ixgbevf_set_rar_vf().\n\nCorrect the size by calculating it on a fly for all instances where\nwe call ixgbevf_write_msg_read_ack()\n\nSigned-off-by: Emil Tantilov <emil.s.tantilov@intel.com>\n---\n drivers/net/ethernet/intel/ixgbevf/vf.c | 21 ++++++++++++++-------\n 1 file changed, 14 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbevf/vf.c b/drivers/net/ethernet/intel/ixgbevf/vf.c\nindex a52f70e..d46ba1d 100644\n--- a/drivers/net/ethernet/intel/ixgbevf/vf.c\n+++ b/drivers/net/ethernet/intel/ixgbevf/vf.c\n@@ -284,7 +284,8 @@ static s32 ixgbevf_set_uc_addr_vf(struct ixgbe_hw *hw, u32 index, u8 *addr)\n \tif (addr)\n \t\tether_addr_copy(msg_addr, addr);\n \n-\tret_val = ixgbevf_write_msg_read_ack(hw, msgbuf, msgbuf, 3);\n+\tret_val = ixgbevf_write_msg_read_ack(hw, msgbuf, msgbuf,\n+\t\t\t\t\t sizeof(msgbuf) / sizeof(u32));\n \tif (!ret_val) {\n \t\tmsgbuf[0] &= ~IXGBE_VT_MSGTYPE_CTS;\n \n@@ -441,7 +442,8 @@ static s32 ixgbevf_set_rar_vf(struct ixgbe_hw *hw, u32 index, u8 *addr,\n \tmsgbuf[0] = IXGBE_VF_SET_MAC_ADDR;\n \tether_addr_copy(msg_addr, addr);\n \n-\tret_val = ixgbevf_write_msg_read_ack(hw, msgbuf, msgbuf, 2);\n+\tret_val = ixgbevf_write_msg_read_ack(hw, msgbuf, msgbuf,\n+\t\t\t\t\t sizeof(msgbuf) / sizeof(u32));\n \n \tmsgbuf[0] &= ~IXGBE_VT_MSGTYPE_CTS;\n \n@@ -551,7 +553,8 @@ static s32 ixgbevf_update_xcast_mode(struct ixgbe_hw *hw, int xcast_mode)\n \tmsgbuf[0] = IXGBE_VF_UPDATE_XCAST_MODE;\n \tmsgbuf[1] = xcast_mode;\n \n-\terr = ixgbevf_write_msg_read_ack(hw, msgbuf, msgbuf, 2);\n+\terr = ixgbevf_write_msg_read_ack(hw, msgbuf, msgbuf,\n+\t\t\t\t\t sizeof(msgbuf) / sizeof(u32));\n \tif (err)\n \t\treturn err;\n \n@@ -588,7 +591,8 @@ static s32 ixgbevf_set_vfta_vf(struct ixgbe_hw *hw, u32 vlan, u32 vind,\n \t/* Setting the 8 bit field MSG INFO to TRUE indicates \"add\" */\n \tmsgbuf[0] |= vlan_on << IXGBE_VT_MSGINFO_SHIFT;\n \n-\terr = ixgbevf_write_msg_read_ack(hw, msgbuf, msgbuf, 2);\n+\terr = ixgbevf_write_msg_read_ack(hw, msgbuf, msgbuf,\n+\t\t\t\t\t sizeof(msgbuf) / sizeof(u32));\n \tif (err)\n \t\tgoto mbx_err;\n \n@@ -791,7 +795,8 @@ static s32 ixgbevf_set_rlpml_vf(struct ixgbe_hw *hw, u16 max_size)\n \tmsgbuf[0] = IXGBE_VF_SET_LPE;\n \tmsgbuf[1] = max_size;\n \n-\tret_val = ixgbevf_write_msg_read_ack(hw, msgbuf, msgbuf, 2);\n+\tret_val = ixgbevf_write_msg_read_ack(hw, msgbuf, msgbuf,\n+\t\t\t\t\t sizeof(msgbuf) / sizeof(u32));\n \tif (ret_val)\n \t\treturn ret_val;\n \tif ((msgbuf[0] & IXGBE_VF_SET_LPE) &&\n@@ -837,7 +842,8 @@ static int ixgbevf_negotiate_api_version_vf(struct ixgbe_hw *hw, int api)\n \tmsg[1] = api;\n \tmsg[2] = 0;\n \n-\terr = ixgbevf_write_msg_read_ack(hw, msg, msg, 3);\n+\terr = ixgbevf_write_msg_read_ack(hw, msg, msg,\n+\t\t\t\t\t sizeof(msg) / sizeof(u32));\n \tif (!err) {\n \t\tmsg[0] &= ~IXGBE_VT_MSGTYPE_CTS;\n \n@@ -887,7 +893,8 @@ int ixgbevf_get_queues(struct ixgbe_hw *hw, unsigned int *num_tcs,\n \tmsg[0] = IXGBE_VF_GET_QUEUE;\n \tmsg[1] = msg[2] = msg[3] = msg[4] = 0;\n \n-\terr = ixgbevf_write_msg_read_ack(hw, msg, msg, 5);\n+\terr = ixgbevf_write_msg_read_ack(hw, msg, msg,\n+\t\t\t\t\t sizeof(msg) / sizeof(u32));\n \tif (!err) {\n \t\tmsg[0] &= ~IXGBE_VT_MSGTYPE_CTS;\n \n", "prefixes": [] }