Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/652439/?format=api
{ "id": 652439, "url": "http://patchwork.ozlabs.org/api/patches/652439/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1469488555-28187-10-git-send-email-bimmy.pujari@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1469488555-28187-10-git-send-email-bimmy.pujari@intel.com>", "list_archive_url": null, "date": "2016-07-25T23:15:51", "name": "[next,S40,09/13] i40e: Don't notify client of VF reset during VF creation", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "ce1de5e4d3ecd600c980f6e277ab20769fceed71", "submitter": { "id": 68919, "url": "http://patchwork.ozlabs.org/api/people/68919/?format=api", "name": "Pujari, Bimmy", "email": "bimmy.pujari@intel.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1469488555-28187-10-git-send-email-bimmy.pujari@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/652439/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/652439/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3ryxtx2w7kz9t0G\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 26 Jul 2016 09:15:37 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 000D78865C;\n\tMon, 25 Jul 2016 23:15:35 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id stqbwsM-6la5; Mon, 25 Jul 2016 23:15:33 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id EADAE88C67;\n\tMon, 25 Jul 2016 23:15:32 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 9C8CC1C1511\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 25 Jul 2016 23:15:27 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 998B0866E4\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 25 Jul 2016 23:15:27 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id bLPMI0Th3HO0 for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 25 Jul 2016 23:15:25 +0000 (UTC)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id A3B0F88BA3\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 25 Jul 2016 23:15:25 +0000 (UTC)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby fmsmga101.fm.intel.com with ESMTP; 25 Jul 2016 16:15:24 -0700", "from bimmy.jf.intel.com (HELO bimmy.linux1.jf.intel.com)\n\t([134.134.2.177])\n\tby orsmga003.jf.intel.com with ESMTP; 25 Jul 2016 16:15:23 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.28,421,1464678000\"; d=\"scan'208\";a=\"853301726\"", "From": "Bimmy Pujari <bimmy.pujari@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Mon, 25 Jul 2016 16:15:51 -0700", "Message-Id": "<1469488555-28187-10-git-send-email-bimmy.pujari@intel.com>", "X-Mailer": "git-send-email 2.4.11", "In-Reply-To": "<1469488555-28187-1-git-send-email-bimmy.pujari@intel.com>", "References": "<1469488555-28187-1-git-send-email-bimmy.pujari@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S40 09/13] i40e: Don't notify client\n\tof VF reset during VF creation", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Avinash Dayanand <avinash.dayanand@intel.com>\n\nVF goes through reset path during VF creation which happens to also\nhave notification of VF reset to client. Adding conditional check to\navoid wrongly notifying VF reset during VF creation.\n\nAlso changing the call order of VF enable, calling it after VF creation\nrather than before.\n\nSigned-off-by: Avinash Dayanand <avinash.dayanand@intel.com>\nChange-ID: I96eabd99deae746a2f0fc465194c886f196178ce\n---\n drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 7 +++++--\n 1 file changed, 5 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\nindex 0fa050a..5ea659c 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n@@ -991,7 +991,9 @@ complete_reset:\n \t\ti40e_enable_vf_mappings(vf);\n \t\tset_bit(I40E_VF_STAT_ACTIVE, &vf->vf_states);\n \t\tclear_bit(I40E_VF_STAT_DISABLED, &vf->vf_states);\n-\t\ti40e_notify_client_of_vf_reset(pf, abs_vf_id);\n+\t\t/* Do not notify the client during VF init */\n+\t\tif (vf->pf->num_alloc_vfs)\n+\t\t\ti40e_notify_client_of_vf_reset(pf, abs_vf_id);\n \t\tvf->num_vlan = 0;\n \t}\n \t/* tell the VF the reset is done */\n@@ -1090,7 +1092,6 @@ int i40e_alloc_vfs(struct i40e_pf *pf, u16 num_alloc_vfs)\n \t\t\tgoto err_iov;\n \t\t}\n \t}\n-\ti40e_notify_client_of_vf_enable(pf, num_alloc_vfs);\n \t/* allocate memory */\n \tvfs = kcalloc(num_alloc_vfs, sizeof(struct i40e_vf), GFP_KERNEL);\n \tif (!vfs) {\n@@ -1114,6 +1115,8 @@ int i40e_alloc_vfs(struct i40e_pf *pf, u16 num_alloc_vfs)\n \t}\n \tpf->num_alloc_vfs = num_alloc_vfs;\n \n+\ti40e_notify_client_of_vf_enable(pf, num_alloc_vfs);\n+\n err_alloc:\n \tif (ret)\n \t\ti40e_free_vfs(pf);\n", "prefixes": [ "next", "S40", "09/13" ] }